[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

2018-01-07 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 128883. mgorny retitled this revision from "[lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds" to "[lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB". mgorny edited the summary of this revision. mgorny added a comment. Updated th

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

2018-01-07 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. I was talking of: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp tools/debugserver/source/RNBRemote.cpp https://reviews.llvm.org/D41725 _

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

2018-01-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D41725#969189, @mgorny wrote: > That said, is there a reason for LLDB to use zlib directly instead of using > the LLVM support compression library? We aren't using zlib directly. We only need to know whether llvm was configured with zlib sup