Author: jmolenda
Date: Thu Dec 21 19:27:02 2017
New Revision: 321338
URL: http://llvm.org/viewvc/llvm-project?rev=321338&view=rev
Log:
Change SBProcess::ReadCStringFromMemory() back to returning
an empty Python string object when it reads a 0-length
string out of memory (and a successful SBError
Author: jmolenda
Date: Thu Dec 21 16:16:04 2017
New Revision: 321328
URL: http://llvm.org/viewvc/llvm-project?rev=321328&view=rev
Log:
Change the default Aarch64 ISA to be v8.2 to correctly decode newer
instructions (e.g. on the new iphones).
Modified:
lldb/trunk/source/Plugins/Disassembler
lldb-test doesn’t actually exercise any of this. It’s a pretty new addition
and doesn’t even support pdb yet as far as I know. So when you say it fails
without the other changes, but passes with this, I think you must be
talking about some test that runs via check-lldb, or some unittest.
To be cle
Author: adrian
Date: Thu Dec 21 15:04:51 2017
New Revision: 321322
URL: http://llvm.org/viewvc/llvm-project?rev=321322&view=rev
Log:
Bring clang options in error messages up to date.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/source/Plug
asmith added a comment.
This fix is part of a larger set of changes to retrieve the type for a function
signature and I don't see how to test for this without those changes. With all
the other changes, lldb-test fails without this fix and passes with it. So it's
implicitly already tested.
Rep
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for all the revisions. Looks good.
https://reviews.llvm.org/D41352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
That's great, thanks for the explanation. I'll look into that.
On 21 December 2017 at 16:34, Greg Clayton wrote:
>
> On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits
> wrote:
>
> On 21 December 2017 at 15:17, Pavel Labath wrote:
>
> Right now I'm looking at two (ignoring the debug-inf
labath updated this revision to Diff 127898.
labath added a comment.
Add PushEnvironmentIfNeeded to avoid creating duplicate entries in the
environment.
https://reviews.llvm.org/D41352
Files:
tools/debugserver/source/RNBContext.cpp
tools/debugserver/source/RNBContext.h
tools/debugserver/
No worries! Do you want me to assign a PR/radar to you?
Thanks!
--
Davide
On Thu, Dec 21, 2017 at 5:41 PM, Jason Molenda wrote:
> Yeah I need to see if I can write a unit test instantiating the platform and
> changing the values that HostInfo::GetLLDBPath returns to synthetic values,
> but I
Yeah I need to see if I can write a unit test instantiating the platform and
changing the values that HostInfo::GetLLDBPath returns to synthetic values, but
I haven’t had time to look at that yet.
> On Dec 21, 2017, at 7:01 AM, Davide Italiano via lldb-commits
> wrote:
>
> Jason, any chance
BTW: we should remove the GetIsDynamicLinkEditor() from Module.h/cpp and
ObjectFile.h, ObjectFileMachO.h/.cpp since it is dead code now.
> On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits
> wrote:
>
> On 21 December 2017 at 15:17, Pavel Labath wrote:
>> Right now I'm looking at two
> On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits
> wrote:
>
> On 21 December 2017 at 15:17, Pavel Labath wrote:
>> Right now I'm looking at two (ignoring the debug-info multiplication):
>> TestExprs2.py and TestTopLevelExprs.py
>> TestExprs2 is encountering ambiguity when looking u
clayborg added a comment.
Looks good!
Repository:
rL LLVM
https://reviews.llvm.org/D41086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Thu Dec 21 07:52:59 2017
New Revision: 321277
URL: http://llvm.org/viewvc/llvm-project?rev=321277&view=rev
Log:
Make one more test redhat-compatible
This test was also using "a" in an expression.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top
On 21 December 2017 at 15:17, Pavel Labath wrote:
> Right now I'm looking at two (ignoring the debug-info multiplication):
> TestExprs2.py and TestTopLevelExprs.py
> TestExprs2 is encountering ambiguity when looking up the "environ"
> symbol (the dynamic linker contains an extra copy). I think I k
Right now I'm looking at two (ignoring the debug-info multiplication):
TestExprs2.py and TestTopLevelExprs.py
TestExprs2 is encountering ambiguity when looking up the "environ"
symbol (the dynamic linker contains an extra copy). I think I know how
to handle that.
I haven't yet looked at what is th
What's the number of failures on Linux x86/64 red hat currently?
Thanks,
--
Davide
On Thu, Dec 21, 2017 at 4:09 PM, Pavel Labath wrote:
> Yeah, purely renaming the variables would be a bit like hiding
> problems under the carpet. But, I think adding the new test makes up
> for that. This way, a
Yeah, purely renaming the variables would be a bit like hiding
problems under the carpet. But, I think adding the new test makes up
for that. This way, anyone who wants to fix this issue in the future
will have a simple test to validate his fix.
On 21 December 2017 at 14:55, Davide Italiano wrote
Jason, any chance we can write a test case for this?
--
Davide
On Mon, Dec 11, 2017 at 12:52 AM, Davide Italiano wrote:
> Testcase?
>
> On Fri, Dec 8, 2017 at 7:06 PM, Jason Molenda via lldb-commits
> wrote:
>> Author: jmolenda
>> Date: Fri Dec 8 19:06:19 2017
>> New Revision: 320240
>>
>> URL
ping?
On Mon, Dec 11, 2017 at 12:55 AM, Davide Italiano wrote:
> ping. Any luck trying to write a testcase?
> This is a great opportunity to discuss whether is feasible and we can
> improve the testing strategy here.
>
> --
> Davide
>
> On Fri, Dec 1, 2017 at 11:02 AM, Davide Italiano
> wrote:
davide added a comment.
Indeed, this needs to be tested.
Repository:
rL LLVM
https://reviews.llvm.org/D41427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Thank you Pavel.
I was really nervous about making this change but I agree it's for the best.
Thanks,
--
Davide
On Thu, Dec 21, 2017 at 3:40 PM, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Thu Dec 21 06:40:03 2017
> New Revision: 321271
>
> URL: http://llvm.org/viewvc/llvm-pro
Author: labath
Date: Thu Dec 21 06:40:03 2017
New Revision: 321271
URL: http://llvm.org/viewvc/llvm-project?rev=321271&view=rev
Log:
Work around test failures on red-hat linux
Two tests were failing because the debugger was picking up multiply
defined internal symbols from the system libraries. T
labath added inline comments.
Comment at: tools/debugserver/source/debugserver.cpp:1426
+for (i = 0; (env_entry = host_env[i]) != NULL; ++i)
+ remote->Context().PushEnvironment(env_entry);
+ }
clayborg wrote:
> We need to check if the env var is already
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321255: Make sure DataBufferLLVM contents are writable
(authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D40079
Files:
lldb/trunk/include/lldb/Interpreter/OptionValue
Author: labath
Date: Thu Dec 21 02:54:30 2017
New Revision: 321255
URL: http://llvm.org/viewvc/llvm-project?rev=321255&view=rev
Log:
Make sure DataBufferLLVM contents are writable
Summary:
We sometimes need to write to the object file we've mapped into memory,
generally to apply relocations to de
26 matches
Mail list logo
