[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

2017-12-16 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. lgtm, if you have some time in the future for further improvements Greg's suggestion would be a good way to make this better. Repository: rL LLVM https://reviews.llvm.org/D41086 _

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

2017-12-16 Thread Aaron Smith via Phabricator via lldb-commits
asmith updated this revision to Diff 127255. asmith added a comment. This changes SymbolFilePDB::FindTypesByRegex () to take an lldb_private::RegularExpression as the argument and removes the use of the STL regex. Repository: rL LLVM https://reviews.llvm.org/D41086 Files: source/Plugins/