This revision was automatically updated to reflect the committed changes.
Closed by commit rL316244: lldb-server tests: Propagate environment variables
(pr34192) (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39010
Files:
lldb/trunk/unittests/tools/lldb-server/tests/Tes
Author: labath
Date: Fri Oct 20 15:39:18 2017
New Revision: 316244
URL: http://llvm.org/viewvc/llvm-project?rev=316244&view=rev
Log:
lldb-server tests: Propagate environment variables (pr34192)
Summary:
Without this, the launching of the test inferior may fail if it depends
on some component of t
labath updated this revision to Diff 119710.
labath added a comment.
The previous fix had a problem where a more paraniod libc (e.g., android, but I
suspect freebds would do that as well) would detect that the
thread unlocking the mutex is not the same one as the one that locked, and
refused to co
clayborg added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:284
+ switch (watch_flags) {
+ case write_mode:
+rw_mode = PPC_BREAKPOINT_TRIGGER_WRITE;
anajuliapc wrote:
> clayborg wrote:
> > We should use t
jasonmolenda added a comment.
Sorry for missing this back in August.
I think it'd be clearer to import your python once in the startup, like
-o "script import $module" \
Multiple imports are a no-op IIUC so it's harmless to re-import the module
every time the breakpoint is hit (I'm guessing it
Author: labath
Date: Fri Oct 20 12:44:53 2017
New Revision: 316231
URL: http://llvm.org/viewvc/llvm-project?rev=316231&view=rev
Log:
Revert "Logging: Make sure logging machinery is in a consistent state after
forking"
The pthread_atfork trick breaks on android, because
pthread_rwlock_unlock dete
anajuliapc added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:284
+ switch (watch_flags) {
+ case write_mode:
+rw_mode = PPC_BREAKPOINT_TRIGGER_WRITE;
clayborg wrote:
> We should use the lldb::WatchpointK
jingham added a comment.
I can't see anything wrong with the SB API use here. I don't feel qualified to
comment on the most effective workflow for an analysis I've never had to do,
however.
https://reviews.llvm.org/D36347
___
lldb-commits mailing
clayborg added a comment.
If you want to run the script from the command line, then it is necessary. If
it is run from within LLDB it will just work. I like to have my LLDB python
scripts work both ways.
This might be better implemented as a new command that gets installed and can
be used with
zturner added a comment.
In https://reviews.llvm.org/D36347#902157, @clayborg wrote:
> Please do convert to python. Just know that you can use "lldb -P" to get the
> python path that is needed in order to do "import lldb" in the python script.
> So you can try doing a "import lldb", and if that
clayborg added a comment.
Please do convert to python. Just know that you can use "lldb -P" to get the
python path that is needed in order to do "import lldb" in the python script.
So you can try doing a "import lldb", and if that fails, catch the exception,
run "lldb -P", add that path to the
clayborg added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:284
+ switch (watch_flags) {
+ case write_mode:
+rw_mode = PPC_BREAKPOINT_TRIGGER_WRITE;
We should use the lldb::WatchpointKind from lldb-enume
+jingham
On Fri, Oct 20, 2017 at 6:57 AM Don Hinton via Phabricator <
revi...@reviews.llvm.org> wrote:
> hintonda added a comment.
>
> In https://reviews.llvm.org/D36347#901885, @zturner wrote:
>
> > One possible reason for why this never got any traction is that
> `lldb-commits` wasn't added as
hintonda added a comment.
In https://reviews.llvm.org/D36347#901885, @zturner wrote:
> One possible reason for why this never got any traction is that
> `lldb-commits` wasn't added as a subscriber. While it's true that the tagged
> people should have chimed in, having the whole commits list wi
14 matches
Mail list logo
