Author: lemo
Date: Tue Oct 3 15:30:02 2017
New Revision: 314856
URL: http://llvm.org/viewvc/llvm-project?rev=314856&view=rev
Log:
updating svn:ignore
Modified:
lldb/trunk/ (props changed)
Propchange: lldb/trunk/
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314849: cmake + xcode: prevent gtests from using includes
from project root (authored by penryu).
Changed prior to commit:
https://reviews.llvm.org/D36598?vs=112052&id=117587#toc
Repository:
rL LLVM
Author: penryu
Date: Tue Oct 3 14:20:18 2017
New Revision: 314849
URL: http://llvm.org/viewvc/llvm-project?rev=314849&view=rev
Log:
cmake + xcode: prevent gtests from using includes from project root
Summary:
At present, several gtests in the lldb open source codebase are using
#include statemen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314832: [lldb] Fix initialization of m_debug_cu_index_map
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D38492?vs=117470&id=117570#toc
Repository:
rL LLVM
https://reviews
Author: alexshap
Date: Tue Oct 3 12:56:21 2017
New Revision: 314832
URL: http://llvm.org/viewvc/llvm-project?rev=314832&view=rev
Log:
[lldb] Fix initialization of m_debug_cu_index_map
SymbolFileDWARFDwp contains m_debug_cu_index_map which was previously
initialized incorrectly: before m_debug_c
zturner added inline comments.
Comment at: source/Utility/DataExtractor.cpp:566
size_t byte_size) const {
- switch (byte_size) {
- case 1:
-return GetU8(offset_ptr);
-break;
- case 2:
-return GetU16(offset_ptr);
-break;
- cas
jingham added a comment.
See inlined comments.
Comment at: source/Core/DumpDataExtractor.cpp:275-281
+ // Reject invalid item_byte_size.
+ if (item_byte_size > 8) {
+s->Printf("error: unsupported byte size (%" PRIu64 ") for char format",
+ (ui
petpav01 added a comment.
Thank you for the initial review.
Comment at: source/Core/DumpDataExtractor.cpp:275-281
+ // Reject invalid item_byte_size.
+ if (item_byte_size > 8) {
+s->Printf("error: unsupported byte size (%" PRIu64 ") for char format",
+
alexandreyy added a comment.
Are these changes ok?
I am implementing the read/write functions for the other registers.
And I will add it later.
In https://reviews.llvm.org/D38323#883429, @clayborg wrote:
> Looks fine. One main questions for new linux archs in particular: is linux
> using the ll
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for fixing it.
I am slightly confused why it was working for me when I tested it before
submission but I must have messed up something during testing.
Repository
10 matches
Mail list logo
