zturner added inline comments.
Comment at: source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:635-652
const ConstString name(context.m_decl_name.getAsString().c_str());
const char *name_unique_cstr = name.GetCString();
static ConstString id_name("id");
stati
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:651-652
return;
+ if (name_unique_cstr[0] == '_' && name_unique_cstr[1] == '$')
+
gkistanova added a comment.
Hi Pavel,
The patch looks Ok, with a small issue to address before committing.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:921
scriptExt='.sh',
+ extra_cmake_args=[],
):
---
spyffe created this revision.
spyffe added a project: LLDB.
Herald added subscribers: arichardson, aprantl, sdardis.
The IR dynamic checks are self-contained functions whose job is to
- verify that pointers referenced in an expression are valid at runtime; and
- verify that selectors sent to Obje
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313904: [LLDB] Implement interactive command interruption
(authored by amccarth).
Changed prior to commit:
https://reviews.llvm.org/D37923?vs=116074&id=116247#toc
Repository:
rL LLVM
https://reviews
Author: amccarth
Date: Thu Sep 21 12:36:52 2017
New Revision: 313904
URL: http://llvm.org/viewvc/llvm-project?rev=313904&view=rev
Log:
[LLDB] Implement interactive command interruption
The core of this change is the new CommandInterpreter::m_command_state, which
models the state transitions for i
I've created a Phabricator review.
DWARF sections in executables/dylibs seem to specify 0 as the section address,
and lldb depends on the abbreviation addresses in the debug_info section being
0-relative.
My synthetic file address logic explicitly excludes non-program (e.g. symtab)
and debug se
I am worried that this will adversely affect the normal DWARF that is in ELF
files. What does typical DWARF look like when all of the file addresses in
DWARF and the symtab are set correctly to unique virtual addresses? No
relocations on any addresses? If all "file addresses" are set to unique o
