dvlahovski accepted this revision.
dvlahovski added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D37527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
This looks fine.
Make sure you've run the LLDB tests. I don't expect this change to have much
risk for breaking any of them, but it's a good habit. `ninja check-lldb`
For future patch r
ted created this revision.
Herald added a subscriber: aprantl.
Test was skipped because -data-evaluate-expression was thought
to not work on globals. This is not the case - the issue was clang
removes debug info for globals in cpp files that are not used.
Add a reference to the globals in questio
ted added a comment.
Tested with clang 3.8 on top-of-tree lldb-mi on Ubuntu 14.
https://reviews.llvm.org/D37533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: cbieneman
Date: Wed Sep 6 13:15:43 2017
New Revision: 312666
URL: http://llvm.org/viewvc/llvm-project?rev=312666&view=rev
Log:
[CMake] Need to set WITH_LOCKDOWN on debugserver target
Turns out WITH_LOCKDOWN define changes the struct layout and constructor
implementation for RNBSocket wh
