[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

cbook added a comment. Thanks Jason. I don't have commit access. Would you or someone else be able to commit this? https://reviews.llvm.org/D36620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

jasonmolenda added a comment. This looks good, the documentation for isprint() say that the value of the argument must be representable as an unsigned char, or EOF. https://reviews.llvm.org/D36620 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. Sorry for the delay. https://reviews.llvm.org/D36046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

[Lldb-commits] [lldb] r311003 - convert hard tabs to spaces in PlatformOpenBSD.cpp

Author: emaste Date: Wed Aug 16 06:10:07 2017 New Revision: 311003 URL: http://llvm.org/viewvc/llvm-project?rev=311003&view=rev Log: convert hard tabs to spaces in PlatformOpenBSD.cpp Another case of this was responsible for the whitespace conflict in D34776. Modified: lldb/trunk/source/Plug

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

This revision was automatically updated to reflect the committed changes. Closed by commit rL311002: Make i386-*-freebsd expression work on JIT path (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D34776?vs=104984&id=111331#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [lldb] r311002 - Make i386-*-freebsd expression work on JIT path

Author: emaste Date: Wed Aug 16 05:55:02 2017 New Revision: 311002 URL: http://llvm.org/viewvc/llvm-project?rev=311002&view=rev Log: Make i386-*-freebsd expression work on JIT path * Enable i386 ABI creation for freebsd * Added an extra argument in ABISysV_i386::PrepareTrivialCall for mmap sysc

[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

tberghammer added a comment. Hi Greg, can you take a look sometime? Thanks, Tamas Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735 + if (target_arch.IsMIPS()) { return target_arch; + } nitesh.jain wrote: > tberghammer wrote: > > Hi

[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

tberghammer updated this revision to Diff 111326. tberghammer added a comment. Add comment about the MIPS special case. https://reviews.llvm.org/D36046 Files: source/Core/ArchSpec.cpp source/Plugins/Process/elf-core/ProcessElfCore.cpp Index: source/Plugins/Process/elf-core/ProcessElfCore.

[Lldb-commits] [lldb] r311000 - Remove the DWARFExpression -> Clang ExpressionParser dependency

Author: tberghammer Date: Wed Aug 16 04:45:10 2017 New Revision: 311000 URL: http://llvm.org/viewvc/llvm-project?rev=311000&view=rev Log: Remove the DWARFExpression -> Clang ExpressionParser dependency It was completly unused and broke the part of the encapsulation that common code shouldn't depe

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

labath accepted this revision. labath added a comment. lgtm https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits