[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

2017-08-07 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. With this patch i386 test results are comparable to amd64, and I'm happy with it from a FreeBSD perspective (modulo the PlatformOpenBSD patch conflict). https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

2017-08-07 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. The change in PlatformOpenBSD.cpp failed to apply for me (although it was trivial to manually apply it). https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] r310270 - Fixed build failure for revision r310261

2017-08-07 Thread Abhishek Aggarwal via lldb-commits
Author: abhishek Date: Mon Aug 7 10:15:26 2017 New Revision: 310270 URL: http://llvm.org/viewvc/llvm-project?rev=310270&view=rev Log: Fixed build failure for revision r310261 -- Was failing for Linux Modified: lldb/trunk/tools/intel-features/cli-wrapper.cpp Modified: lldb/trunk/tools/inte

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

2017-08-07 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. With this patch I observed three new failures on FreeBSD and three new unexpected passes on FreeBSD. An example of a new failure: == FAIL: test_inferior_crashing_expr_step_and_expr_dwarf (TestInferio

[Lldb-commits] [lldb] r310266 - Fixed build failure for revision r310261

2017-08-07 Thread Abhishek Aggarwal via lldb-commits
Author: abhishek Date: Mon Aug 7 08:53:30 2017 New Revision: 310266 URL: http://llvm.org/viewvc/llvm-project?rev=310266&view=rev Log: Fixed build failure for revision r310261 -- Build was failing for freebsd Modified: lldb/trunk/tools/intel-features/CMakeLists.txt Modified: lldb/trunk/too

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

2017-08-07 Thread Abhishek via Phabricator via lldb-commits
abhishek.aggarwal added a comment. In https://reviews.llvm.org/D33035#833876, @clayborg wrote: > I was out on vacation, sorry for the delay. Looks good. Thanks a lot Greg for your feedback. I am merging the patch now. https://reviews.llvm.org/D33035

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

2017-08-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I was out on vacation, sorry for the delay. Looks good. https://reviews.llvm.org/D33035 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-08-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I was out on a week long vacation, sorry for the delay. The main questions is: should symbols with NOTYPE actually be included in any address lookups. I would vote for no as how can 1 address resolve to more than one section. That doesn't make sense to me. One address

[Lldb-commits] [PATCH] D36068: Add support for base address entries in the .debug_ranges section

2017-08-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I was out on vacation, sorry for the delay. Looks good. https://reviews.llvm.org/D36068 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-08-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Remove the outdated comment and we are good to go. https://reviews.llvm.org/D33213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

2017-08-07 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. The patch LGTM, I will test it soon. Repository: rL LLVM https://reviews.llvm.org/D35223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

2017-08-07 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. Sorry I missed this when first uploaded, I will look at it shortly. For future uploads can you kindly include full context, as described in https://llvm.org/docs/Phabricator.html? Repository: rL LLVM https://reviews.llvm.org/D35223

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

2017-08-07 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. Sorry I missed this when first uploaded, I will look at it shortly. For future uploads can you kindly include full context, as described in https://llvm.org/docs/Phabricator.html? https://reviews.llvm.org/D34776 ___ lldb-co

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

2017-08-07 Thread Abhishek via Phabricator via lldb-commits
abhishek.aggarwal added a comment. Hi Greg .. Can you please review the changes? Please let me know if something needs to be changed. Thanks :) https://reviews.llvm.org/D33035 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l