chapuni accepted this revision.
chapuni added a comment.
Regardless of https://reviews.llvm.org/D36211, I hope this to be landed. It's
not late, if we would revert this again, after the discussion would be
concluded.
This is an issue around hidden header-header dependencies. If clang's -fmodule
beanz added a comment.
@chapuni, I disagree. LLDBExpression doesn't actually use RuntimeDyld directly,
rather ExecutionEngine's headers do. I don't want downstream users of
ExecutionEngine to know about the things it neccesitates pulling in.
Repository:
rL LLVM
https://reviews.llvm.org/D313
Author: jingham
Date: Thu Aug 3 12:38:38 2017
New Revision: 309977
URL: http://llvm.org/viewvc/llvm-project?rev=309977&view=rev
Log:
Cut and paste error from r23162.
Modified:
lldb/trunk/source/API/SBBreakpoint.cpp
lldb/trunk/source/API/SBBreakpointLocation.cpp
Modified: lldb/trunk/sour
Author: jingham
Date: Thu Aug 3 11:13:24 2017
New Revision: 309969
URL: http://llvm.org/viewvc/llvm-project?rev=309969&view=rev
Log:
Add an auto-continue flag to breakpoints & locations.
You can get a breakpoint to auto-continue by adding "continue"
as a command, but that has the disadvantage th
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This all looks fine to me. The one thing I'd like you to consider is that
someday (when lldb-server is supported on Darwin) we will want to run these
tests against both debugserver and lldb-serv
