Author: penryu
Date: Tue Jul 11 14:06:20 2017
New Revision: 307712
URL: http://llvm.org/viewvc/llvm-project?rev=307712&view=rev
Log:
switch on enum should be exhaustive and warning-free
Summary:
Testing the value of type_code against the closed enum TypeCodes
provides statically verifiable comple
spyffe updated this revision to Diff 106087.
spyffe added a comment.
Upon reflection, it's not worth coming up with a new pattern if
- that pattern does not considerably reduce the incidence of bugs in the source
file I'm applying it in (and indeed that seems quite unlikely), and
- that pattern
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Wait for an OK from Pavel as well.
https://reviews.llvm.org/D34945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
labath added a comment.
In https://reviews.llvm.org/D35083#804623, @jingham wrote:
> As a general practice requiring a wrapper like this for every use of a should
> be locked object would make the code noisy and hard to read. The only error
> you would be protecting against is that somebody us
Author: labath
Date: Tue Jul 11 03:38:40 2017
New Revision: 307644
URL: http://llvm.org/viewvc/llvm-project?rev=307644&view=rev
Log:
NativeProcessLinux: Fix handling of raise(SIGTRAP)
In NativeProcessLinux::MonitorSIGTRAP we were asserting that the si_code
value is one of the codes we know about.
labath updated this revision to Diff 105980.
labath added a comment.
Use csignal instead of signal.h
https://reviews.llvm.org/D35113
Files:
include/lldb/Host/MainLoop.h
include/lldb/Host/PosixApi.h
include/lldb/lldb-types.h
source/Host/common/File.cpp
source/Host/common/Socket.cpp
s
Author: labath
Date: Tue Jul 11 02:03:38 2017
New Revision: 307636
URL: http://llvm.org/viewvc/llvm-project?rev=307636&view=rev
Log:
NativeProcessLinux: Fix some compiler warnings
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
lldb/trunk/source/Plu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307632: [LLDB][ppc64le] Rename enums in AuxVector (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35065
Files:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
Author: labath
Date: Tue Jul 11 01:39:44 2017
New Revision: 307632
URL: http://llvm.org/viewvc/llvm-project?rev=307632&view=rev
Log:
[LLDB][ppc64le] Rename enums in AuxVector
Summary:
On linux on ppc64le some of the enums in AuxVector have the same name
as macros defined in the system.
Reviewers
labath added a reviewer: emaste.
labath added a comment.
Adding ed as freebsd owner.
The patch seems reasonable, we changed the behavior on linux in a similar way
couple of releases back -- SEGV is not a "crash", because the application can
generally handle it via a signal handler.
Repository
ravitheja added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:32-35
+ RegisterPacketHandler(
+ StringExtractorGDBRemote::eServerPacketType_QEnableErrorStrings,
+ [this](StringExtractorGDBRemote packet, Status &error, b
11 matches
Mail list logo
