[Lldb-commits] [lldb] r307512 - Don't access Python objects while not holding the GIL.

Author: zturner Date: Sun Jul 9 16:32:15 2017 New Revision: 307512 URL: http://llvm.org/viewvc/llvm-project?rev=307512&view=rev Log: Don't access Python objects while not holding the GIL. Patch by Tatyana Krasnukha Differential Revision: https://reviews.llvm.org/D34942 Modified: lldb/trunk

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

labath added a comment. In https://reviews.llvm.org/D35083#802400, @jingham wrote: > Ah, maybe you meant applying the thread safety annotation to Sean's solution > to enforce the contract. That's an interesting solution, but makes a > non-straightforward solution even more non-straightforward,

[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

Eugene.Zelenko added inline comments. Comment at: include/lldb/Host/MainLoop.h:16 #include "llvm/ADT/DenseMap.h" +#include I think will be good idea to include csignal instead. Same in other files. See http://clang.llvm.org/extra/clang-tidy/checks/modernize-

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

spyffe added a comment. Responded to Lang's comments inline. **Jim**: you say this patch "doesn't actually enforce that you take the lock to get the SourceMap." How do you get the source map otherwise? It's static inside the function so nothing can see it outside. Do you mean that it's still

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

jingham added a comment. Ah, maybe you meant applying the thread safety annotation to Sean's solution to enforce the contract. That's an interesting solution, but makes a non-straightforward solution even more non-straightforward, so I agree this isn't the best example... Repository: rL LL