[Lldb-commits] [PATCH] D33347: Fix incorrect Status -> Error rename in IOHandler

bgianfo updated this revision to Diff 99525. bgianfo added a comment. Fixing source path https://reviews.llvm.org/D33347 Files: lldb/trunk/source/Core/IOHandler.cpp Index: lldb/trunk/source/Core/IOHandler.cpp === --- lldb/trunk

[Lldb-commits] [PATCH] D33347: Fix incorrect Status -> Error rename in IOHandler

bgianfo created this revision. Change 302872 was a massive rename of the Error class to Status. The change included an incorrect rename of the "Status" window in the LLDB GUI from "Status to "Error". This patch undoes this incorrect rename and restores the status window's correct name. Reposit

[Lldb-commits] [PATCH] D32820: Parallelize demangling

emaste added a comment. > Without tcmalloc, on Ubuntu 14.04, 40 core VM: 13% > With tcmalloc, on Ubuntu 14.04, 40 core VM: 24% (built using cmake ... > -DCMAKE_EXE_LINKER_FLAGS=-ltcmalloc_minimal, which amazingly only works when > building with clang, not gcc...) Do you have a brief set of ste

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

jmajors updated this revision to Diff 99491. jmajors marked an inline comment as done. jmajors added a comment. More CL feedback. https://reviews.llvm.org/D32930 Files: unittests/CMakeLists.txt unittests/tools/CMakeLists.txt unittests/tools/lldb-server/CMakeLists.txt unittests/tools/lld

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

jmajors marked 7 inline comments as done. jmajors added inline comments. Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:10 + +#include +#include labath wrote: > Do you still need these includes? Yes. I'm using a stringstream to convert integer

[Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

Fix FDE indexing while scan debug_info section. There are some differences between eh_frame and debug_frame formats that are not considered by DWARFCallFrameInfo::GetFDEIndex. An FDE entry contains CIE_pointer in debug_frame in same place as cie_id in eh_frame. As described in dwarf standard

[Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

labath updated this revision to Diff 99435. labath added a comment. New version https://reviews.llvm.org/D33283 Files: packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindExpression.py source/Target/Process.cpp Index: source/Target/Process.cpp ===

[Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

labath added a comment. Ok, I've missed the distinction between plan completing (aka being "done") and completing **sucessfully**. Things make a bit more sense after that. With that in mind, let me try to explain how I understand it the code now, and then you can tell me if it's correct :) For

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

tberghammer added inline comments. Comment at: unittests/tools/lldb-server/tests/MessageObjects.h:83 +// Common functions for parsing packet data. +std::unordered_map SplitPairList(const std::string& s); +std::vector SplitList(const std::string& s, char delimeter); -

[Lldb-commits] [PATCH] D33241: Add Status -- llvm::Error glue

This revision was automatically updated to reflect the committed changes. Closed by commit rL303348: Add Status -- llvm::Error glue (authored by labath). Changed prior to commit: https://reviews.llvm.org/D33241?vs=99283&id=99429#toc Repository: rL LLVM https://reviews.llvm.org/D33241 Files:

[Lldb-commits] [lldb] r303348 - Add Status -- llvm::Error glue

Author: labath Date: Thu May 18 07:46:50 2017 New Revision: 303348 URL: http://llvm.org/viewvc/llvm-project?rev=303348&view=rev Log: Add Status -- llvm::Error glue Summary: This adds functions to convert between llvm::Error and Status classes. Posix errors in Status are represented as llvm::ECErr

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

labath added a comment. I think we're getting close, but I see a couple more issues here. Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:24 + if (elements["pid"].getAsInteger(16, process_info->pid)) +return make_parsing_error("ProcessInfo: pid"); + if (e

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

labath added a comment. In https://reviews.llvm.org/D32585#758391, @ravitheja wrote: > Well nothings preventing me from doing so, I have the changes for that were > suggested to me for this revision. I thought I would first upload them, so > that people can look at the parallel while I upload t

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

ravitheja added a comment. Well nothings preventing me from doing so, I have the changes for that were suggested to me for this revision. I thought I would first upload them, so that people can look at the parallel while I upload the linux server code and Unit tests. https://reviews.llvm.org/

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

labath added a comment. llvm policy is to commit tests alongside the code under test. I also think it's easier to review as you have the code and the test on the same screen. What's the reason that prevents you from doing that? https://reviews.llvm.org/D32585 ___

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

ravitheja added a comment. > TraceOptions opt; > opt.setType(...); > opt.setBufferSize(...); > opt.setMetaBufferSize(); // with an appropriate TraceOptions constructor, > this could be a one-liner > std::future result = std::async(std::launch::async, [&] { > return client.StartT