[Lldb-commits] [PATCH] D33167: Get rid of some uses of StringConvert and reduce some indentation

2017-05-13 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. It's not that perfectly clear to me that `SetStatus()` returns `Succeeded()`, however I don't have a proposal for a better name. `SetStatusReturnSucceeded()` or similar are long. https://reviews.llvm.org/D33167 ___ lld

[Lldb-commits] [PATCH] D33167: Get rid of some uses of StringConvert and reduce some indentation

2017-05-13 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. The goal here is to eventually delete the `StringConvert` class, as the llvm APIs for doing string to number conversion have a cleaner syntax. In order to reduce code churn, since I was in this code anyway, I changed the deeply nested indentation of the code block