jingham added a comment.
This was used at some point. I'd be happier deleting if if I understood the
reason why it is no longer needed.
Repository:
rL LLVM
https://reviews.llvm.org/D32503
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
scott.smith added inline comments.
Comment at: include/lldb/Symbol/ObjectFile.h:808-811
+ virtual ConstString
+ StripLinkerSymbolAnnotations(ConstString symbol_name) const {
+return symbol_name;
}
scott.smith wrote:
> clayborg wrote:
> > This actually do
scott.smith updated this revision to Diff 96629.
scott.smith marked 21 inline comments as done.
scott.smith added a comment.
address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D32316
Files:
include/lldb/Core/UniqueCStringMap.h
include/lldb/Symbol/ObjectFile.h
source/I
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, lets start with this and iterate.
https://reviews.llvm.org/D29581
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
scott.smith created this revision.
It is simply unused, and the header for it is private, so there should be no
external dependencies.
Repository:
rL LLVM
https://reviews.llvm.org/D32503
Files:
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/Plugins/Language/CPlusPlus/CPl
labath planned changes to this revision.
labath added a comment.
In https://reviews.llvm.org/D32434#737179, @zturner wrote:
> If you look at the source code of yaml2obj, all this boils down to a single
> call to `ELFState::writeELF`. If you just link against that, we could
> avoid even shellin
zturner added a comment.
If you look at the source code of yaml2obj, all this boils down to a single
call to `ELFState::writeELF`. If you just link against that, we could avoid
even shelling out to an external tool, and the YAML could be a string literal
defined inside the unit test cpp file.
eugene accepted this revision.
eugene added a comment.
This revision is now accepted and ready to land.
Neatly done!
https://reviews.llvm.org/D32434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
xiaobai added a comment.
@krytarowski: Thanks for checking! I can set up a NetBSD environment sometime
in the next few days to see what's going on. While it might not be an issue on
this platform, I think it's an issue that MoveCursor() accesses
`m_input_lines[m_input_lines.size() - 1]` without
labath added inline comments.
Comment at: include/lldb/Interpreter/Property.h:43
+ ConstString GetName() const { return m_name; }
+ ConstString GetDescription() const { return m_description; }
scott.smith wrote:
> clayborg wrote:
> > This shouldn't be const-i
labath added a comment.
Thanks for the patch Alex.
After looking around the code a bit (I'm quite new to that area as well), I
think a better approach would be to fix MoveCursor to handle this situation
gracefully. If you look at what this code does in the "normal" case, you'll see
that it del
nitesh.jain added a comment.
In https://reviews.llvm.org/D32125#736543, @sdardis wrote:
> Hi Nitesh,
>
> this commit broke clang-cmake-mips. Can you investigate?
>
> http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/3189
>
> Thanks,
> Simon
Hi Simon,
The assertion has been fixed.
Than
labath added a comment.
In https://reviews.llvm.org/D32306#736115, @scott.smith wrote:
> 10.2% reduction in # of instructions executed, 9.1% reduction in # of cycles,
> as measured by 'perf stat' in single threaded mode (I disabled TaskPool in
> order to get more repeatable results).
That is
labath added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
zturner wrote:
> Why do we e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301306: Remove the home-grown android toolchain file and all
references to it (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32441?vs=96514&id=96542#toc
Repository:
rL LLVM
Author: labath
Date: Tue Apr 25 07:58:49 2017
New Revision: 301306
URL: http://llvm.org/viewvc/llvm-project?rev=301306&view=rev
Log:
Remove the home-grown android toolchain file and all references to it
Summary:
The toolchain file has been deprecated in favor of the "official"
toolchain file pres
labath added a reviewer: beanz.
labath added a subscriber: beanz.
labath added a comment.
Ok, wiring yaml2obj up was easier than I expected (for cmake, we'll still need
to figure out what to do with the xcode build). Let me know what you make of
this.
Also adding @beanz, in case he has any thou
labath updated this revision to Diff 96541.
labath added a comment.
Use yaml2obj to avoid checking in a binary.
https://reviews.llvm.org/D32434
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
unittests/ObjectFile/ELF/CMakeLists.txt
unittests/ObjectFile/ELF/Inputs/sections-resolve-c
labath updated this revision to Diff 96540.
labath added a comment.
Use yaml2obj to avoid checking in a binary.
https://reviews.llvm.org/D32434
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
unittests/ObjectFile/ELF/CMakeLists.txt
unittests/ObjectFile/ELF/Inputs/sections-resolve-c
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
https://reviews.llvm.org/D32441
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
I cannot reproduce it locally.
$ lldb
(lldb) print
Enter expressions, then terminate with an empty line to evaluate:
(lldb)
Enter expressions, then terminate with an empty line to evaluate:
(lldb)
Steps:
1. start lldb
2. "print"
3.
4.
`NetBSD 7.99.7
sdardis added a comment.
Hi Nitesh,
this commit broke clang-cmake-mips. Can you investigate?
http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/3189
Thanks,
Simon
Repository:
rL LLVM
https://reviews.llvm.org/D32125
___
lldb-commits mail
On 24 April 2017 at 23:16, Zachary Turner wrote:
> I suppose that's a reasonable concern. I also didn't notice that this was
> a unittest, I assumed it was a lit test.
>
> If that's the case, is there any way to use llvm/Object to construct a
> minimal ELF file in memory with a hardcoded symbol
labath updated this revision to Diff 96514.
labath added a comment.
Address Tamas's comments.
https://reviews.llvm.org/D32441
Files:
cmake/platforms/Android.cmake
www/build.html
Index: www/build.html
===
--- www/build.html
+++
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: www/build.html:488-493
+
-DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake
\
+ -DANDROID_ABI=arm64-v8a \
+ -DANDROID_PLATFORM=and
25 matches
Mail list logo
