[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

krytarowski created this revision. krytarowski added a project: LLDB. Correct detection of the NetBSD specific core(5) files. The original code was apparently copied from FreeBSD and it was buggy, because these BSDs are different and do not share the same ELF layout for core(5) files. Split Proce

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

davide created this revision. https://reviews.llvm.org/D32148 Files: include/lldb/Utility/StringLexer.h source/Utility/StringLexer.cpp Index: source/Utility/StringLexer.cpp === --- source/Utility/StringLexer.cpp +++ source/Util

[Lldb-commits] [lldb] r300519 - TestStaticVariables still fails on Linux.

Author: jingham Date: Mon Apr 17 19:44:14 2017 New Revision: 300519 URL: http://llvm.org/viewvc/llvm-project?rev=300519&view=rev Log: TestStaticVariables still fails on Linux. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py Modified: lldb/tr

[Lldb-commits] [lldb] r300517 - This test is succeeding on macOS with clang.

Author: jingham Date: Mon Apr 17 19:20:59 2017 New Revision: 300517 URL: http://llvm.org/viewvc/llvm-project?rev=300517&view=rev Log: This test is succeeding on macOS with clang. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py Modified: lldb

[Lldb-commits] [PATCH] D32137: [Utility] Placate another GCC warning

davide created this revision. For reference/discussion. GCC complains about signed-vs-unsigned comparison. I'm actually surprised that `m_registers_count` is a `signed` integer, as I can hardly imagine a negative register count. I'm under the impression that we could change `m_register_count` f

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

kubamracek updated this revision to Diff 95469. kubamracek added a comment. Addressing review comments. https://reviews.llvm.org/D30007 Files: include/lldb/API/SBThread.h include/lldb/API/SBThreadPlan.h include/lldb/Target/InstrumentationRuntimeStopInfo.h include/lldb/Target/StopInfo.h

[Lldb-commits] [lldb] r300476 - [ClangASTContext] Placate `casts away qualifiers` warnings from GCC.

Author: davide Date: Mon Apr 17 13:24:18 2017 New Revision: 300476 URL: http://llvm.org/viewvc/llvm-project?rev=300476&view=rev Log: [ClangASTContext] Placate `casts away qualifiers` warnings from GCC. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

clayborg accepted this revision. clayborg added a comment. I'm good if Pavel is good. https://reviews.llvm.org/D31823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

beanz added a comment. Can you please move this check into `HandleLLVMOptions.cmake`? By putting it into a module that is vended as part of LLVM's packaging then LLVM subprojects can have consistent settings when building out-of-tree. This would enable @zturner's request to remove the duplicate

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz updated this revision to Diff 95453. beanz added a comment. Removing code I accidentally left in that was from debugging, and moving some duplicated code that @labath spotted out of the ifdef. https://reviews.llvm.org/D31823 Files: cmake/modules/LLDBConfig.cmake include/lldb/Host/Con

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz updated this revision to Diff 95448. beanz added a comment. Updating patches to reflect feedback from zturner. https://reviews.llvm.org/D31823 Files: cmake/modules/LLDBConfig.cmake include/lldb/Host/Config.h include/lldb/Host/Config.h.cmake include/lldb/Host/MainLoop.h include/l

[Lldb-commits] [lldb] r300455 - Don't ever reduce the timeout of a packet, only increase it.

Author: gclayton Date: Mon Apr 17 11:20:22 2017 New Revision: 300455 URL: http://llvm.org/viewvc/llvm-project?rev=300455&view=rev Log: Don't ever reduce the timeout of a packet, only increase it. Differential Revision: https://reviews.llvm.org/D32087 Modified: lldb/trunk/source/Plugins/Proc

[Lldb-commits] [PATCH] D32087: Modify GDBRemoteCommunication::ScopedTimeout to not ever decrease a timeout

This revision was automatically updated to reflect the committed changes. Closed by commit rL300455: Don't ever reduce the timeout of a packet, only increase it. (authored by gclayton). Changed prior to commit: https://reviews.llvm.org/D32087?vs=95314&id=95442#toc Repository: rL LLVM https:

Re: [Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

We already have this exact code in lldb/cmake/LLDBConfig.txt. This fix looks fine, but I see no reason to have it twice, so can you delete the LLDB version? On Mon, Apr 17, 2017 at 7:01 AM Kamil Rytarowski via Phabricator < revi...@reviews.llvm.org> wrote: > krytarowski added a comment. > > Is t

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

krytarowski added a comment. Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago. It's perhaps no-op, but it might be noted in the commit message what platforms are supposed to be improved. Repository: rL LLVM https://reviews.llvm.org/D32125 __

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

nitesh.jain created this revision. Herald added subscribers: arichardson, mgorny. Fix is to define _LARGEFILE_SOURCE and _FILE_OFFSET_BITS=64. This fix will cause llvm::sys::fs::file_size() to return correct object size. Repository: rL LLVM https://reviews.llvm.org/D32125 Files: CMakeList