I'm ooo for ~2 weeks so I can't really do code reviews unfortunately
On Sat, Mar 25, 2017 at 6:23 AM Chris Bieneman via Phabricator <
revi...@reviews.llvm.org> wrote:
> beanz added a comment.
>
> Xcode is pretty magic to me. I don't know how to do much of anything in it
> other than build. I think
beanz added a comment.
Xcode is pretty magic to me. I don't know how to do much of anything in it
other than build. I think the right solution would be to take most of the
source files out of the debugserver target and generate a static archive from
them, then have debugserver and the debugserv
jingham added a comment.
Todd added a gtest target to the lldb.xcodeproj. Presumably you could use that
as a template and do the same thing in the tools/debugserver.xcproj. Then make
an aggregate target in the lldb workspace that runs these two targets.
https://reviews.llvm.org/D31357
___
beanz created this revision.
Herald added a subscriber: mgorny.
This patch refactors the CMake build system's support for building debugserver
to allow us to build the majority of debugserver's sources into the
debugserverCommon library which can then be reused by unit tests.
The first unit tes
fjricci created this revision.
Prior to r259433, getCompiler could return None without causing a
test suite crash. However, passing a NoneType to realpath will
cause a crash. Prevent this crash by allowing getCompiler to return None.
https://reviews.llvm.org/D31335
Files:
packages/Python/lldb
krytarowski added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp:48
+ GPR gpr;
+ FPR_i386 i387;
+};
kettenis wrote:
> krytarowski wrote:
> > no DBG regs here?
> OpenBSD doesn't actually implement access to the debug
kettenis updated this revision to Diff 92938.
kettenis added a comment.
Updated diff to account for the FileSpec.h move.
https://reviews.llvm.org/D31131
Files:
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
include/lldb/Host/HostInfo.h
include/lldb/Ho
kettenis added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp:48
+ GPR gpr;
+ FPR_i386 i387;
+};
krytarowski wrote:
> no DBG regs here?
OpenBSD doesn't actually implement access to the debug registers.
https://revi
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
In general it looks good.
https://reviews.llvm.org/D31131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
krytarowski added inline comments.
Comment at: source/CMakeLists.txt:25
+include_directories(
+ Plugins/Process/POSIX
+ )
@labath are the includes for Plugins/Process/FreeBSD and
Plugins/Process/FreeBSD necessary? I don't need to add Plugins/Process/NetBSD
in
Author: jmolenda
Date: Fri Mar 24 03:01:16 2017
New Revision: 298694
URL: http://llvm.org/viewvc/llvm-project?rev=298694&view=rev
Log:
The expression text in AppleObjCRuntimeV1::CreateObjectChecker
was formatted into a string inside an assert() expression.
Which is elided when lldb is built with a
11 matches
Mail list logo
