zturner updated this revision to Diff 92236.
zturner added a comment.
Forgot to remove `Stat` declaration from header file.
https://reviews.llvm.org/D3
Files:
lldb/include/lldb/Host/FileSystem.h
lldb/source/Host/common/File.cpp
lldb/source/Host/common/Host.cpp
lldb/source/Host/macos
zturner created this revision.
Herald added a subscriber: emaste.
https://reviews.llvm.org/D3
Files:
lldb/include/lldb/Host/FileSystem.h
lldb/source/Host/common/File.cpp
lldb/source/Host/common/Host.cpp
lldb/source/Host/macosx/Host.mm
lldb/source/Host/posix/DomainSocket.cpp
lldb/s
sas accepted this revision.
sas added a comment.
This revision is now accepted and ready to land.
The second behavioral change seems good but the first thing you described is a
bit odd. Creating folders with 770 does not seem like a common behavior, and
700 or 755 is usually more standard.
Eith
sas accepted this revision.
sas added a comment.
This revision is now accepted and ready to land.
So nice.
https://reviews.llvm.org/D31108
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
zturner created this revision.
https://reviews.llvm.org/D31108
Files:
lldb/source/Host/common/FileSystem.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
lldb/source/Target/Platform.cpp
Index: lldb/so
Author: penryu
Date: Fri Mar 17 16:00:35 2017
New Revision: 298123
URL: http://llvm.org/viewvc/llvm-project?rev=298123&view=rev
Log:
allow for specification of compiler/lldb executables basename
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Pytho
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Cool. Nevermind me then.
https://reviews.llvm.org/D31089
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
labath added a comment.
In https://reviews.llvm.org/D31086#704122, @zturner wrote:
> That one is calling a file static function `MakeDirectory`, not
> `FileSystem::MakeDirectory`, and the implementation of that function already
> calls `llvm::sys::fs::create_directories()` to create the whole t
zturner added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:813
+ auto perms =
+ static_cast(packet.GetHexMaxU32(false,
UINT32_MAX));
if (packet.GetChar() == ',') {
zturner wrote:
> labath wr
zturner added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:813
+ auto perms =
+ static_cast(packet.GetHexMaxU32(false,
UINT32_MAX));
if (packet.GetChar() == ',') {
labath wrote:
> This doesn
labath added a reviewer: jingham.
labath added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:813
+ auto perms =
+ static_cast(packet.GetHexMaxU32(false,
UINT32_MAX));
if (packet.GetChar() == ',') {
--
zturner added a comment.
That one is calling a file static function `MakeDirectory`, not
`FileSystem::MakeDirectory`, and the implementation of that function already
calls `llvm::sys::fs::create_directories()` to create the whole tree, so it
should be fine.
https://reviews.llvm.org/D31086
labath added a comment.
I think you missed one occurence in ModuleCache.cpp. This one creates a full
directory structure, so you will probably need recursion there (unlike in the
rest of these cases, which seem fine). Also unlike the rest of these cases,
that one is actually covered by a unit t
labath added a comment.
In https://reviews.llvm.org/D31079#703911, @zturner wrote:
> In the places where you want to read from an `ifstream` and write to a
> socket, you might consider using `llvm::sys::fs::copy_file`, declared in
> `Support/FileSystem.h`. Currently it takes two paths, but all
Author: penryu
Date: Fri Mar 17 13:10:58 2017
New Revision: 298111
URL: http://llvm.org/viewvc/llvm-project?rev=298111&view=rev
Log:
executables should be validated before spawning subprocesses
dotest.py script doesn't validate executables passed on the command line
before spawning dozens of subp
zturner created this revision.
Use the LLVM functions instead
https://reviews.llvm.org/D31089
Files:
lldb/include/lldb/Host/FileSystem.h
lldb/source/Host/posix/FileSystem.cpp
lldb/source/Host/windows/FileSystem.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommo
zturner created this revision.
Use the LLVM functions instead.
https://reviews.llvm.org/D31088
Files:
lldb/include/lldb/Host/FileSystem.h
lldb/source/Host/posix/FileSystem.cpp
lldb/source/Host/windows/FileSystem.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerComm
zturner abandoned this revision.
zturner added a comment.
Messed up reviewer / subscriber.
https://reviews.llvm.org/D31088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner created this revision.
Use the LLVM function instead.
There are two subtle behavioral changes here which I want to make clear so
someone can determine whether this matters on their platform.
1. Previously all LLDB callers were passing `eFilePermissionsDirectoryDefault`
which is equal t
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
In the places where you want to read from an `ifstream` and write to a socket,
you might consider using `llvm::sys::fs::copy_file`, declared in
`Support/FileSystem.h`. Currently it takes tw
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298100: CMake requires normalized paths when appending.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D30927?vs=91676&id=92157#toc
Repository:
rL LLVM
https://reviews.llvm
Author: zturner
Date: Fri Mar 17 11:33:37 2017
New Revision: 298100
URL: http://llvm.org/viewvc/llvm-project?rev=298100&view=rev
Log:
CMake requires normalized paths when appending.
Patch by Hugh Bellamy
Differential Revision: https://reviews.llvm.org/D30927
Modified:
lldb/trunk/cmake/module
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298099: Fix some signed/unsigned comparison warnings.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D30926?vs=91670&id=92156#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: zturner
Date: Fri Mar 17 11:32:43 2017
New Revision: 298099
URL: http://llvm.org/viewvc/llvm-project?rev=298099&view=rev
Log:
Fix some signed/unsigned comparison warnings.
Patch by Hugh Bellamy
Differential Revision: https://reviews.llvm.org/D30926
Modified:
lldb/trunk/source/Core/Fo
labath created this revision.
ofstream does not handle paths with non-ascii characters correctly on
windows, so I am switching these to llvm streams to fix that.
Ideally I'd like to replace the two occurences of ifstream as well, but
it's not clear to me what is the right replacement, as llvm int
ayuckhulk created this revision.
ayuckhulk added a project: LLDB.
https://reviews.llvm.org/D31073
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/lexical-scope/Makefile
packages/Python/lldbsuite/test/tools/lldb-mi/lexical-scope/TestLexicalScope.py
packages/Python/lldbsuite/test/tools/ll
Author: labath
Date: Fri Mar 17 06:33:57 2017
New Revision: 298069
URL: http://llvm.org/viewvc/llvm-project?rev=298069&view=rev
Log:
Fix FreeBSD build broken by r298066
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
Modified: lldb/trunk/source/Plugins/Process/FreeBSD/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298066: Move GetAuxvData from Host to relevant process
plugins (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D31031?vs=92000&id=92125#toc
Repository:
rL LLVM
https://review
Author: labath
Date: Fri Mar 17 06:08:40 2017
New Revision: 298066
URL: http://llvm.org/viewvc/llvm-project?rev=298066&view=rev
Log:
Move GetAuxvData from Host to relevant process plugins
Summary:
GetAuxvData was causing dependencies from host to target and linux
process modules. It also does not
Author: labath
Date: Fri Mar 17 05:30:42 2017
New Revision: 298063
URL: http://llvm.org/viewvc/llvm-project?rev=298063&view=rev
Log:
One more attempt to fix FreeBSD
It seems sysctl.h is not self-contained, as I get missing symbols in the
header itself now. I am going to include all files that the
Author: labath
Date: Fri Mar 17 05:09:56 2017
New Revision: 298061
URL: http://llvm.org/viewvc/llvm-project?rev=298061&view=rev
Log:
Speculative build fix for FreeBSD
broken by r298058.
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
Modified: lldb/trunk/source/Plugins
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298058: Remove HostThreadLinux/Free/NetBSD (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D30981?vs=91869&id=92115#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30981
F
Author: labath
Date: Fri Mar 17 04:51:23 2017
New Revision: 298058
URL: http://llvm.org/viewvc/llvm-project?rev=298058&view=rev
Log:
Remove HostThreadLinux/Free/NetBSD
Summary:
These classes existed only because of the GetName() static function,
which can be moved to a more natural place anyway.
33 matches
Mail list logo
