Author: jmolenda
Date: Thu Feb 23 21:35:46 2017
New Revision: 296084
URL: http://llvm.org/viewvc/llvm-project?rev=296084&view=rev
Log:
Fix a race condition in FuncUnwinders where the mutex was being
acquired only after checking if the ivar shared pointer was already
filled in. But when I assign a
Author: kamil
Date: Thu Feb 23 19:53:45 2017
New Revision: 296071
URL: http://llvm.org/viewvc/llvm-project?rev=296071&view=rev
Log:
Introduce support for Debug Registers in RegisterContextNetBSD_x86_64
Summary:
NetBSD 7.99.62 introduced Debug Registers interface similar to the FreeBSD one.
This i
Author: kamil
Date: Thu Feb 23 19:51:38 2017
New Revision: 296070
URL: http://llvm.org/viewvc/llvm-project?rev=296070&view=rev
Log:
Switch NetBSD from paccept(2) to accept4(2)
Summary:
NetBSD 8.0 will ship with accept4(2) in libc wrapping paccept(2).
This change reduces needless difference with
krytarowski updated this revision to Diff 89589.
krytarowski added a comment.
- remove unused function `GetSharedRegisterInfoVector`
- fix `DR_OFFSET`
Repository:
rL LLVM
https://reviews.llvm.org/D30287
Files:
source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp
Index: source/P
eugene updated this revision to Diff 89575.
eugene edited the summary of this revision.
eugene added a comment.
Herald added subscribers: srhines, danalbert.
Addressing code review comments.
https://reviews.llvm.org/D30286
Files:
include/lldb/Host/common/NativeProcessProtocol.h
packages/Pyt
clayborg accepted this revision.
clayborg added a comment.
That is fine, just wanted to check.
Repository:
rL LLVM
https://reviews.llvm.org/D30287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
krytarowski added inline comments.
Comment at:
source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:51-56
+ uint64_t dr[16]; /* debug registers */
+ /* Index 0-3: debug address registers */
+ /* Index 4-5: reserved */
+
zturner added a comment.
The main concern I have with adding null checks is that I think it actually
*increases* your risk of crashing. All of a sudden you've introduced an
entirely new branch / code-path that is completely untested. Worse, it only
occurs in a situation where you've explicitl
clayborg added a comment.
I would still vote to check Buffer for NULL. GetByteSize() and GetBytes() are
usually accessed one time so there won't be a performance issue. If anyone
wanted to actually use a DataBufferLLVM as a member variable, they would need
to use a std::unique_ptr to one with t
zturner updated this revision to Diff 89547.
zturner added a comment.
Updated with suggestions from clayborg@. It seems wasteful to me check the
pointer on every single call to read when we can check it once on creation. So
I've added an assert in the constructor and documented with doxygen co
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
In general code around crashes, we don't want to introduce any crashes in LLDB
(no llvm_unreachable, asserts ok if code still functions without them). See
inlined comments.
==
jingham added a comment.
Sorry, I sent a reply but did it by replying to the e-mail version of the
patch, and the mail server choked on it for reasons that aren't clear to me...
Greg was most likely thinking that BreakpointLocation had a "Clear" method like
the Target and Process, which we can
zturner updated this revision to Diff 89542.
https://reviews.llvm.org/D30054
Files:
lldb/include/lldb/Core/DataBufferHeap.h
lldb/include/lldb/Core/DataBufferLLVM.h
lldb/include/lldb/Core/DataBufferMemoryMap.h
lldb/include/lldb/Host/FileSpec.h
lldb/source/Core/CMakeLists.txt
lldb/sourc
clayborg added inline comments.
Comment at:
source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:51-56
+ uint64_t dr[16]; /* debug registers */
+ /* Index 0-3: debug address registers */
+ /* Index 4-5: reserved */
+
jingham added a comment.
It definitely does not belong in the summary provider. So far as I can tell
the main benefit of the IsPointerLike part of this thing is that you can do:
(lldb) frame var
isPointerLikeThing->field_of_pointee->field_of_field_of_pointee
which the summary wouldn't help
zturner added inline comments.
Comment at: lldb/include/lldb/Core/DataBufferLLVM.h:43
+ uint8_t *GetBytes() override {
+llvm_unreachable("Not implemented!");
+return nullptr;
labath wrote:
> This makes pretty much everything fail. Most of the code base h
labath planned changes to this revision.
labath added a comment.
No worries. I'll come back soon with the weak_ptr thingy.
https://reviews.llvm.org/D30249
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
labath added a comment.
In https://reviews.llvm.org/D30272#684610, @tberghammer wrote:
> My original plan was to add it to the synthetic child provider but after some
> thoughts and experimenting I concluded it doesn't really belongs to there
> because it should be responsible for generating ne
Author: labath
Date: Thu Feb 23 07:10:38 2017
New Revision: 295968
URL: http://llvm.org/viewvc/llvm-project?rev=295968&view=rev
Log:
Switch "windows" log channel to the new registration mechanism
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindowsLog.cpp
lldb/trunk/s
labath added a comment.
I've tried this out on linux. I got it working only after making the following
modifications:
Comment at: lldb/include/lldb/Core/DataBufferLLVM.h:15
+#include "lldb/Host/FileSpec.h"
+#include "llvm/Support/MemoryBuffer.h"
+
add `#includ
tberghammer added a comment.
My original plan was to add it to the synthetic child provider but after some
thoughts and experimenting I concluded it doesn't really belongs to there
because it should be responsible for generating new children while here we are
modifying the way the parent object
labath added a comment.
Good stuff. We just need a couple of changes to make this conform better with
llvm guidelines.
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:72
+ //--
+ virtual Error Ignor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295954: Switch "posix" to the new log channel registration
mechanism (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30250?vs=89348&id=89486#toc
Repository:
rL LLVM
https://
Author: labath
Date: Thu Feb 23 04:33:16 2017
New Revision: 295954
URL: http://llvm.org/viewvc/llvm-project?rev=295954&view=rev
Log:
Switch "posix" to the new log channel registration mechanism
Summary:
This also removes magic rename code, which caused the channel to be
called "linux" when built
labath added a comment.
Jim's comment definitely makes sense. If we happen to not use pretty-printer
for the unique_ptr, it will not behave as a pointer-like object, and it should
be formatted as a normal struct (I have no idea how much of a challenge it
would be to implement it that way).
=
Author: labath
Date: Thu Feb 23 04:00:33 2017
New Revision: 295952
URL: http://llvm.org/viewvc/llvm-project?rev=295952&view=rev
Log:
Finish the reformatting of the lldb-server test executables
This also reformats the executables in subfolders of lldb-server tests.
Modified:
lldb/trunk/packa
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Good stuff, just remove the unused function.
Comment at: source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:87
+
+static std::vector &GetSharedRegisterInfoVector
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295950: Reformat inferior's main.cpp in lldb-server test
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30234?vs=89404&id=89480#toc
Repository:
rL LLVM
https://reviews.llvm
Author: labath
Date: Thu Feb 23 03:46:33 2017
New Revision: 295950
URL: http://llvm.org/viewvc/llvm-project?rev=295950&view=rev
Log:
Reformat inferior's main.cpp in lldb-server test
Summary: main.cpp is complete mess of tabs and spaces. This change brings it to
compliance with LLVM coding style.
labath accepted this revision.
labath added a comment.
In https://reviews.llvm.org/D30234#683880, @eugene wrote:
> I have added local .clang-format file. But it didn't change the way main.cpp
> was formated.
That's fine, I did not expect that to make a difference now. What it will do
though,
krytarowski created this revision.
krytarowski added a project: LLDB.
NetBSD 8.0 will ship with accept4(2) in libc wrapping paccept(2).
This change reduces needless difference with other platforms.
Older versions of NetBSD will not be supported.
No functional change.
Sponsored by
Repository
Author: hhellyer
Date: Thu Feb 23 02:49:49 2017
New Revision: 295947
URL: http://llvm.org/viewvc/llvm-project?rev=295947&view=rev
Log:
Ensure lldb-server waits for child debug servers to start up when passing them
a port number to listen on.
Summary:
When lldb-server is started with the -P or -
krytarowski created this revision.
krytarowski added a project: LLDB.
NetBSD 7.99.62 introduced Debug Registers interface similar to the FreeBSD one.
This interface will land NetBSD-8.0.
Introduce support for this interface in Register Context NetBSD x86_64
unconditionally as older versions of N
33 matches
Mail list logo
