Author: jmolenda
Date: Mon Dec 12 23:59:24 2016
New Revision: 289520
URL: http://llvm.org/viewvc/llvm-project?rev=289520&view=rev
Log:
Small tweaks to the markup in StructuredDataPlugins.
Modified:
lldb/trunk/docs/structured_data/StructuredDataPlugins.md
Modified: lldb/trunk/docs/structured_
Author: jmolenda
Date: Mon Dec 12 23:54:17 2016
New Revision: 289518
URL: http://llvm.org/viewvc/llvm-project?rev=289518&view=rev
Log:
Touch-up the markup of the DarwinLog.md documentation.
Modified:
lldb/trunk/docs/structured_data/DarwinLog.md
Modified: lldb/trunk/docs/structured_data/Darwi
Author: tfiala
Date: Mon Dec 12 16:42:00 2016
New Revision: 289479
URL: http://llvm.org/viewvc/llvm-project?rev=289479&view=rev
Log:
Removing myself from code ownership file
I'm transitioning away from my current employer, and I do not foresee myself
spending much time on LLDB in the near future.
clayborg added a comment.
Sounds good. Take it as my vote this is ok to start with if we get consensus
https://reviews.llvm.org/D27632
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
zturner added a comment.
Thanks. Not going to commit this just yet, as I know there was at least one
concern over on llvm-dev about adopting this. So I'll give it another few days
to see if the complaints remain.
https://reviews.llvm.org/D27632
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
So we need to formalize this in the formatv documentation before we begin wide
adoption otherwise people can do what ever they want. It would be good to write
this up so we get consistent
zturner added inline comments.
Comment at: source/Host/common/FileSpec.cpp:1394
+ assert(
+ (Style.empty() || Style.equals_lower("F") || Style.equals_lower("D")) &&
+ "Invalid FileSpec style!");
clayborg wrote:
> zturner wrote:
> > clayborg wrote:
> >
clayborg added inline comments.
Comment at: source/Host/common/FileSpec.cpp:1394
+ assert(
+ (Style.empty() || Style.equals_lower("F") || Style.equals_lower("D")) &&
+ "Invalid FileSpec style!");
zturner wrote:
> clayborg wrote:
> > If we are going to
zturner added inline comments.
Comment at: source/Host/common/FileSpec.cpp:1394
+ assert(
+ (Style.empty() || Style.equals_lower("F") || Style.equals_lower("D")) &&
+ "Invalid FileSpec style!");
clayborg wrote:
> If we are going to not care about case
clayborg added a comment.
Looking good. A few little changes and possibly supporting long option names
that can be minimally specified. See inlined comments.
Comment at: source/Host/common/FileSpec.cpp:1394
+ assert(
+ (Style.empty() || Style.equals_lower("F") || Style.e
Hi,
I think I have already handled those failures by adding the
skipIfHostIncompatibleWithRemote decorator. I have removed linux from
this list, as it passes fine there. I have also removed the i386 case,
as I think it was put there to achieve the same thing as
skipIfHostIncompatibleWithRemote. I
Author: labath
Date: Mon Dec 12 05:37:42 2016
New Revision: 289427
URL: http://llvm.org/viewvc/llvm-project?rev=289427&view=rev
Log:
Remove some annotations from TestMultipleTargets
The test passes on linux. The i386 case is already handled by
skipIfHostIncompatibleWithRemote.
Modified:
lld
On 10 December 2016 at 18:09, Zachary Turner wrote:
> To elaborate about member function vs format provider, decoupling types from
> the way they're formatted seems like a good design practice in general. For
> example, you might want to add support for formatting a class which you
> don't have t
13 matches
Mail list logo
