[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

alexshap added inline comments. Comment at: include/lldb/Core/FastDemangle.h:22 +char * +FastDemangle(const char *mangled_name, size_t mangled_name_length, + std::function primitive_type_hook = nullptr); some thoughts: (also i assume i might be mista

[Lldb-commits] [PATCH] D27222: Remove an x86-ism from RegisterInfoInterface

dvlahovski accepted this revision. dvlahovski added a comment. LGTM https://reviews.llvm.org/D27222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:449 +/// Given a mangled function `mangled`, replace all the primitive function type +//

[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

ldrumm added a comment. New candidate is here Repository: rL LLVM https://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

ldrumm created this revision. ldrumm added reviewers: spyffe, clayborg. ldrumm added a subscriber: LLDB. Herald added a subscriber: aemerson. This is a redux of Ewan's patch , refactored to properly substitute primitive types using a hook in the itanium demangle

[Lldb-commits] [PATCH] D27222: Remove an x86-ism from RegisterInfoInterface

labath created this revision. labath added reviewers: clayborg, dvlahovski. labath added a subscriber: lldb-commits. While adding FPR support to x86 elf core files (https://reviews.llvm.org/D26300), we ended up adding a very x86-specific function to the general RegisterInfoInterface class, which

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. In https://reviews.llvm.org/D27017#604265, @clayborg wrote: > Looks fine. One question though: do we always have a shared library that > contains the ASAN runtime? If so, then we can actually put the array of short > to long description into the ASAN dylib and then w

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added reviewers: filcab, zaks.anna, dcoughlin. kubabrecka removed rL LLVM as the repository for this revision. kubabrecka updated this revision to Diff 79611. kubabrecka added a comment. Updating the patch. https://reviews.llvm.org/D27017 Files: source/Plugins/InstrumentationRunti

Re: [Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

> On Nov 29, 2016, at 7:53 AM, Pavel Labath wrote: > > On 28 November 2016 at 18:06, Jim Ingham wrote: >> backtick parsing is currently incorrect, because it parses the backtick >> before doing arg parsing, which means it does the substitutions for “raw” >> commands: >> >> (lldb) expr char *$f

[Lldb-commits] [lldb] r288181 - Add back some of the previous lldb-server dependencies

Author: labath Date: Tue Nov 29 12:38:09 2016 New Revision: 288181 URL: http://llvm.org/viewvc/llvm-project?rev=288181&view=rev Log: Add back some of the previous lldb-server dependencies It seems a debug build of lldb-server will not complete without these, as the linker is not able to strip out

[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

EwanCrawford abandoned this revision. EwanCrawford added a subscriber: ldrumm. EwanCrawford added a comment. Abandoning this patch since it's out of date, and @ldrumm has an alternative fix he's about to post Repository: rL LLVM https://reviews.llvm.org/D17957

[Lldb-commits] [PATCH] D13617: Fix ref-counting of Python objects

granata.enrico resigned from this revision. granata.enrico removed a reviewer: granata.enrico. granata.enrico added a comment. I am not an Apple employee working on LLDB anymore https://reviews.llvm.org/D13617 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

granata.enrico resigned from this revision. granata.enrico removed a reviewer: granata.enrico. granata.enrico added a comment. I am not an Apple employee working on LLDB anymore https://reviews.llvm.org/D19086 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D19092: Fix Android build after r266267

granata.enrico resigned from this revision. granata.enrico removed a reviewer: granata.enrico. granata.enrico added a comment. I am not an Apple employee working on LLDB anymore https://reviews.llvm.org/D19092 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

granata.enrico resigned from this revision. granata.enrico removed a reviewer: granata.enrico. granata.enrico added a comment. I am not an Apple employee working on LLDB anymore https://reviews.llvm.org/D26757 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] r288169 - Remove some OS-specific plugins from lldb-server dependencies

Author: labath Date: Tue Nov 29 11:45:25 2016 New Revision: 288169 URL: http://llvm.org/viewvc/llvm-project?rev=288169&view=rev Log: Remove some OS-specific plugins from lldb-server dependencies I don't believe the code in those plugins could be in any way useful for lldb-server, but I can't be s

[Lldb-commits] [lldb] r288166 - Remove assorted other plugins which are not needed by lldb-server

Author: labath Date: Tue Nov 29 11:21:18 2016 New Revision: 288166 URL: http://llvm.org/viewvc/llvm-project?rev=288166&view=rev Log: Remove assorted other plugins which are not needed by lldb-server language runtime, structured data, sanitizers, process plugins. Modified: lldb/trunk/tools/ll

[Lldb-commits] [lldb] r288164 - Remove dynamic loader, platform and ABI plugins from lldb-server dependencies

Author: labath Date: Tue Nov 29 11:06:26 2016 New Revision: 288164 URL: http://llvm.org/viewvc/llvm-project?rev=288164&view=rev Log: Remove dynamic loader, platform and ABI plugins from lldb-server dependencies These packages are not used on the server. Modified: lldb/trunk/tools/lldb-server

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

filcab added a comment. I'd mostly use Anna's suggestions. Kuba: Can you remove the "detected" from the messages and refresh the patch, just so we can have one last look? Otherwise, if you think it's good enough, commit with these changes and we can do post-commit review. Co

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

This revision was automatically updated to reflect the committed changes. Closed by commit rL288159: Specify the dependencies of lldb-server manually (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26975?vs=78880&id=79584#toc Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [lldb] r288159 - Specify the dependencies of lldb-server manually

Author: labath Date: Tue Nov 29 10:40:57 2016 New Revision: 288159 URL: http://llvm.org/viewvc/llvm-project?rev=288159&view=rev Log: Specify the dependencies of lldb-server manually Summary: This basically just inlines the LLDBDependencies.cmake file into lldb-server CMakeLists.txt. The reason is

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. I think this is a great approach. LGTM! https://reviews.llvm.org/D26975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added a subscriber: lldb-commits. ldrumm updated this revision to Diff 79578. ldrumm added a comment. Addressed some unwanted whitespace changes as suggested by @bryant; use `os.dir.curdir` as instead of `.` https://reviews.llvm.org/D26757 Files: CMakeLists.txt scripts/CMakeLists.tx

Re: [Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

Lgtm, and as we start untangling the mess of dependencies in liblldb id like for us to take the same approach there too (as llvm does) On Tue, Nov 29, 2016 at 3:08 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > Any thoughts on this? > > > https://r

Re: [Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

On 28 November 2016 at 18:06, Jim Ingham wrote: > backtick parsing is currently incorrect, because it parses the backtick > before doing arg parsing, which means it does the substitutions for “raw” > commands: > > (lldb) expr char *$foo = "some `1 + 2` string" > (lldb) expr $foo > (char *) $foo =

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

labath added a comment. Any thoughts on this? https://reviews.llvm.org/D26975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r288122 - Remove ConnectionSharedMemory

Author: labath Date: Tue Nov 29 03:42:35 2016 New Revision: 288122 URL: http://llvm.org/viewvc/llvm-project?rev=288122&view=rev Log: Remove ConnectionSharedMemory This class is unused. Removed: lldb/trunk/include/lldb/Core/ConnectionSharedMemory.h lldb/trunk/source/Core/ConnectionSharedM

[Lldb-commits] [lldb] r288118 - Fix a typo.

Author: abidh Date: Tue Nov 29 03:31:57 2016 New Revision: 288118 URL: http://llvm.org/viewvc/llvm-project?rev=288118&view=rev Log: Fix a typo. Modified: lldb/trunk/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp Modified: lldb/trunk/source/Plugins/Process/Windows/Common/Targ

[Lldb-commits] [lldb] r288117 - Remove ConnectionMachPort

Author: labath Date: Tue Nov 29 03:23:05 2016 New Revision: 288117 URL: http://llvm.org/viewvc/llvm-project?rev=288117&view=rev Log: Remove ConnectionMachPort Summary: This class is unused, and since the StringRef refactor, it does not even implement the Connection interface. Reviewers: clayborg

[Lldb-commits] [PATCH] D27134: Remove ConnectionMachPort

This revision was automatically updated to reflect the committed changes. Closed by commit rL288117: Remove ConnectionMachPort (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27134?vs=79310&id=79518#toc Repository: rL LLVM https://reviews.llvm.org/D27134 Files: ll