Not going to block the CL over this, but consider using
llvm::StringSwitch<> for improving the readability of this rather large if
/ else block.
On Mon, Nov 28, 2016 at 6:14 PM Anna Zaks via Phabricator via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> zaks.anna added a comment.
>
> Here i
zaks.anna added a comment.
Here is another pass at this:
Comment at:
source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp:198
if (description == "heap-use-after-free") {
return "Use of deallocated memory detected";
} else if (descriptio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288094: [lldb] Fix compilation of SymbolFileDWARF.cpp with
ENABLE_DEBUG_PRINTF set (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D27177?vs=79465&id=79481#toc
Repository:
r
Author: alexshap
Date: Mon Nov 28 18:40:13 2016
New Revision: 288094
URL: http://llvm.org/viewvc/llvm-project?rev=288094&view=rev
Log:
[lldb] Fix compilation of SymbolFileDWARF.cpp with ENABLE_DEBUG_PRINTF set
This diff adds missing semicolon in SymbolFileDWARF.cpp
Differential revision: https:/
alexshap created this revision.
alexshap added reviewers: labath, sas.
alexshap added a subscriber: LLDB.
alexshap set the repository for this revision to rL LLVM.
This diff adds missing semicolon in SymbolFileDWARF.cpp .
Repository:
rL LLVM
https://reviews.llvm.org/D27177
Files:
source/Pl
Sure thing :-)
On Mon, Nov 28, 2016 at 1:17 PM, Tim Hammerquist wrote:
> Thanks, Todd!
>
> On Mon, Nov 28, 2016 at 9:19 AM, Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: tfiala
>> Date: Mon Nov 28 11:19:03 2016
>> New Revision: 288044
>>
>> URL: http://llvm.org
dmikulin added a comment.
I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single
step not a lot of tests pass on ARM FreeBSD ;)
Can we get https://reviews.llvm.org/D25756 committed?
https://reviews.llvm.org/D27126
___
lldb-co
Thanks, Todd!
On Mon, Nov 28, 2016 at 9:19 AM, Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Mon Nov 28 11:19:03 2016
> New Revision: 288044
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288044&view=rev
> Log:
> fix up Xcode build for r287916
>
> Mo
clayborg added a comment.
remove ConnectionSharedMemory.cpp that is...
https://reviews.llvm.org/D27134
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Feel free to remote ConnectionSharedMemory as well in another change.
https://reviews.llvm.org/D27134
___
lldb-commits mailing list
lldb-comm
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I agree with Pavel, it looks like you're using a side-effect of the Ephemeral
mode to preserve something you would be better off preserving explicitly.
https://reviews.llvm.org/D2
backtick parsing is currently incorrect, because it parses the backtick before
doing arg parsing, which means it does the substitutions for “raw” commands:
(lldb) expr char *$foo = "some `1 + 2` string"
(lldb) expr $foo
(char *) $foo = 0x00010032f100 "some 3 string"
That’s unexpected, and si
Author: tfiala
Date: Mon Nov 28 11:19:03 2016
New Revision: 288044
URL: http://llvm.org/viewvc/llvm-project?rev=288044&view=rev
Log:
fix up Xcode build for r287916
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/vi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288038: Fix floating point register reads x86_64 linux on
targets with no AVX support (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D27161?vs=79388&id=79405#toc
Repository:
Author: labath
Date: Mon Nov 28 09:51:47 2016
New Revision: 288038
URL: http://llvm.org/viewvc/llvm-project?rev=288038&view=rev
Log:
Fix floating point register reads x86_64 linux on targets with no AVX support
Summary:
On for 64-bit targets, the correct register set to read the fxsave are is
NT_
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:246-247
+
+
NativeRegisterContextLinux *
(nit): Please revert
https://reviews.llvm.org/D27161
_
valentinagiusti accepted this revision.
valentinagiusti added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D27161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
Author: labath
Date: Mon Nov 28 08:06:56 2016
New Revision: 288032
URL: http://llvm.org/viewvc/llvm-project?rev=288032&view=rev
Log:
XFAIL: TestNoreturnUnwind on android x86_64
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py
Modified
Author: labath
Date: Mon Nov 28 06:15:19 2016
New Revision: 288027
URL: http://llvm.org/viewvc/llvm-project?rev=288027&view=rev
Log:
skip android in @skipIfHostIncompatibleWithRemote
The current implementation of the decorator does not skip if the android target
arch is the same as host arch (as
Author: labath
Date: Mon Nov 28 05:47:14 2016
New Revision: 288026
URL: http://llvm.org/viewvc/llvm-project?rev=288026&view=rev
Log:
Fix a crash in ProcessPOSIXLog
We are getting a null pointer for the list of categories here (presumably due to
the args refactor).
Modified:
lldb/trunk/source
labath created this revision.
labath added reviewers: tberghammer, valentinagiusti.
labath added a subscriber: lldb-commits.
On for 64-bit targets, the correct register set to read the fxsave are is
NT_PRFPREG (only 32-bit targets need NT_PRXFPREG, presumably for historic
reasons). Reference:
http
21 matches
Mail list logo
