Re: [Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-21 Thread Ed Maste via lldb-commits
On 21 November 2016 at 18:18, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Mon Nov 21 17:18:07 2016 > New Revision: 287597 > > URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev > Log: > Add the new Args / entry-access API. FreeBSD buildbot is now failing with: http:

[Lldb-commits] [lldb] r287609 - Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD

2016-11-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Nov 21 20:25:41 2016 New Revision: 287609 URL: http://llvm.org/viewvc/llvm-project?rev=287609&view=rev Log: Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD Modified: lldb/trunk/include/lldb/Host/Editline.h Modified: lldb/trunk/include/lldb/Host/Editline.h URL: http://llv

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

2016-11-21 Thread Zachary Turner via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287597: Add the new Args / entry-access API. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D26883?vs=78617&id=78796#toc Repository: rL LLVM https://reviews.llvm.org/D26883

[Lldb-commits] [lldb] r287598 - Fix a bug caught by adding LLVM_NODISCARD to StringRef.

2016-11-21 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 21 17:18:13 2016 New Revision: 287598 URL: http://llvm.org/viewvc/llvm-project?rev=287598&view=rev Log: Fix a bug caught by adding LLVM_NODISCARD to StringRef. Modified: lldb/trunk/source/Target/StackFrame.cpp Modified: lldb/trunk/source/Target/StackFrame.cpp UR

[Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-21 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 21 17:18:07 2016 New Revision: 287597 URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev Log: Add the new Args / entry-access API. The long-term goal here is to get rid of the functions GetArgumentAtIndex() and GetQuoteCharAtIndex(), instead replacing them

[Lldb-commits] LLVM buildmaster will be restarted tonight

2016-11-21 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

2016-11-21 Thread Zachary Turner via lldb-commits
zturner added a comment. Instead of storing the quote char, I think we could just store two `StringRef`s. `str` and `quoted_str`, where `str = quoted_str.trim(quote_char);`, and if there is no quote char, then they are equal. I'd rather do that in a followup since this `ArgEntry` class has a

[Lldb-commits] [PATCH] D26908: Improve detection of global vs local variables

2016-11-21 Thread Greg Clayton via lldb-commits
clayborg added a comment. Looks fine. https://reviews.llvm.org/D26908 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

2016-11-21 Thread Jim Ingham via lldb-commits
jingham added a comment. In https://reviews.llvm.org/D26883#600683, @labath wrote: > I don't know how deep do you want this refactor to be, but there is one issue > I would like us to consider, if only to decide it is out of scope of this > change. I am talking about the `quote_char` thingy. Th

[Lldb-commits] [lldb] r287542 - Fix remote-linux regression due to stringRef changes

2016-11-21 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Mon Nov 21 09:18:58 2016 New Revision: 287542 URL: http://llvm.org/viewvc/llvm-project?rev=287542&view=rev Log: Fix remote-linux regression due to stringRef changes This is to fix a regression in remote-linux lldb-server connections. We were wrongly passing a copy of uri a

Re: [Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

2016-11-21 Thread Pavel Labath via lldb-commits
On 18 November 2016 at 19:54, Jim Ingham wrote: > If we are going to do that, I wonder if we should start having tests share > their inputs. We don’t do that for source files because the cost of > duplication is so small, and then you don’t have the hassle of adding > something to a source fie

[Lldb-commits] [PATCH] D26908: Improve detection of global vs local variables

2016-11-21 Thread Hafiz Abid Qadeer via lldb-commits
abidh added subscribers: clayborg, abidh. abidh added a comment. Please add @clayborg as reviewer. Also paste the dwarf generated for this case from both gcc and clang. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3911 +is_static_lifetime |= has_expl