[Lldb-commits] [lldb] r286926 - Change the kernel searching code to not go through the

Author: jmolenda Date: Mon Nov 14 19:41:27 2016 New Revision: 286926 URL: http://llvm.org/viewvc/llvm-project?rev=286926&view=rev Log: Change the kernel searching code to not go through the memory cache subsystem so we're reading only the 4 bytes needed to check for the magic word at the start of

[Lldb-commits] [lldb] r286915 - Fix some more StringRef printf warnings.

Author: zturner Date: Mon Nov 14 18:45:18 2016 New Revision: 286915 URL: http://llvm.org/viewvc/llvm-project?rev=286915&view=rev Log: Fix some more StringRef printf warnings. Modified: lldb/trunk/source/Commands/CommandObjectPlatform.cpp lldb/trunk/source/Commands/CommandObjectThread.cpp

[Lldb-commits] [lldb] r286916 - Fix some more Printf warnings.

Author: zturner Date: Mon Nov 14 18:45:23 2016 New Revision: 286916 URL: http://llvm.org/viewvc/llvm-project?rev=286916&view=rev Log: Fix some more Printf warnings. Modified: lldb/trunk/source/Interpreter/CommandAlias.cpp Modified: lldb/trunk/source/Interpreter/CommandAlias.cpp URL: http://

[Lldb-commits] [PATCH] D26643: Fix TestMiniDumpNew.py test for Python 2/3 issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL286909: Fix TestMiniDumpNew.py test for Python 2/3 issue (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D26643?vs=77900&id=77907#toc Repository: rL LLVM https://reviews.ll

[Lldb-commits] [lldb] r286909 - Fix TestMiniDumpNew.py test for Python 2/3 issue

Author: amccarth Date: Mon Nov 14 17:53:45 2016 New Revision: 286909 URL: http://llvm.org/viewvc/llvm-project?rev=286909&view=rev Log: Fix TestMiniDumpNew.py test for Python 2/3 issue On Windows, where we use Python 3 for testing, we have to be more explicit about converting between binary and s

[Lldb-commits] [lldb] r286908 - Fix a deadlock issue that would happen when loading an AppleTV or watchOS binary.

Author: gclayton Date: Mon Nov 14 17:45:50 2016 New Revision: 286908 URL: http://llvm.org/viewvc/llvm-project?rev=286908&view=rev Log: Fix a deadlock issue that would happen when loading an AppleTV or watchOS binary. This was a regression that was caused by svn revision 269877: commit 1ded4a2a2

[Lldb-commits] [PATCH] D26643: Fix TestMiniDumpNew.py test for Python 2/3 issue

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. On Windows, where we use Python 3 for testing, we have to be more explicit about converting between binary and string representations. I believe this should still work for Python 2, bu

[Lldb-commits] [lldb] r286906 - Fix some StringRef Printf warnings.

Author: zturner Date: Mon Nov 14 17:23:31 2016 New Revision: 286906 URL: http://llvm.org/viewvc/llvm-project?rev=286906&view=rev Log: Fix some StringRef Printf warnings. Modified: lldb/trunk/source/Commands/CommandObjectMultiword.cpp lldb/trunk/source/Interpreter/CommandInterpreter.cpp

[Lldb-commits] [lldb] r286899 - One more cleanup to lldb version printing

Author: cbieneman Date: Mon Nov 14 16:43:08 2016 New Revision: 286899 URL: http://llvm.org/viewvc/llvm-project?rev=286899&view=rev Log: One more cleanup to lldb version printing With this patch LLDB_VERSION_STRING replaces "lldb version x.x.x" if it is set. This allows builds to not display the

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

emaste added a comment. I applied this change on top of my WIP https://reviews.llvm.org/D26617 (which adds a FreeBSD core test). LLDB builds and my new test passes, so no objections from me. Once it's in I'll see about porting the new SSE test to FreeBSD too. https://reviews.llvm.org/D26300

[Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Built and passed all existing tests. https://reviews.llvm.org/D26618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D26528: Fix uninitialized members.

jingham accepted this revision. jingham added a reviewer: jingham. jingham added a comment. This revision is now accepted and ready to land. Looks fine to me. https://reviews.llvm.org/D26528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

I will gladly let Todd run tests on your diff, but I just thought I'd explain what is going on there In Cocoa, some NSURL objects are represented as "sub-URLs", e.g. you can start from www.apple.com and represent www.apple.com/macos as NSURL(base="www.apple.com", next="/macos") This can be r

[Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

tfiala added a comment. I will give this a run a bit later this morning. Should be no later than early afternoon. https://reviews.llvm.org/D26618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

zturner created this revision. zturner added reviewers: tfiala, beanz. zturner added a subscriber: lldb-commits. I have locally a a very large patch which removes the method of `StreamString` that returns a reference to the underlying `std::string` buffer, and instead returns a `StringRef`. The

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

No that sounds like a good change. Lgtm On Mon, Nov 14, 2016 at 3:00 AM Sam McCall wrote: > Agreed, I updated the patch. > > For the classes I touched, I also removed init-list initializers that had > no effect (e.g. where the member is ConstString and the initalizer > explictly called the defaul