This revision was automatically updated to reflect the committed changes.
Closed by commit rL286413: Fix weak symbol linkage in SBStructuredData, update
docs. (authored by tfiala).
Changed prior to commit:
https://reviews.llvm.org/D26470?vs=77405&id=77411#toc
Repository:
rL LLVM
https://rev
Author: tfiala
Date: Wed Nov 9 17:21:04 2016
New Revision: 286413
URL: http://llvm.org/viewvc/llvm-project?rev=286413&view=rev
Log:
Fix weak symbol linkage in SBStructuredData, update docs.
Summary:
This change fixes an issue where I was leaking a weakly-linked symbol in
the SBAPI. It also updat
tfiala added a comment.
Thanks, Jim!
https://reviews.llvm.org/D26470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good, @beanz!
https://reviews.llvm.org/D26478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D26470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tfiala updated this revision to Diff 77405.
tfiala added a comment.
Adjusted web docs.
https://reviews.llvm.org/D26470
Files:
API/SBStructuredData.cpp
SB-api-coding-rules.html
lldb/API/SBStructuredData.h
Index: SB-api-coding-rules.html
beanz created this revision.
beanz added a reviewer: lldb-commits.
beanz added a subscriber: tfiala.
Herald added a subscriber: mgorny.
This change unifies and simplifies the code paths between the Darwin and
non-Darwin code to print the LLDB version information.
It also introduces a new variabl
tfiala added a comment.
Making changes to the text...
Comment at: SB-api-coding-rules.html:51-54
+An example of this is the SBValue
class. Please note it is necessary for the Impl class to
+not be
jingham added a comment.
This is fine with one comment on the text.
Comment at: SB-api-coding-rules.html:51-54
+An example of this is the SBValue
class. Please note it is necessary for the Impl class to
+
tfiala created this revision.
tfiala added a reviewer: jingham.
tfiala added a subscriber: lldb-commits.
This change fixes an issue where I was leaking a weakly-linked symbol in the
SBAPI. It also updates the docs to call out what I did wrong.
https://reviews.llvm.org/D26470
Files:
API/SBSt
Author: ldrumm
Date: Wed Nov 9 13:20:39 2016
New Revision: 286387
URL: http://llvm.org/viewvc/llvm-project?rev=286387&view=rev
Log:
[RenderScript] Fix reduction argument printing
When placing function name breakpoints on RenderScript Reduction kernel
functions, we were not skipping over the func
granata.enrico added a comment.
Makes sense. Feel free to commit.
Repository:
rL LLVM
https://reviews.llvm.org/D26403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
All usages have been replaced by appropriate std::chrono funcionality, and the
class is now unused. The only used part of the cpp file is the DumpTim
Author: labath
Date: Wed Nov 9 09:05:45 2016
New Revision: 286373
URL: http://llvm.org/viewvc/llvm-project?rev=286373&view=rev
Log:
Remove TimeValue usage from ObjectContainerBSDArchive
Modified:
lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
lldb/t
Author: labath
Date: Wed Nov 9 09:05:48 2016
New Revision: 286374
URL: http://llvm.org/viewvc/llvm-project?rev=286374&view=rev
Log:
Remove TimeValue usage from lldb/Target
It was only used for declaring unused variables. :)
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trun
Author: labath
Date: Wed Nov 9 08:53:37 2016
New Revision: 286372
URL: http://llvm.org/viewvc/llvm-project?rev=286372&view=rev
Log:
Remove unused TimeValue include
Modified:
lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h
Modified:
lldb/trunk/source/Plugi
Author: labath
Date: Wed Nov 9 08:53:32 2016
New Revision: 286371
URL: http://llvm.org/viewvc/llvm-project?rev=286371&view=rev
Log:
Remove TimeValue usage from lldb/Host
Modified:
lldb/trunk/source/Host/common/Socket.cpp
lldb/trunk/source/Host/windows/ConnectionGenericFileWindows.cpp
Mo
Author: labath
Date: Wed Nov 9 08:33:22 2016
New Revision: 286369
URL: http://llvm.org/viewvc/llvm-project?rev=286369&view=rev
Log:
Remove TimeValue usage from lldb/Interpreter
Modified:
lldb/trunk/include/lldb/Interpreter/OptionValueFileSpec.h
lldb/trunk/source/Commands/CommandObjectTar
Author: labath
Date: Wed Nov 9 08:04:08 2016
New Revision: 286366
URL: http://llvm.org/viewvc/llvm-project?rev=286366&view=rev
Log:
Remove TimeValue usage from lldb/Core. NFC.
Modified:
lldb/trunk/include/lldb/Core/ModuleSpec.h
lldb/trunk/include/lldb/Core/SourceManager.h
lldb/trunk/
Author: tberghammer
Date: Wed Nov 9 05:52:12 2016
New Revision: 286360
URL: http://llvm.org/viewvc/llvm-project?rev=286360&view=rev
Log:
Fix expectation in TestStaticVariables.py after rL286302
The debug info emitted by clang for static variables improved by
rL286302 and it exposed an incorrect
labath added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:129
if (m_ptr_obj->GetValueAsUnsigned(0) == 0) {
stream.Printf("nullptr");
granata.enrico wrote:
> This is very nitpick-y but why not
>
> lldb::addr_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286355: Display the pointer value in the libstdc++
unique_ptr summary (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D26403?vs=77202&id=77329#toc
Repository:
rL LLVM
https:/
Author: labath
Date: Wed Nov 9 04:42:29 2016
New Revision: 286355
URL: http://llvm.org/viewvc/llvm-project?rev=286355&view=rev
Log:
Display the pointer value in the libstdc++ unique_ptr summary
Summary:
r284830 added a summary provider for unique_ptr in libstdc++, whose value
printed
the value
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286352: Disable windows-only minidump plugin (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D26393?vs=77175&id=77325#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26393
Author: labath
Date: Wed Nov 9 04:16:11 2016
New Revision: 286352
URL: http://llvm.org/viewvc/llvm-project?rev=286352&view=rev
Log:
Disable windows-only minidump plugin
Summary:
This commit disables the windows-only minidump plugin and enables the new
cross-platform plugin for windows minidump f
labath added a comment.
Yeah, feel free to take over. I was not planning to do any more work here -
just wanted to wrap things up. I am going to commit this then, and leave the
rest to you.
https://reviews.llvm.org/D26393
___
lldb-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286349: Remove TimeValue usage from Core/Module (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D26275?vs=77209&id=77323#toc
Repository:
rL LLVM
https://reviews.llvm.org/D262
Author: labath
Date: Wed Nov 9 03:59:18 2016
New Revision: 286349
URL: http://llvm.org/viewvc/llvm-project?rev=286349&view=rev
Log:
Remove TimeValue usage from Core/Module
Summary:
The only interesting part here is that TimePoint and TimeValue have different
natural string representations, which
28 matches
Mail list logo
