[Lldb-commits] [lldb] r286335 - When deciding whether to use the source remapping dictionary from

Author: jmolenda Date: Tue Nov 8 21:42:12 2016 New Revision: 286335 URL: http://llvm.org/viewvc/llvm-project?rev=286335&view=rev Log: When deciding whether to use the source remapping dictionary from a dSYM per-uuid plist, only use it when the DBGVersion key has a value of 2 or greater. Mo

[Lldb-commits] [lldb] r286312 - "thread backtrace" should use the thread-stop-format.

Author: jingham Date: Tue Nov 8 17:43:36 2016 New Revision: 286312 URL: http://llvm.org/viewvc/llvm-project?rev=286312&view=rev Log: "thread backtrace" should use the thread-stop-format. Modified: lldb/trunk/source/Commands/CommandObjectThread.cpp Modified: lldb/trunk/source/Commands/Comm

[Lldb-commits] [lldb] r286303 - Fix some cases where we were printf'ing StringRefs.

Author: zturner Date: Tue Nov 8 16:23:50 2016 New Revision: 286303 URL: http://llvm.org/viewvc/llvm-project?rev=286303&view=rev Log: Fix some cases where we were printf'ing StringRefs. Modified: lldb/trunk/source/Interpreter/Args.cpp Modified: lldb/trunk/source/Interpreter/Args.cpp URL: ht

[Lldb-commits] [lldb] r286301 - Fix up the formats.html for the addition of the thread-stop-format.

Author: jingham Date: Tue Nov 8 16:05:29 2016 New Revision: 286301 URL: http://llvm.org/viewvc/llvm-project?rev=286301&view=rev Log: Fix up the formats.html for the addition of the thread-stop-format. Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL: http:/

[Lldb-commits] [lldb] r286288 - Clean up the stop printing header lines.

Author: jingham Date: Tue Nov 8 14:36:40 2016 New Revision: 286288 URL: http://llvm.org/viewvc/llvm-project?rev=286288&view=rev Log: Clean up the stop printing header lines. I added a "thread-stop-format" to distinguish between the form that is just the thread info (since the stop printing immed

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Problem was at my end. This patch works fine for me now. I'm planning to do some more minidump work, so I'd be happy to take over with eliminating the old Windows-specific implementation.

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Make what you will of my suggestion above, but in general the reasoning looks good Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:1

Re: [Lldb-commits] [lldb] r285542 - [Test Suite] Pull generateSource into lldbtest

Did a little post-patch (and post-fix) research. Looks like this is a difference between Py2 and Py3. It is well explained here: http://bugs.python.org/issue5242 Apparently eval only grabs locals and globals, and in Py3 list comprehensions have their own funct

Re: [Lldb-commits] [lldb] r286258 - [Test Suite] Properly quote python string

Was just about to comment on this. Thanks! On Tue, Nov 8, 2016 at 10:24 AM Chris Bieneman via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Tue Nov 8 12:14:42 2016 > New Revision: 286258 > > URL: http://llvm.org/viewvc/llvm-project?rev=286258&view=rev > Log: > [

[Lldb-commits] [lldb] r286258 - [Test Suite] Properly quote python string

Author: cbieneman Date: Tue Nov 8 12:14:42 2016 New Revision: 286258 URL: http://llvm.org/viewvc/llvm-project?rev=286258&view=rev Log: [Test Suite] Properly quote python string Oops! Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lldbsu

Re: [Lldb-commits] [lldb] r285542 - [Test Suite] Pull generateSource into lldbtest

I pushed an attempted fix in r286254. I wonder if this is a difference between python 2.7 and 3. The comprehension should capture everything, as should the eval call. I wonder if one of those captures less in python 3 compared to python 2.7. Hopefully my patch will resolve the issue for you. -

[Lldb-commits] [lldb] r286254 - [Test Suite] Attempt to fix issue zturner reported to me

Author: cbieneman Date: Tue Nov 8 11:53:18 2016 New Revision: 286254 URL: http://llvm.org/viewvc/llvm-project?rev=286254&view=rev Log: [Test Suite] Attempt to fix issue zturner reported to me Not sure why this didn't explode more massively, but this should fix the issue with the non-framework t

[Lldb-commits] [PATCH] D26275: Remove TimeValue usage from Core/Module

labath updated this revision to Diff 77209. labath added a comment. It turns out this was the only usage of TimeValue::Dump. I've changed that into a standalone function so it can be called without a TimeValue. Once Zachary lands the formatting change in llvm I'd like add a more generic time form

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

amccarth added a comment. In https://reviews.llvm.org/D26393#589421, @labath wrote: > In https://reviews.llvm.org/D26393#589363, @amccarth wrote: > > > I started testing the new plugin on Windows yesterday, and it doesn't work > > (all the tests fail). I'm planning to debug today, and, once I g

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

labath added a comment. In https://reviews.llvm.org/D26393#589363, @amccarth wrote: > I started testing the new plugin on Windows yesterday, and it doesn't work > (all the tests fail). I'm planning to debug today, and, once I get it > working, I'd be happy to switch it over. Interesting. It

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

amccarth added a comment. I started testing the new plugin on Windows yesterday, and it doesn't work (all the tests fail). I'm planning to debug today, and, once I get it working, I'd be happy to switch it over. https://reviews.llvm.org/D26393 __

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

labath created this revision. labath added reviewers: tberghammer, granata.enrico. labath added a subscriber: lldb-commits. r284830 added a summary provider for unique_ptr in libstdc++, whose value printed the value of the pointee. This is a bit unintuitive as it becomes unobvious that the value

Re: [Lldb-commits] [lldb] r285542 - [Test Suite] Pull generateSource into lldbtest

On Sun, Oct 30, 2016 at 9:57 PM Chris Bieneman via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=285542&r1=285541&r2=28554

Re: [Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

I think the UnwindAssemblyInstEmulation tracks every register without knowing if it is volatile or not and then RegisterContextLLDB will consult with the ABI (during RegisterRead) to decide which registers can it recover (based on volatile/non-volatile). For x86 I think the long term solution would

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

labath created this revision. labath added reviewers: amccarth, zturner. labath added subscribers: lldb-commits, dvlahovski. This commit disables the windows-only minidump plugin and enables the new cross-platform plugin for windows minidump files. Test decorators are adjusted to reflect that: wi