This revision was automatically updated to reflect the committed changes.
Closed by commit rL286215: [lldb] Don't build unit tests for unsupported
targets (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D26338?vs=77001&id=77148#toc
Repository:
rL LLVM
https://review
Author: vedantk
Date: Tue Nov 8 00:49:59 2016
New Revision: 286215
URL: http://llvm.org/viewvc/llvm-project?rev=286215&view=rev
Log:
[lldb] Don't build unit tests for unsupported targets
Differential Revision: https://reviews.llvm.org/D26338
Modified:
lldb/trunk/unittests/UnwindAssembly/CMa
Author: zturner
Date: Mon Nov 7 22:52:16 2016
New Revision: 286208
URL: http://llvm.org/viewvc/llvm-project?rev=286208&view=rev
Log:
Convert some Expression parser functions to StringRef.
Modified:
lldb/trunk/include/lldb/Core/RegularExpression.h
lldb/trunk/include/lldb/Expression/Expres
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286204: Rewrite OutputFormattedHelpText in terms of
StringRef. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26325?vs=76970&id=77138#toc
Repository:
rL LLVM
https://revie
Author: zturner
Date: Mon Nov 7 22:12:42 2016
New Revision: 286204
URL: http://llvm.org/viewvc/llvm-project?rev=286204&view=rev
Log:
Rewrite OutputFormattedHelpText in terms of StringRef.
This makes the logic easier to follow and also propagates
StringRef up to the API boundary, which is necessa
enlight added a comment.
@ki.stfu Are you OK with this going in?
Repository:
rL LLVM
https://reviews.llvm.org/D26124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks formally equivalent to me.
https://reviews.llvm.org/D26325
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
I seem not to close the formal loop on these reviews...
https://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
Author: enrico
Date: Mon Nov 7 17:32:20 2016
New Revision: 286176
URL: http://llvm.org/viewvc/llvm-project?rev=286176&view=rev
Log:
Simplify the PrintableRepresentationSpecialCases code; we never used the
ePrintableRepresentationSpecialCasesOnly value and with enum classes the names
doesn't nee
Author: jingham
Date: Mon Nov 7 16:47:01 2016
New Revision: 286170
URL: http://llvm.org/viewvc/llvm-project?rev=286170&view=rev
Log:
UserExpression::Evaluate only returns a non-empty ValueObjectSP
if it returns eExpressionCompleted. Don't try to get the error
from the ValueObjectSP if that's not
Hello everyone,
LLVM buildmaster will be restarted at 5 PM Pacific time today for
maintenance.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Thanks Vedant, we always build armv7/arm64/x86 llvm targets with the xcode
style lldb/llvm builds so I hadn't seen this problem. Please commit.
https://reviews.llvm.org/D26338
Just to be clear, if the unit test depends on functionality that isn't
present when this target isn't defined, then your original patch sounds
correct.
On Mon, Nov 7, 2016 at 11:06 AM Vedant Kumar wrote:
>
> > On Nov 7, 2016, at 8:20 AM, Zachary Turner wrote:
> >
> > Why not?
>
> It breaks my bu
> On Nov 7, 2016, at 8:20 AM, Zachary Turner wrote:
>
> Why not?
It breaks my build.
If the right solution is to fix the unit test, we should advertise somewhere
that '-DLLVM_TARGETS_TO_BUILD=X86' is temporarily broken and drop this patch.
I'd volunteer to put something like that in place.
>
clayborg added a comment.
It would be great if we can match the old format somehow. It is definitely
clearer. If we can't, don't worry about it too much as it isn't shown by
default. Hopefully no one is text scraping.
https://reviews.llvm.org/D26275
_
The problem is that if we reuse the LLVM disassembler (I am not sure if we
do it in TestArm64InstEmulation or not but we definitely should) then we
need LLVM to be build with support for that specific architecture as
otherwise the assembly analysis based unwinding test won't work.
On Mon, Nov 7, 2
Author: enrico
Date: Mon Nov 7 10:25:01 2016
New Revision: 286116
URL: http://llvm.org/viewvc/llvm-project?rev=286116&view=rev
Log:
Fix an issue where LLDB would hang trying to launch tvOS simulator binaries
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
Why not? Just because llvm isn't building support for targeting some
architecture doesn't mean lldb shouldn't be able to debug those
architectures. We could add a similar LLDB specific define, but using
llvm's seems wrong
On Sun, Nov 6, 2016 at 6:13 PM Vedant Kumar via lldb-commits <
lldb-commits@l
labath added a comment.
I've renamed to folder into elf-core and put "linux" into the individual file
names. I did not rename `TestLinuxCore.py` as I am still not sure what to do
about it -- if we end up having a lot of these tests, we may want a separate
`TestFreeBSDCore.py`, with the common c
Author: labath
Date: Mon Nov 7 03:58:58 2016
New Revision: 286101
URL: http://llvm.org/viewvc/llvm-project?rev=286101&view=rev
Log:
Make space for FreeBSD core file tests
This renames the functionalities/postmortem/linux-core to elf-core and puts the
"linux" part into the individual names of the
20 matches
Mail list logo
