This revision was automatically updated to reflect the committed changes.
Closed by commit rL285484: Limit LLDB_EXPORT_ALL_SYMBOLS to lldb symbols
(authored by tfiala).
Changed prior to commit:
https://reviews.llvm.org/D26093?vs=76229&id=76282#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: tfiala
Date: Fri Oct 28 19:29:15 2016
New Revision: 285484
URL: http://llvm.org/viewvc/llvm-project?rev=285484&view=rev
Log:
Limit LLDB_EXPORT_ALL_SYMBOLS to lldb symbols
LLDB_EXPORT_ALL_SYMBOLS used to instruct the build to export all
the symbols in liblldb on CMake builds. This change
tfiala added a comment.
In https://reviews.llvm.org/D26093#582659, @beanz wrote:
> In https://reviews.llvm.org/D26093#582618, @tfiala wrote:
>
> > The current usage of CommandLine via global static constructors in
> > Debug.cpp seems like a poor choice, as it forces all users of llvm with
> > N
beanz added a comment.
In https://reviews.llvm.org/D26093#582618, @tfiala wrote:
> The current usage of CommandLine via global static constructors in Debug.cpp
> seems like a poor choice, as it forces all users of llvm with NDEBUG not
> defined to get some command line behavior that they may ne
tfiala added a comment.
In https://reviews.llvm.org/D26093#582583, @beanz wrote:
> This patch ends up hiding the problem, not fixing it.
Yes.
> If it unblocks something it might be ok, but it doesn't actually fix the
> problem.
It allows debugging of lldb with lldb on Ubuntu. This broke rec
beanz added a comment.
This patch ends up hiding the problem, not fixing it. If it unblocks something
it might be ok, but it doesn't actually fix the problem.
The underlying problem is that liblldb and lldb-mi have their own copies of
LLVM with their own copies of the GlobalParser static
(llvm
labath added a comment.
In https://reviews.llvm.org/D26093#582420, @tfiala wrote:
> The reason why it doesn't blow up in the hidden case is that liblldb.so has
> already internally resolved the storage, doesn't involve dynamic resolution,
> and has its own data location. Ditto for lldb-mi's co
tfiala abandoned this revision.
tfiala added a comment.
I'm at a loss for the workflow to close this. I originally commandeered it to
do an abort on it, but that didn't work. I'm going to abandon it, and see if I
can kill it then.
Repository:
rL LLVM
https://reviews.llvm.org/D25830
___
tfiala added a comment.
The reason why it doesn't blow up in the hidden case is that liblldb.so has
already internally resolved the storage, doesn't involve dynamic resolution,
and has its own data location. Ditto for lldb-mi's copy. So they are separate
islands.
There are two totally separa
tfiala added a comment.
In https://reviews.llvm.org/D26093#582412, @tfiala wrote:
> In https://reviews.llvm.org/D26093#582395, @labath wrote:
>
> > I am a bit surprised that this fixes the problem. I would have expected
> > that the problem would occur in case when we *do* restrict exports,
>
>
tfiala added a comment.
In https://reviews.llvm.org/D26093#582395, @labath wrote:
> I am a bit surprised that this fixes the problem. I would have expected that
> the problem would occur in case when we *do* restrict exports,
This matches my expectations. When I was using the flag the exporte
labath added a reviewer: beanz.
labath added a subscriber: beanz.
labath added a comment.
I am a bit surprised that this fixes the problem. I would have expected that
the problem would occur in case when we *do* restrict exports, as in that case,
it is much easier to pull in copies of stuff twic
Author: adrian
Date: Fri Oct 28 15:11:27 2016
New Revision: 285441
URL: http://llvm.org/viewvc/llvm-project?rev=285441&view=rev
Log:
Rename DWARF 5 constants to adapt to change in LLVM
Modified:
lldb/trunk/source/Expression/DWARFExpression.cpp
Modified: lldb/trunk/source/Expression/DWARFExpr
tfiala added inline comments.
Comment at: API/CMakeLists.txt:106
# from working on some systems but limits the liblldb size.
-MESSAGE("-- Symbols (liblldb): only exporting liblldb.exports symbols")
+MESSAGE("-- Symbols (liblldb): only exporting symbols in lldb namesp
tfiala created this revision.
tfiala added reviewers: labath, tberghammer.
tfiala added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
My original implementation of this last year was to just export everything from
liblldb.so. As lldb-mi recently started including a separate copy
Hello everyone,
LLVM buildmaster will restarted at 1 PM Pacific time today.
Thank you for understanding.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth accepted this revision.
amccarth added a reviewer: amccarth.
amccarth added a comment.
This revision is now accepted and ready to land.
I like that this keeps the WoW64 detection and support. That's a very
Windows-specific thing, and I was concerned that doing generic minidump parsing
labath added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:340
std::map reg_values;
+ reg_values[lldb_rax_x86_64] = 0x;
amccarth wrote:
> It seems a shame to remove the `// clang-format off` comment for this
Author: adrian
Date: Fri Oct 28 13:14:43 2016
New Revision: 285424
URL: http://llvm.org/viewvc/llvm-project?rev=285424&view=rev
Log:
Rename DWARF 5 constants to adapt to change in LLVM
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp
Modified: lldb/trunk/source/Plugin
amccarth accepted this revision.
amccarth added a reviewer: amccarth.
amccarth added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:340
std::map reg_values;
+ reg_values[lldb_rax_x86_64] = 0x;
It seems a shame
labath added a comment.
Good point about the single dots. I'll add the tests and make sure they work
properly.
https://reviews.llvm.org/D26081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
amccarth added inline comments.
Comment at: source/Host/common/FileSpec.cpp:550
+ (m_filename.GetStringRef() != ".." && m_filename.GetStringRef() != "."))
+return *this;
Do we have to worry about an unnecessary single dot in the directory, like
`/foo/
Thanks, I'll keep that in mind. I have a fix for this already, so
hopefully these should go away quickly.
pl
On 28 October 2016 at 16:34, Zachary Turner wrote:
> Instead of #if 0'ing them, I believe you can add _Disabled to the end of the
> name. A common pattern is something like this:
>
> #if
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
.. handling for windows path was completely broken because the function was
expecting \ as path separators, but we were passing it normalized file paths,
where these have been replaced
Instead of #if 0'ing them, I believe you can add _Disabled to the end of
the name. A common pattern is something like this:
#if LLVM_ON_WIN32
#define TestFunBlackslashes_Maybe TestFunBlackslashes_Disabled
#else
#define TestFunBlackslashes_Maybe TestFunBlackslashes
#endif
TEST_F(FileSpecTest, Te
Author: labath
Date: Fri Oct 28 06:28:01 2016
New Revision: 285393
URL: http://llvm.org/viewvc/llvm-project?rev=285393&view=rev
Log:
Add a couple of fun unit tests for FileSpec::Equal
Most of them fail right now and are commented out. The main problem is handling
of backslashes on windows, but al
labath added a comment.
Tamas is not in this week. He should be back on monday.
Repository:
rL LLVM
https://reviews.llvm.org/D25864
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
dvlahovski updated this revision to Diff 76176.
dvlahovski added a comment.
Hopefully removing code that's not for this CL
https://reviews.llvm.org/D25905
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Python/lldbsuite/test/functi
There is no new failure in the tests in Debug version on MSVC 2015, however
a bunch of failures (~30) were masked on Release builds (the Test Methods
count went from 769 to 1188). All the failures were already presents in the
Debug builds (where the optimizer didn't mess up with the code due to
LLV
29 matches
Mail list logo
