sylvestre.ledru updated this revision to Diff 72758.
sylvestre.ledru added a comment.
Herald added subscribers: mgorny, beanz.
Updated by Pino!
https://reviews.llvm.org/D23977
Files:
cmake/LLDBDependencies.cmake
cmake/modules/LLDBConfig.cmake
scripts/Python/modules/CMakeLists.txt
script
Not sure why operator= is returning a const&. It doesn't matter in practice
but it's a bit strange. Anyway lgtm
On Tue, Sep 27, 2016 at 7:11 PM Daniel Austin Noland via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Explicit delete is preferable to declaring a method private when
> your inte
Explicit delete is preferable to declaring a method private when
your intention is to prevent that method from ever being used.
* better compiler error messages
* can't be bypassed by friendship
* clearer intent
This was discussed here:
http://lists.llvm.org/pipermail/lldb-dev/2016-Septembe
penryu added a watcher: penryu.
PROJECT DETAIL
https://reviews.llvm.org/project/profile/39/
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
penryu added a member: penryu.
PROJECT DETAIL
https://reviews.llvm.org/project/profile/39/
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL238787.
https://reviews.llvm.org/D10167
___
lldb-commits mailing list
lldb-commits@lists.
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed. Need to be rebased and format with
Clang-format.
https://reviews.llvm.org/D10216
___
lldb-commits mailing list
lldb-commits@lists
omjavaid updated this revision to Diff 72723.
omjavaid added a comment.
Give this approach a rethink I dont see a lot of problems with this final
implementation unless it fails on other architectures.
We are already hacking our way to have these byte selection watchpoints working
in existing cod
fjricci created this revision.
fjricci added reviewers: zturner, labath, tfiala, jingham.
fjricci added subscribers: sas, lldb-commits.
This patch is necessary because individual test cases are not required
to have unique names. Therefore, test cases must now
be specified explicitly in the form ..
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282537: Update FileSpec's interface to use StringRefs.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D24936?vs=72555&id=72705#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: zturner
Date: Tue Sep 27 15:48:37 2016
New Revision: 282537
URL: http://llvm.org/viewvc/llvm-project?rev=282537&view=rev
Log:
Update FileSpec's interface to use StringRefs.
Differential Revision: https://reviews.llvm.org/D24936
Modified:
lldb/trunk/include/lldb/Host/FileSpec.h
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282529: Adding a RegisterContextMinidump_x86_64 converter
(authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D24919?vs=72688&id=72689#toc
Repository:
rL LLVM
https://reviews
Author: dvlahovski
Date: Tue Sep 27 14:05:55 2016
New Revision: 282529
URL: http://llvm.org/viewvc/llvm-project?rev=282529&view=rev
Log:
Adding a RegisterContextMinidump_x86_64 converter
Summary:
This is a register context converter from Minidump to Linux reg context.
This knows the layout of the
dvlahovski updated this revision to Diff 72688.
dvlahovski added a comment.
I like the combined approach more. So this is the implementation
https://reviews.llvm.org/D24919
Files:
include/lldb/lldb-private-types.h
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minid
carlokok created this revision.
carlokok added a subscriber: LLDB.
carlokok set the repository for this revision to rL LLVM.
carlokok added a project: LLDB.
These apis are called by lldb process launching but the unreachable causes them
to fail on Windows. However, they don't have to do anything
zturner added inline comments.
Comment at: source/Interpreter/Args.cpp:286-288
@@ -338,5 +285,5 @@
-const char **Args::GetConstArgumentVector() const {
- if (!m_argv.empty())
-return const_cast(&m_argv[0]);
- return nullptr;
+ // This is kind of gross, but it ensures that
zturner added inline comments.
Comment at: source/Interpreter/Args.cpp:286-288
@@ -338,5 +285,5 @@
-const char **Args::GetConstArgumentVector() const {
- if (!m_argv.empty())
-return const_cast(&m_argv[0]);
- return nullptr;
+ // This is kind of gross, but it ensures that
clayborg added a comment.
Ok, so just add the boolean arg to Args::GetArgumentVector and we are good to
go.
Comment at: source/Interpreter/Args.cpp:270-272
@@ -321,5 +269,5 @@
const char *Args::GetArgumentAtIndex(size_t idx) const {
- if (idx < m_argv.size())
-return m_ar
zturner added inline comments.
Comment at: source/Interpreter/Args.cpp:269-272
@@ -320,6 +268,6 @@
const char *Args::GetArgumentAtIndex(size_t idx) const {
- if (idx < m_argv.size())
-return m_argv[idx];
+ if (idx < m_args.size())
+return m_args[idx].c_str();
retur
Author: tfiala
Date: Tue Sep 27 12:17:21 2016
New Revision: 282508
URL: http://llvm.org/viewvc/llvm-project?rev=282508&view=rev
Log:
convert TestFatArchives.py over to no-debug-info test
We only use the .o-style debug info here regardless, so having
it run all three debuginfo styles was a waste.
clayborg added a comment.
Please comment why you are manually bit twiddling due to the size of the
register that can change. We don't want anyone else copying this kind of code.
Another solution would be to update the offset of the register when you change
the byte size so none of this would ne
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Interpreter/Args.cpp:264-265
@@ -315,3 +263,4 @@
size_t Args::GetArgumentCount() const {
- if (m_argv.empty())
+ if (
zturner accepted this revision.
This revision is now accepted and ready to land.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:50
@@ +49,3 @@
+size = 8;
+break;
+ }
If they are just smaller (but never bigger), you can cal
dvlahovski added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:177
@@ +176,3 @@
+#define REG_VAL(x) *(reinterpret_cast(x))
+
+TEST_F(MinidumpParserTest, ConvertRegisterContext) {
amccarth wrote:
> `EXPECT_xxx` will check the condit
Author: tfiala
Date: Tue Sep 27 10:57:12 2016
New Revision: 282496
URL: http://llvm.org/viewvc/llvm-project?rev=282496&view=rev
Log:
xfail TestExec.py on macOS
Tracked by:
rdar://28476369
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
Modified:
lldb/tr
amccarth added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:177
@@ +176,3 @@
+#define REG_VAL(x) *(reinterpret_cast(x))
+
+TEST_F(MinidumpParserTest, ConvertRegisterContext) {
`EXPECT_xxx` will check the condition and report if it
dvlahovski added a comment.
Thanks for the explanation and examples! :) Will keep this in mind in the
future.
https://reviews.llvm.org/D24919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
evgeny777 abandoned this revision.
evgeny777 added a comment.
This patch is longer valid after more than 9 months on review due to changes in
namespace handing in ClangExpressionDeclMap. It probably should be done in a
different way, but I don't have time for this now.
https://reviews.llvm.org
zturner added a comment.
`ASSERT_EQ` causes the test method to return immediately if the condition
fails. `EXPECT_EQ` will continue running the same test body. I like to use
`ASSERT_EQ`, for example, if you are checking the value of a pointer returned
by a function. First you want to check i
dvlahovski updated this revision to Diff 72659.
dvlahovski added a comment.
Addressing Zachary's and Adrian's comments
https://reviews.llvm.org/D24919
Files:
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/M
dvlahovski marked 5 inline comments as done.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:49
@@ +48,3 @@
+writeRegister(source_data, result_base, ®_info[lldb_cs_x86_64], 2);
+ }
+
zturner wrote:
> dvlahovski wrote:
> > sizeo
zturner updated this revision to Diff 72657.
zturner added a comment.
Updated
https://reviews.llvm.org/D24952
Files:
examples/plugins/commands/fooplugin.cpp
include/lldb/API/SBCommandInterpreter.h
include/lldb/Host/OptionParser.h
include/lldb/Interpreter/Args.h
source/API/SBCommandInt
amccarth added a subscriber: amccarth.
Comment at: include/lldb/Interpreter/Args.h:154
@@ -167,3 +153,3 @@
//--
- const char **GetConstArgumentVector() const;
+ void GetArgumentVector(std::vector &args) const;
labath added a subscriber: labath.
Comment at: include/lldb/Interpreter/Args.h:150
@@ -147,19 +149,3 @@
///
/// @return
/// An array of NULL terminate C string argument pointers that
I think doxygen will complain about `@return` in a function returnin
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D24610#553331, @omjavaid wrote:
> This is a new version of what seems to me fully implementing functionality we
> intend to have here.
>
> On a second tho
nitesh.jain added a comment.
In https://reviews.llvm.org/D24603#548902, @clayborg wrote:
> So it seems like this can be fixed by doing a few things:
> 1 - just set the RegisterInfo.offset to the actual offset in the buffer and
> don't use the offset as the ptrace key used to grab the register
>
nitesh.jain updated this revision to Diff 72618.
nitesh.jain added a comment.
Herald added a subscriber: ki.stfu.
Updated patch as per suggestion.
https://reviews.llvm.org/D24603
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
source/Plugins/Process/Linux/NativeReg
37 matches
Mail list logo
