grosser added a reviewer: Meinersbur.
grosser added a comment.
Pablo, thank you for taking Polly into account as well. I add Michael, who
probably knows our cmake build system best.
Repository:
rL LLVM
https://reviews.llvm.org/D24863
___
lldb-co
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/pre_kill_hook/linux.py:68
@@ +67,3 @@
+else:
+raise Exception("failed to call 'perf record .., error: ")
+
Haha woops - that should be:
```
raise Exception("failed to call 'per
tfiala created this revision.
tfiala added reviewers: labath, tberghammer.
tfiala added a subscriber: lldb-commits.
This is the Linux counterpart to the recently-added macOS-side support for
sampling a test process that times out, prior to killing it.
This implementation is based on the Linux pe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282314: [CMake] Generate LLDB_REVISION at build time
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D24846?vs=72215&id=72381#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: cbieneman
Date: Fri Sep 23 18:33:52 2016
New Revision: 282314
URL: http://llvm.org/viewvc/llvm-project?rev=282314&view=rev
Log:
[CMake] Generate LLDB_REVISION at build time
Summary:
This alters the generation of LLDB_REVISION to be heavily based on how clang
generates its version header.
zturner accepted this revision.
zturner added a comment.
lgtm, everything works.
https://reviews.llvm.org/D24846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.
Making static archives only have dependencies on other static archives has
serious implications and fundamentally breaks `LLVM_LINK_LLVM_DYLIB`. For
example:
libClangDriver.a depends
Not done building yet, I also had to fetch a new llvm, but at least those were
needed.
Jim
> On Sep 23, 2016, at 3:47 PM, Zachary Turner wrote:
>
> Ahh nvm, I see you beat me to it. Thanks
>
> On Fri, Sep 23, 2016 at 3:47 PM Zachary Turner wrote:
> Thanks I'll take a look. I only saw the o
Ahh nvm, I see you beat me to it. Thanks
On Fri, Sep 23, 2016 at 3:47 PM Zachary Turner wrote:
> Thanks I'll take a look. I only saw the other because I got a buildbot
> break notification. I'll go checkout Host.mm
>
> On Fri, Sep 23, 2016 at 3:44 PM Jim Ingham wrote:
>
> I think you missed
Thanks I'll take a look. I only saw the other because I got a buildbot
break notification. I'll go checkout Host.mm
On Fri, Sep 23, 2016 at 3:44 PM Jim Ingham wrote:
> I think you missed some changes in Host.mm on OS X as well.
>
> Jim
>
> > On Sep 23, 2016, at 3:27 PM, Zachary Turner via lldb
Author: jingham
Date: Fri Sep 23 17:36:00 2016
New Revision: 282311
URL: http://llvm.org/viewvc/llvm-project?rev=282311&view=rev
Log:
Mutatis mutandis for char * -> StringRef.
Modified:
lldb/trunk/source/Host/macosx/Host.mm
Modified: lldb/trunk/source/Host/macosx/Host.mm
URL:
http://llvm.o
I think you missed some changes in Host.mm on OS X as well.
Jim
> On Sep 23, 2016, at 3:27 PM, Zachary Turner via lldb-commits
> wrote:
>
> Author: zturner
> Date: Fri Sep 23 17:27:03 2016
> New Revision: 282309
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282309&view=rev
> Log:
> Fix bui
Author: enrico
Date: Fri Sep 23 17:30:08 2016
New Revision: 282310
URL: http://llvm.org/viewvc/llvm-project?rev=282310&view=rev
Log:
Add an accessor to get the value of RC_PLATFORM_NAME at build time
Modified:
lldb/trunk/scripts/Xcode/lldbbuild.py
Modified: lldb/trunk/scripts/Xcode/lldbbuild
Author: zturner
Date: Fri Sep 23 17:27:03 2016
New Revision: 282309
URL: http://llvm.org/viewvc/llvm-project?rev=282309&view=rev
Log:
Fix build on Ubuntu.
This was in some code that was #ifdef'd out on Windows, so I
didn't see it.
Modified:
lldb/trunk/source/Host/common/Host.cpp
Modified: l
Author: zturner
Date: Fri Sep 23 17:11:51 2016
New Revision: 282306
URL: http://llvm.org/viewvc/llvm-project?rev=282306&view=rev
Log:
Change FileAction::GetPath() to return a StringRef.
Modified:
lldb/trunk/include/lldb/Target/FileAction.h
lldb/trunk/include/lldb/Target/Target.h
lldb/
Author: fjricci
Date: Fri Sep 23 16:32:47 2016
New Revision: 282298
URL: http://llvm.org/viewvc/llvm-project?rev=282298&view=rev
Log:
Allow for tests to be disabled at runtime
Summary:
The current implementation of the test suite allows the user to run
a certain subset of tests using '-p', but do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282298: Allow for tests to be disabled at runtime (authored
by fjricci).
Changed prior to commit:
https://reviews.llvm.org/D24629?vs=71651&id=72360#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
tfiala closed this revision.
tfiala added a comment.
Thanks, Jim!
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: enrico
Date: Fri Sep 23 16:24:08 2016
New Revision: 282297
URL: http://llvm.org/viewvc/llvm-project?rev=282297&view=rev
Log:
Install only the manpage and only in the proper location
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxpr
Author: zturner
Date: Fri Sep 23 13:42:38 2016
New Revision: 282277
URL: http://llvm.org/viewvc/llvm-project?rev=282277&view=rev
Log:
Change Module::RemapPath to use StringRef.
Modified:
lldb/trunk/include/lldb/Core/Module.h
lldb/trunk/include/lldb/Target/PathMappingList.h
lldb/trunk/
BTW, a TON of unnecessary stuff currently depends on the clang tablegen
targets, due to the way the libraries are not well layered. So you can be
trying to build CommandObjectMemory.cpp, and all of a sudden it has to
build the clang tablegen targets. Very frustrating for incremental
development.
Author: zturner
Date: Fri Sep 23 13:13:18 2016
New Revision: 282271
URL: http://llvm.org/viewvc/llvm-project?rev=282271&view=rev
Log:
Try again to match the logic of the code before re-writing.
Modified:
lldb/trunk/source/Interpreter/OptionGroupValueObjectDisplay.cpp
Modified: lldb/trunk/sou
Author: zturner
Date: Fri Sep 23 13:11:03 2016
New Revision: 282270
URL: http://llvm.org/viewvc/llvm-project?rev=282270&view=rev
Log:
Try to fix failing TestDataFormatterSkipSummary test case.
Modified:
lldb/trunk/source/Interpreter/OptionGroupValueObjectDisplay.cpp
Modified: lldb/trunk/sour
Author: zturner
Date: Fri Sep 23 13:06:53 2016
New Revision: 282269
URL: http://llvm.org/viewvc/llvm-project?rev=282269&view=rev
Log:
Update the prompt related functions to use StringRefs.
Modified:
lldb/trunk/include/lldb/Core/Debugger.h
lldb/trunk/include/lldb/Core/Event.h
lldb/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282265: Update OptionGroup::SetValue to take StringRef.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D24847?vs=72234&id=72310#toc
Repository:
rL LLVM
https://reviews.llvm
Author: zturner
Date: Fri Sep 23 12:48:13 2016
New Revision: 282265
URL: http://llvm.org/viewvc/llvm-project?rev=282265&view=rev
Log:
Update OptionGroup::SetValue to take StringRef.
Then deal with all the fallout.
Differential Revision: https://reviews.llvm.org/D24847
Modified:
lldb/trunk/i
jingham added a subscriber: jingham.
jingham added a comment.
As long as the only way you can specify the black-list is explicitly on the
command line, I think this is fine. There should never be implicit searches
for a backlist file. You must have to supply it each time you run the
testsuite
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D24847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
fjricci added a comment.
Ok. Barring objections from anyone else, I'll merge this later on today then,
with the understanding that if it causes issues like the ones you describe, it
should be reverted.
https://reviews.llvm.org/D24629
___
lldb-comm
tfiala closed this revision.
tfiala added a comment.
Closing this out as it appears to be resolved one way or another.
Repository:
rL LLVM
https://reviews.llvm.org/D21032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
tfiala closed this revision.
tfiala added a comment.
Closing per comments on this already being checked in.
Repository:
rL LLVM
https://reviews.llvm.org/D21152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
fjricci added a comment.
In https://reviews.llvm.org/D24629#550823, @tfiala wrote:
> > > There is no reasonable thing we can base the expectation as the exact
> > > same device with a different cpu revision could support watchpoints just
> > > fine, so we could just define the list of these tes
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
I am accepting this with one strong reservation which I will explicitly call
out here:
- If somebody checks in changes that are broken, and claims they missed it
because they have an xfail ex
tfiala added a comment.
> > There is no reasonable thing we can base the expectation as the exact same
> > device with a different cpu revision could support watchpoints just fine,
> > so we could just define the list of these tests externally (in this case, I
> > would probably annotate them w
tfiala added a comment.
(I'll close this out as soon as Jim accepts).
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala closed this revision.
tfiala added a comment.
Closed by r282258
https://reviews.llvm.org/D24850
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Fri Sep 23 11:10:01 2016
New Revision: 282258
URL: http://llvm.org/viewvc/llvm-project?rev=282258&view=rev
Log:
add hook for calling platform-dependent pre-kill action on a timed out test
differential review: https://reviews.llvm.org/D24850
reviewers: clayborg, labath
Added
tfiala updated this revision to Diff 72294.
tfiala added a comment.
I'm about to check this in. I just wanted to put up my final change, which
includes the following:
- README.md - documents the new pre_kill_hook package in lldbsuite.
- added a runner_context/context_dict argument to the pre-k
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/test_runner/process_control.py:514
@@ +513,3 @@
+# to it later.
+self.command = command
+
labath wrote:
> Is this actually used anywhere?
No - I originally was parsing some op
brad.king added a comment.
> ensuring that when static .a libraries are build they only introduce cmake
> transitive dependencies to other .a components.
This sounds good from a design level.
As for the implementation, I'm not particularly familiar with
`llvm_add_library` and all its options
labath resigned from this revision.
labath edited reviewers, added: beanz; removed: labath.
labath added a comment.
@beanz, could you look at the llvm side of this?
Repository:
rL LLVM
https://reviews.llvm.org/D24863
___
lldb-commits mailing list
Author: labath
Date: Fri Sep 23 04:11:49 2016
New Revision: 282236
URL: http://llvm.org/viewvc/llvm-project?rev=282236&view=rev
Log:
[gdb-remote] Remove the const char * version of SendPacketAndWaitForResponse
Switch all callers to use the StringRef version.
Modified:
lldb/trunk/source/Plugi
labath accepted this revision.
labath added a comment.
Sounds like a useful thing to have. I've found turning on logging very helpful
when looking for these issues, as it can tell you what was happening in the
past, in addition to the current state (also it allows you to compare the logs
from a
43 matches
Mail list logo
