zturner created this revision.
zturner added a reviewer: jingham.
zturner added subscribers: lldb-commits, LLDB.
This started out when I noticed a potential pitfall in the API of `SetCallback`
where you could potentially get the class into a bad state. Ultimately I
wasn't able to fix that in th
Here is the example I was thinking of:
https://reviews.llvm.org/D24013
It didn't yet get submitted, so you can see the current code by looking at
GDBRemoteCommunicationClient.cpp lines 381-420. The shortened code is in
the above patch. But here they are for reference:
Before:
// Look for a
Author: jmolenda
Date: Mon Sep 12 21:45:45 2016
New Revision: 281291
URL: http://llvm.org/viewvc/llvm-project?rev=281291&view=rev
Log:
Reduce the number of simultaneous debug sessions to 10 and remove
the expectedFlakeyDarwin annotation.
I've been running this test in isolation on my macOS Sierra
The StringRef does in fact store a length. So if you write this:
std::string S("This is a test");
StringRef R(S);
Then R internally contains
const char *Ptr = "This is a test"
size_t Len = 14
This makes repeated operations on StringRefs really fast (and efficient),
because there's no copying in
Author: jingham
Date: Mon Sep 12 20:58:08 2016
New Revision: 281288
URL: http://llvm.org/viewvc/llvm-project?rev=281288&view=rev
Log:
Add a few const's (thanks Zachary) and return shared or unique pointers
in places where they help prevent leaks.
Modified:
lldb/trunk/include/lldb/Breakpoint/B
BTW, I was going over these, and this does not seem to me like a case where you
want to do an early return.
The logic is:
Add some stuff to data
See if I found the UserSource key, if so add some more stuff
Then return data
It would not be clearer to do:
Add some stuff to data
See if I found th
I see the whole content, but I'll reply to this one so the reply doesn't get
truncated on your end...
> On Sep 12, 2016, at 6:03 PM, Zachary Turner wrote:
>
>
> Immediately, very little. A small amount of performance, since comparing
> StringRefs is faster than comparing null terminated stin
>
>
> Immediately, very little. A small amount of performance, since comparing
> StringRefs is faster than comparing null terminated stings, since the
> length is stored with the string it can use memcmp instead of strcmp.
>
> From a big picture perspective, quite a lot IMO. StringRef has numerou
> On Sep 12, 2016, at 4:57 PM, Zachary Turner wrote:
>
>
>
> On Mon, Sep 12, 2016 at 4:19 PM Jim Ingham via lldb-commits
> wrote:
> Author: jingham
> Date: Mon Sep 12 18:10:56 2016
> New Revision: 281273
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281273&view=rev
> Log:
> This is the m
Author: enrico
Date: Mon Sep 12 19:22:49 2016
New Revision: 281282
URL: http://llvm.org/viewvc/llvm-project?rev=281282&view=rev
Log:
Fix an issue where LLDB was not masking enough bits off of objc classes data()
pointers, effectively rendering us unable to generate descriptors for some
classes
Author: tfiala
Date: Mon Sep 12 15:23:13 2016
New Revision: 281251
URL: http://llvm.org/viewvc/llvm-project?rev=281251&view=rev
Log:
xfail TestQueues.py and TestDarwinLogFilterMatchMessage.py
It looks like the message-content-retrieval aspect of DarwinLog
support is flaky, not just the regex matc
edmunoz added a comment.
In https://reviews.llvm.org/D24202#539629, @ki.stfu wrote:
> lgtm
>
> @edmunoz, good job. Thank you! Would you like me to commit?
Thanks! Yes, go ahead.
Repository:
rL LLVM
https://reviews.llvm.org/D24202
___
lldb-comm
Author: tfiala
Date: Mon Sep 12 13:49:22 2016
New Revision: 281243
URL: http://llvm.org/viewvc/llvm-project?rev=281243&view=rev
Log:
fix Xcode build after r281226
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj
Modified: lldb/trunk/tools/debugserver/debugserver.x
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
tfiala added a comment.
This will unfortunately get a little messy due to the code reformatting. My
first patch up for it will be to get the existing impl refreshed for the code
reformatting.
https://reviews.llvm.org/D20835
___
lldb-commits maili
tfiala reclaimed this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Reclaiming. I'll be working on this now.
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
tfiala closed this revision.
tfiala added a comment.
Closing - this was submitted a few weeks ago.
https://reviews.llvm.org/D23747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
This revision is now accepted and ready to land.
Accepting so this can be closed.
https://reviews.llvm.org/D23747
___
lldb-commits mailing list
lldb-commits@list
> On Sep 10, 2016, at 11:26 PM, Zachary Turner via lldb-commits
> wrote:
>
> I don't think requiring user install of six would work, lldb should just work
> out of the box. Renaming it to lldb_six might work.
>
> Also yes using llvm regex everywhere would be wonderful, I honestly have no
>
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:222
@@ -154,1 +221,2 @@
+ return MinidumpExceptionStream::Parse(data);
}
dvlahovski wrote:
> Now that I return an ArrayRef, which is basically a reinterpret
> cast of
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:222
@@ -154,1 +221,2 @@
+ return MinidumpExceptionStream::Parse(data);
}
Now that I return an ArrayRef, which is basically a reinterpret
cast of a piece of memory t
dvlahovski updated this revision to Diff 71026.
dvlahovski marked 17 inline comments as done.
dvlahovski added a comment.
Herald added subscribers: mgorny, srhines, danalbert, tberghammer.
Changes regarding all of the comments.
Removed llvm::Optionals where it was unneeded.
Parsing also the OS fr
Author: labath
Date: Mon Sep 12 11:13:05 2016
New Revision: 281226
URL: http://llvm.org/viewvc/llvm-project?rev=281226&view=rev
Log:
Move StdStringExtractor to tools/debugserver
The class is only used in the debugserver. The rest of lldb has the
StringExtractor class.
Xcode project will need to
> Even if it's length prefixed, the logic here basically just consumes the
entire buffer, which doesn't seem right
Yes, agreed.
On Fri, Sep 9, 2016 at 5:45 PM, Zachary Turner wrote:
> Even if it's length prefixed, the logic here basically just consumes the
> entire buffer, which doesn't seem ri
mgorny added a comment.
In https://reviews.llvm.org/D23883#539611, @ki.stfu wrote:
> You forgot to remove its header file
Thanks for noticing. Fixed now.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
labath added a comment.
@mgorny: The change should be reviewed by an lldb-mi maintainer (i.e.,
@ki.stfu). It helps is you explicitly specify the reviewer, as otherwise the
person may not notice the patch.
In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D
mgorny updated this revision to Diff 70997.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D23883
Files:
tools/lldb-mi/CMakeLists.txt
tools/lldb-mi/MIUtilParse.cpp
tools/lldb-mi/MIUtilParse.h
Index: tools/lldb-mi/MIUtilParse.h
Author: ki.stfu
Date: Mon Sep 12 02:14:51 2016
New Revision: 281199
URL: http://llvm.org/viewvc/llvm-project?rev=281199&view=rev
Log:
Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)
Summary: This patch adds a new test and fixes extra new-line before exit
Reviewers: abidh
Subscribers:
This revision was automatically updated to reflect the committed changes.
ki.stfu marked an inline comment as done.
Closed by commit rL281199: Add MiSyntaxTestCase.test_lldbmi_output_grammar test
(MI) (authored by ki.stfu).
Changed prior to commit:
https://reviews.llvm.org/D9740?vs=70979&id=709
ki.stfu updated this revision to Diff 70979.
ki.stfu marked 6 inline comments as done.
ki.stfu added a comment.
Rebase against ToT; Apply autopep8
https://reviews.llvm.org/D9740
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
tools/lldb-mi/MIDriver.cpp
Index: too
30 matches
Mail list logo
