[Lldb-commits] [lldb] r280328 - There exists at least one compiler on one platform that doesn't know how to assert on a std::shared_ptr<>

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 19:32:53 2016 New Revision: 280328 URL: http://llvm.org/viewvc/llvm-project?rev=280328&view=rev Log: There exists at least one compiler on one platform that doesn't know how to assert on a std::shared_ptr<> Appease it by being very very very explicit about what I

[Lldb-commits] [lldb] r280295 - Add a data formatter for std::function in libcxx

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 16:46:37 2016 New Revision: 280295 URL: http://llvm.org/viewvc/llvm-project?rev=280295&view=rev Log: Add a data formatter for std::function in libcxx Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/fun

[Lldb-commits] [lldb] r280294 - Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 16:46:21 2016 New Revision: 280294 URL: http://llvm.org/viewvc/llvm-project?rev=280294&view=rev Log: Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type Modified: lldb/trunk/packages/Python/lldbsui

Re: [Lldb-commits] [LLDB] Please commit accepted changes.

2016-08-31 Thread Taras Tsugrii via lldb-commits
Cool, thank you Zachary! From: Zachary Turner Date: Wednesday, August 31, 2016 at 1:11 PM To: Taras Tsugrii , via lldb-commits Subject: Re: [Lldb-commits] [LLDB] Please commit accepted changes. These should be in. I committed all the unused variable fixes in one patch, and someone had alread

Re: [Lldb-commits] [LLDB] Please commit accepted changes.

2016-08-31 Thread Zachary Turner via lldb-commits
These should be in. I committed all the unused variable fixes in one patch, and someone had already beaten me to the other one. Feel free to request commit access (see llvm.org website for how to do this) On Wed, Aug 31, 2016 at 10:46 AM Taras Tsugrii wrote: > Awesome, thank you Zachary! > > >

[Lldb-commits] [lldb] r280283 - Remove unused variables.

2016-08-31 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Aug 31 15:03:14 2016 New Revision: 280283 URL: http://llvm.org/viewvc/llvm-project?rev=280283&view=rev Log: Remove unused variables. Patch by Taras Tsugrii Modified: lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp lldb/trunk/source/Plugins/LanguageRuntime/

Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280264: Always rely on CFI unwind info for linux vdso (authored by labath). Changed prior to commit: https://reviews.llvm.org/D24079?vs=69857&id=69883#toc Repository: rL LLVM https://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14 @@ +12,4 @@ + +// Project includes +#include "AuxVector.h" + tberghammer wrote: > Why do we need this? I'm not adding anything. I just took the oppo

[Lldb-commits] [lldb] r280264 - Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 31 12:43:49 2016 New Revision: 280264 URL: http://llvm.org/viewvc/llvm-project?rev=280264&view=rev Log: Always rely on CFI unwind info for linux vdso Summary: The vdso is full of hand-written assembly which the instruction emulator has a hard time understanding. Luck

Re: [Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19 @@ -18,2 +18,3 @@ mydir = TestBase.compute_mydir(__file__) +NO_DEBUG_INFO_TESTCASE = True granata.en

Re: [Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280261: Fixup TestPyObjSynthProvider.py and enable it again (authored by labath). Changed prior to commit: https://reviews.llvm.org/D24074?vs=69836&id=69881#toc Repository: rL LLVM https://reviews.l

Re: [Lldb-commits] [LLDB] Please commit accepted changes.

2016-08-31 Thread Taras Tsugrii via lldb-commits
Awesome, thank you Zachary! From: Zachary Turner Date: Wednesday, August 31, 2016 at 10:43 AM To: Taras Tsugrii , via lldb-commits Subject: Re: [Lldb-commits] [LLDB] Please commit accepted changes. I will commit these today. On Wed, Aug 31, 2016 at 10:41 AM Taras Tsugrii via lldb-commits mai

[Lldb-commits] [lldb] r280261 - Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 31 12:38:17 2016 New Revision: 280261 URL: http://llvm.org/viewvc/llvm-project?rev=280261&view=rev Log: Fixup TestPyObjSynthProvider.py and enable it again Summary: - copies the new file in the cmake build - adds an additional import statement - marks the test as no-d

Re: [Lldb-commits] [LLDB] Please commit accepted changes.

2016-08-31 Thread Zachary Turner via lldb-commits
I will commit these today. On Wed, Aug 31, 2016 at 10:41 AM Taras Tsugrii via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Can someone please commit https://reviews.llvm.org/D23950, > https://reviews.llvm.org/D23951, https://reviews.llvm.org/D23952, > https://reviews.llvm.org/D23948 and h

[Lldb-commits] [LLDB] Please commit accepted changes.

2016-08-31 Thread Taras Tsugrii via lldb-commits
Can someone please commit https://reviews.llvm.org/D23950, https://reviews.llvm.org/D23951, https://reviews.llvm.org/D23952, https://reviews.llvm.org/D23948 and https://reviews.llvm.org/D24064 to lldb repo? All differentials are approved. Thank you, Taras ___

Re: [Lldb-commits] [PATCH] D24078: [zorg] Move lldb-x86_64-ubuntu-14.04-cmake buildbot to the stable category

2016-08-31 Thread Galina via lldb-commits
gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. LGTM. Thanks Galina https://reviews.llvm.org/D24078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14 @@ +12,4 @@ + +// Project includes +#include "AuxVector.h" + ---

Re: [Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19 @@ -18,2 +18,3 @@ mydir = TestBase.compute_mydir(__file__) +N

[Lldb-commits] [lldb] r280253 - Add more unit tests for StringExtractor hex/endian functions.

2016-08-31 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Aug 31 10:50:50 2016 New Revision: 280253 URL: http://llvm.org/viewvc/llvm-project?rev=280253&view=rev Log: Add more unit tests for StringExtractor hex/endian functions. There were a few corner cases that weren't tested for dealing with extraction of an odd number of nib

[Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. The vdso is full of hand-written assembly which the instruction emulator has a hard time understanding. Luckily, the kernel already provid

[Lldb-commits] [PATCH] D24078: [zorg] Move lldb-x86_64-ubuntu-14.04-cmake buildbot to the stable category

2016-08-31 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: gkistanova, chying. labath added subscribers: lldb-commits, zturner. Herald added subscribers: srhines, danalbert, tberghammer. The buildbot has been stable for the past few months and having it send breakage emails will make it much easier to

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

2016-08-31 Thread Zachary Turner via lldb-commits
Yea that would be great, no email is usually a sign that everything is ok, I could have had the changes reverted and/or fixed much earlier had I known On Wed, Aug 31, 2016 at 6:57 AM Pavel Labath wrote: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver > builds linux and va

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

2016-08-31 Thread Pavel Labath via lldb-commits
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver builds linux and various configurations of android. This one is already sending out emails. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake runs local linux test suite. It should be quite stable now, but I was

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

2016-08-31 Thread Zachary Turner via lldb-commits
Thanks, I'll check it out. Are there any plans to make buildbots send emails? It seems less useful when we can't tell when we're breaking something On Wed, Aug 31, 2016 at 6:38 AM Pavel Labath wrote: > StringExtractor ex("0"); > EXPECT_EQ(0x0, ex.GetHexMaxU64(false, 0)); // instead it cra

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

2016-08-31 Thread Pavel Labath via lldb-commits
StringExtractor ex("0"); EXPECT_EQ(0x0, ex.GetHexMaxU64(false, 0)); // instead it crashes On 31 August 2016 at 14:22, Zachary Turner wrote: > Can you post the exact contents of the string causing the crash? I'll add a > unittest for it > > On Wed, Aug 31, 2016 at 1:51 AM Pavel Labath vi

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

2016-08-31 Thread Pavel Labath via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. It is hung because one of your previous changes broke a very fundamental piece of functionality, which makes all tests fail. It is fixed now http://lab.llvm.org:8011/builders/lldb-x8

Re: [Lldb-commits] [lldb] r280204 - Revert r280200 and put it a proper fix

2016-08-31 Thread Pavel Labath via lldb-commits
It's MemoryRegionInfo::SetName(const char *), there's no StringRef version. I wanted to keep the fix minimal, but it turned out to not be enough. On 31 August 2016 at 14:21, Zachary Turner wrote: > SetName accepts a StringRef, why not just SetName(line_extractor.Peek())? > > On Wed, Aug 31, 2016

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

2016-08-31 Thread Zachary Turner via lldb-commits
Can you post the exact contents of the string causing the crash? I'll add a unittest for it On Wed, Aug 31, 2016 at 1:51 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Wed Aug 31 03:43:37 2016 > New Revision: 280207 > > URL: http://llvm.org/viewvc/l

Re: [Lldb-commits] [lldb] r280204 - Revert r280200 and put it a proper fix

2016-08-31 Thread Zachary Turner via lldb-commits
SetName accepts a StringRef, why not just SetName(line_extractor.Peek())? On Wed, Aug 31, 2016 at 12:57 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Wed Aug 31 02:49:37 2016 > New Revision: 280204 > > URL: http://llvm.org/viewvc/llvm-project?rev=2

[Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: granata.enrico. labath added a subscriber: lldb-commits. - copies the new file in the cmake build - adds an additional import statement - marks the test as no-debug-info specific, as it seems to be testing a python feature https://reviews.ll

[Lldb-commits] [lldb] r280208 - XFail new TestPyObjSynthProvider.py on linux until I can investigate the cause of the problem

2016-08-31 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 31 03:43:40 2016 New Revision: 280208 URL: http://llvm.org/viewvc/llvm-project?rev=280208&view=rev Log: XFail new TestPyObjSynthProvider.py on linux until I can investigate the cause of the problem Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalit

[Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

2016-08-31 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 31 03:43:37 2016 New Revision: 280207 URL: http://llvm.org/viewvc/llvm-project?rev=280207&view=rev Log: Revert r280137 and 280139 and subsequent build fixes The rewrite of StringExtractor::GetHexMaxU32 changes functionality in a way which makes lldb-server crash. The

[Lldb-commits] [lldb] r280204 - Revert r280200 and put it a proper fix

2016-08-31 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 31 02:49:37 2016 New Revision: 280204 URL: http://llvm.org/viewvc/llvm-project?rev=280204&view=rev Log: Revert r280200 and put it a proper fix PeekChar returns a character, we want the whole string there. Modified: lldb/trunk/source/Plugins/Process/Linux/NativePr

[Lldb-commits] [lldb] r280202 - Fix lldb build on Mac.

2016-08-31 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 31 02:42:38 2016 New Revision: 280202 URL: http://llvm.org/viewvc/llvm-project?rev=280202&view=rev Log: Fix lldb build on Mac. Summary: https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308 greatly improved an API, but missed one more occ

[Lldb-commits] [lldb] r280200 - Update the Linux code to reflect the changes done by zturner in r280139

2016-08-31 Thread Sylvestre Ledru via lldb-commits
Author: sylvestre Date: Wed Aug 31 02:16:56 2016 New Revision: 280200 URL: http://llvm.org/viewvc/llvm-project?rev=280200&view=rev Log: Update the Linux code to reflect the changes done by zturner in r280139 Modified: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp Modified: l