[Lldb-commits] [lldb] r280039 - Update debugserver project to pull in StdStringExtractor.cpp instead of the new

Author: jmolenda Date: Mon Aug 29 19:58:23 2016 New Revision: 280039 URL: http://llvm.org/viewvc/llvm-project?rev=280039&view=rev Log: Update debugserver project to pull in StdStringExtractor.cpp instead of the new llvm-using StringExtractor.cpp in the xcode project file settings. Modified: l

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner updated this revision to Diff 69635. zturner added a comment. Actually fix the bug this time instead of making worse. https://reviews.llvm.org/D24013 Files: include/lldb/Core/Event.h include/lldb/Core/RegularExpression.h include/lldb/Utility/StringExtractor.h source/Core/Event.c

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1677 @@ -1676,3 +1676,2 @@ { -m_thread_ids.clear(); m_thread_pcs.clear(); Also, was this a bug? I fixed it because it certainly looks like a bug, but if t

[Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner created this revision. zturner added reviewers: labath, tberghammer. zturner added a subscriber: lldb-commits. The motivation here was that operations which were using the `const` version of this function might as well be using `Peek()`, since it does essentially the same thing. And sin

[Lldb-commits] [lldb] r280000 - Convert GetNameColonValue to return StringRefs.

Author: zturner Date: Mon Aug 29 14:58:14 2016 New Revision: 28 URL: http://llvm.org/viewvc/llvm-project?rev=28&view=rev Log: Convert GetNameColonValue to return StringRefs. StringExtractor::GetNameColonValue() looks for a substring of the form ":" and returns and to the caller. This re

[Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

Author: zturner Date: Mon Aug 29 14:45:59 2016 New Revision: 279997 URL: http://llvm.org/viewvc/llvm-project?rev=279997&view=rev Log: Copy StringExtractor to StdStringExtractor. I have some improvements to make to StringExtractor that require using LLVM. debugserver can't take a dependency on LL

[Lldb-commits] [lldb] r279994 - Remove std::atomic from lldb::Address.

Author: zturner Date: Mon Aug 29 14:30:26 2016 New Revision: 279994 URL: http://llvm.org/viewvc/llvm-project?rev=279994&view=rev Log: Remove std::atomic from lldb::Address. std::atomic requires 64-bit alignment in order to guarantee atomicity. Normally the compiler is pretty good about aligning

Re: [Lldb-commits] [PATCH] D23952: Remove unused frame_zero_id local variable

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for finding that. https://reviews.llvm.org/D23952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [Lldb-commits] [PATCH] D23951: Remove unused any_found local variable

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [Lldb-commits] [PATCH] D23950: Remove unused local variable

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Looks good to me https://reviews.llvm.org/D23950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

emaste added a subscriber: emaste. emaste added a comment. - in the future can you please upload with context (e.g. git diff -U) - I think the OS names in utilsOsType.py are kept sorted and the actual enum values are not part of an ABI https://reviews.llvm.org/D23977

Re: [Lldb-commits] [PATCH] D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm if tests are passed https://reviews.llvm.org/D23882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi