That sounds fine. Feel free to give it a shot. I can have a look in the
morning if it's broken again. I assumed initially that it was
over-aggressive search and replace so I didn't bother to look at the
details.
On Tuesday, August 9, 2016, Zachary Turner wrote:
> Hmm, the common Makefile.rules c
Hmm, the common Makefile.rules configures it to be a force include from the
command line. It's possible this isn't being done with gcc or some other
compiler. I suppose I can change test_common.h to #define
__PRETTY_FUNCTION__ __FUNCSIG__ on windows which would also fix those tests.
On Tue, Aug
Maybe those tests aren't including test_common.h? Dunno.
On Tue, Aug 9, 2016 at 8:25 PM, Todd Fiala wrote:
> No, sorry, it does not.
>
> Each of those got undefined macro errors on macOS.
>
> -Todd
>
> On Tue, Aug 9, 2016 at 7:18 PM, Zachary Turner wrote:
>
>> This will make the tests start fa
No, sorry, it does not.
Each of those got undefined macro errors on macOS.
-Todd
On Tue, Aug 9, 2016 at 7:18 PM, Zachary Turner wrote:
> This will make the tests start failing again on Windows. I #defined these
> in test_common.h, it should work. Does it not?
>
> On Tue, Aug 9, 2016 at 6:45 PM
This will make the tests start failing again on Windows. I #defined these
in test_common.h, it should work. Does it not?
On Tue, Aug 9, 2016 at 6:45 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Tue Aug 9 20:37:27 2016
> New Revision: 278197
>
> URL
My mistake -- I should have updated the *.pbxproj file with r278142.
Thanks for fixing this Enrico!
vedant
> On Aug 9, 2016, at 1:32 PM, Enrico Granata via lldb-commits
> wrote:
>
> Author: enrico
> Date: Tue Aug 9 15:32:42 2016
> New Revision: 278158
>
> URL: http://llvm.org/viewvc/llvm-pr
Author: tfiala
Date: Tue Aug 9 20:37:27 2016
New Revision: 278197
URL: http://llvm.org/viewvc/llvm-project?rev=278197&view=rev
Log:
Undid LLVM macro usage in test suite test subject files.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp
lldb/t
Author: tfiala
Date: Tue Aug 9 19:53:21 2016
New Revision: 278190
URL: http://llvm.org/viewvc/llvm-project?rev=278190&view=rev
Log:
Undo usage of LLVM macros in debugserver
We don't take a dependency on LLVM in debugserver.
This was failing to compile before.
Modified:
lldb/trunk/tools/debu
Author: jingham
Date: Tue Aug 9 19:45:58 2016
New Revision: 278188
URL: http://llvm.org/viewvc/llvm-project?rev=278188&view=rev
Log:
Add a newline to the end of the file to remove the clang warnings.
Modified:
lldb/trunk/include/lldb/Host/PosixApi.h
Modified: lldb/trunk/include/lldb/Host/Po
Author: zturner
Date: Tue Aug 9 19:02:58 2016
New Revision: 278182
URL: http://llvm.org/viewvc/llvm-project?rev=278182&view=rev
Log:
Fix build on android and Linux.
gettimeofday() isn't defined without a special header. Rather
than rely on C apis, let's just use modern C++11 to do this
portably
Author: zturner
Date: Tue Aug 9 18:06:08 2016
New Revision: 278177
URL: http://llvm.org/viewvc/llvm-project?rev=278177&view=rev
Log:
Delete Host/windows/win32.h
It's always hard to remember when to include this file, and
when you do include it it's hard to remember what preprocessor
check it nee
Author: enrico
Date: Tue Aug 9 16:16:58 2016
New Revision: 278166
URL: http://llvm.org/viewvc/llvm-project?rev=278166&view=rev
Log:
Adjust LLDB's iOS simulator interface for changes in CoreSimulator
rdar://27732333 and rdar://27732377
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/Pla
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for the changes and the documentation.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
___
lldb-commits mailing lis
Author: enrico
Date: Tue Aug 9 15:32:42 2016
New Revision: 278158
URL: http://llvm.org/viewvc/llvm-project?rev=278158&view=rev
Log:
Remove CFData from the xcodeproj as well
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj
Modified: lldb/trunk/tools/debugserver/de
omjavaid added inline comments.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:304
@@ +303,3 @@
+ $(subst $(3),$(1),$(2)), \
+ $(if $(findstring ar,$(1)), \
+$(if $(findstring gcc,$(3)), \
jafl updated this revision to Diff 67405.
jafl added a comment.
Incorporate additional feedback from Greg Clayton.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
Files:
include/lldb/API/SBAddress.h
Index: include/lldb/API/SBAddress.h
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278142: [debugserver] Delete CFData.{h,cpp}, since they
appear to be dead (NFCI) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D23070?vs=66499&id=67373#toc
Repository:
rL L
Author: vedantk
Date: Tue Aug 9 12:42:11 2016
New Revision: 278142
URL: http://llvm.org/viewvc/llvm-project?rev=278142&view=rev
Log:
[debugserver] Delete CFData.{h,cpp}, since they appear to be dead (NFCI)
Differential Revision: https://reviews.llvm.org/D23070
Removed:
lldb/trunk/tools/debu
clayborg added a comment.
Let me know how things look on Mac. Our lock primitives are not as fast as
linux. If all looks good on Mac speed wise, we should be good to go.
https://reviews.llvm.org/D22914
___
lldb-commits mailing list
lldb-commits@lis
labath added a comment.
These are the results before and after applying this change (on linux):
Before:
(lldb) process plugin packet speed-test
Testing sending 1000 packets of various sizes:
qSpeedTest(send=0 , recv=0 ) in 0.057456000 sec for 17404.62
packets/sec ( 0.057456 ms
I patched it in this morning, but it doesn't compile on Windows. I was
able to make it work with a few tweaks at the top of SelectHelper.cpp:
// C Includes
#include
#if defined(_WIN32)
#define NOMINMAX
#include
#else
#include
#endif
The key bits: don't include on Windows and #define NOMINMA
labath abandoned this revision.
labath added a comment.
Ok, thanks for the explanation. It'll take some time for me to parse all the
information there, but this is not a priority for us now. Maybe I'll come back
to this later, but I'm fine with leaving it like this for now.
https://reviews.llv
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This will break a several use cases we are relying on. More details inline.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:288
@@ -289,3 +287,3 @@
#
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I agree with Tamas that this should somehow be handled in a different way. llvm
already installs a bunch of cmake files. I think we should figure out a way to
get the things we need
24 matches
Mail list logo
