Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

2016-08-02 Thread Ilia K via lldb-commits
ki.stfu added a comment. Yes, that's what I said. We have to throw an error if location is not passed (even if -f is specified). Repository: rL LLVM https://reviews.llvm.org/D23026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

2016-08-02 Thread Ilia K via lldb-commits
Hi Hans! The author of this commit asks me is there a chance to include this changes to 3.9 release? I'm not sure about our policy when RC has already been tagged. On Fri, Jul 29, 2016 at 9:01 AM, Ilia K via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: ki.stfu > Date: Fri Jul 29

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

2016-08-02 Thread Ed Maste via lldb-commits
emaste added a comment. > This is a particular problem on OS X because we support debugging with the > debug info in .o files, so for a complex project we could be opening lots of > those files. If you don't do that, then it's more like number of shared > libraries a normal program will open. T

[Lldb-commits] [lldb] r277495 - [Concepts] Add TODO and requires-clause placeholder; NFC

2016-08-02 Thread Hubert Tong via lldb-commits
Author: hubert.reinterpretcast Date: Tue Aug 2 13:36:15 2016 New Revision: 277495 URL: http://llvm.org/viewvc/llvm-project?rev=277495&view=rev Log: [Concepts] Add TODO and requires-clause placeholder; NFC Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Sym

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

2016-08-02 Thread Pierson Lee via lldb-commits
pieandcakes added a comment. Hi Ilia, Thanks for the review. There is another change I do need to make in the Execute() method and probably add some tests. I reviewed this spec for G

[Lldb-commits] [PATCH] D23070: [debugserver] Delete CFData.{h, cpp}, since they appear to be dead (NFCI)

2016-08-02 Thread Vedant Kumar via lldb-commits
vsk created this revision. vsk added reviewers: clayborg, labath. vsk added a subscriber: lldb-commits. https://reviews.llvm.org/D23070 Files: tools/debugserver/source/MacOSX/CFData.cpp tools/debugserver/source/MacOSX/CFData.h tools/debugserver/source/MacOSX/CMakeLists.txt tools/debugserv

Re: [Lldb-commits] FW: [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

2016-08-02 Thread Hans Wennborg via lldb-commits
While this all seems very MIPS-specific, so probably fine to merge if you want to, it does look more like new development than just bug fixing. I'm OK with merging this if Clayton approves, though. Thanks, Hans On Tue, Aug 2, 2016 at 12:49 AM, Nitesh Jain wrote: > Hi Hans, > > Could you please

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

2016-08-02 Thread Hans Wennborg via lldb-commits
Looks like a pretty big change to merge at this stage. I'll let Clayton decide. Thanks, Hans On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote: > Hi Hans, > > Could you please add this to the LLDB 3.9 release branch ? > > Thanks & regards, > Nitesh Jain > > > -Original Message- > From:

Re: [Lldb-commits] [PATCH] D22902: Fix -break-insert not working when using absolute paths

2016-08-02 Thread Marc-Andre Laperle via lldb-commits
malaperle added a comment. Would it be possible to apply this fix to the release_39 branch? Repository: rL LLVM https://reviews.llvm.org/D22902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] r277453 - Revert rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY

2016-08-02 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Tue Aug 2 08:17:49 2016 New Revision: 277453 URL: http://llvm.org/viewvc/llvm-project?rev=277453&view=rev Log: Revert rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY This commit is causing problems on gcc-* compiler with version number sufix. Req

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-08-02 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277443: Support for OCaml native debugging (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D22132?vs=64473&id=66456#toc Repository: rL LLVM https://reviews.llvm.org/D221

[Lldb-commits] [lldb] r277443 - Support for OCaml native debugging

2016-08-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Aug 2 06:15:55 2016 New Revision: 277443 URL: http://llvm.org/viewvc/llvm-project?rev=277443&view=rev Log: Support for OCaml native debugging This introduces basic support for debugging OCaml binaries. Use of the native compiler with DWARF emission support (see http

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-08-02 Thread Elias Boutaleb via lldb-commits
ebtaleb added a comment. In https://reviews.llvm.org/D22132#502204, @tberghammer wrote: > Do you want me to commit it in for you? Sure, if you don't mind. Thank you. https://reviews.llvm.org/D22132 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-02 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D20386?vs=66258&id=66438#toc Repository: rL LLVM htt

[Lldb-commits] [lldb] r277429 - Correct makefile.rules to use toolchain specific AR and OBJCOPY

2016-08-02 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Tue Aug 2 02:56:11 2016 New Revision: 277429 URL: http://llvm.org/viewvc/llvm-project?rev=277429&view=rev Log: Correct makefile.rules to use toolchain specific AR and OBJCOPY Differential revision: https://reviews.llvm.org/D20386 Modified: lldb/trunk/packages/Python/

Re: [Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-08-02 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. committed in revision https://reviews.llvm.org/rL277426, https://reviews.llvm.org/D22851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] r277426 - [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-08-02 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Tue Aug 2 02:18:07 2016 New Revision: 277426 URL: http://llvm.org/viewvc/llvm-project?rev=277426&view=rev Log: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions Reviewers: clayborg, jaydeep, bhushan