Re: [Lldb-commits] [PATCH] D22902: Fix -break-insert not working when using absolute paths

2016-07-27 Thread Ilia K via lldb-commits
ki.stfu added a comment. Could you add a test case for this in packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py? https://reviews.llvm.org/D22902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] Fix -break-insert not working when using absolute paths

2016-07-27 Thread Marc-Andre Laperle via lldb-commits
When trying to parse the -break-insert arguments as a named location, the string parsing was not configured to allow directory paths. This patch adds a constructor to allow the parsing of string as directory path along with the other parameters. This fixes https://llvm.org/bugs/show_bug.cgi?id=287

[Lldb-commits] Fix -break-insert not working when using absolute paths

2016-07-27 Thread Marc-Andre Laperle via lldb-commits
When trying to parse the -break-insert arguments as a named location, the string parsing was not configured to allow directory paths. This patch adds a constructor to allow the parsing of string as directory path along with the other parameters. This fixes https://llvm.org/bugs/show_bug.cgi?id=287

[Lldb-commits] [lldb] r276954 - Add some logging to the kernel dynamicloader plugin when we fail to read

2016-07-27 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jul 27 23:18:44 2016 New Revision: 276954 URL: http://llvm.org/viewvc/llvm-project?rev=276954&view=rev Log: Add some logging to the kernel dynamicloader plugin when we fail to read a kext binary from memory. Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwi

Re: [Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-07-27 Thread Bhushan Attarde via lldb-commits
bhushan accepted this revision. bhushan added a comment. LGTM https://reviews.llvm.org/D22851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22891: Remove a duplicated block in cmake.

2016-07-27 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Yeah, that looks like a merge issue of some sort. https://reviews.llvm.org/D22891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D22891: Remove a duplicated block in cmake.

2016-07-27 Thread Stephane Sezer via lldb-commits
sas created this revision. sas added a reviewer: tfiala. sas added a subscriber: lldb-commits. This is supposed to find the python lib dir and seems like it's just been copied twice by mistake. https://reviews.llvm.org/D22891 Files: source/Host/CMakeLists.txt Index: source/Host/CMakeLists.txt

Re: [Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

2016-07-27 Thread Jim Ingham via lldb-commits
> On Jul 27, 2016, at 10:08 AM, Pavel Labath wrote: > > On 27 July 2016 at 17:41, Jim Ingham wrote: >> If you go to halt a thread whose private state is running, and by the time >> you get to halting it the private state has gone from running to stopped >> then the code doing the halt will de

Re: [Lldb-commits] [PATCH] D22863: Improve code of loading plugins that provide cmnds

2016-07-27 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Everything Greg said makes total sense In general dynamically loadable C++ plugins as a feature is a little rough around the edges. I am glad to see interest in improving it! https://reviews.llvm.org/D22863 ___ lldb

[Lldb-commits] [lldb] r276914 - Fixed "void SBWatchpoint::SetEnabled (bool enabled)" to work properly and added a test for it.

2016-07-27 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Jul 27 15:47:49 2016 New Revision: 276914 URL: http://llvm.org/viewvc/llvm-project?rev=276914&view=rev Log: Fixed "void SBWatchpoint::SetEnabled (bool enabled)" to work properly and added a test for it. https://llvm.org/bugs/show_bug.cgi?id=28729 Modified: lldb

Re: [Lldb-commits] [PATCH] D22863: Improve code of loading plugins that provide cmnds

2016-07-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You can't change the exiting public API (anything in include/lldb/API/*). If you want to a add a new function, you must add a new version with the new argument, but leave the old

Re: [Lldb-commits] [PATCH] D22629: Rewrite gdb-remote's SendContinuePacketAndWaitForResponse

2016-07-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This provides a clearer implementation of our async code that grew over the years and was bolted on, thanks for digging into this. Looks good a few changes, see inlined comments.

Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

2016-07-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few modifications to the SBAddress info Comment at: include/lldb/API/SBAddress.h:32 @@ +31,3 @@ +/// target. +/// +/// The individual Get*() functions grab ind

Re: [Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

2016-07-27 Thread Pavel Labath via lldb-commits
On 27 July 2016 at 17:41, Jim Ingham wrote: > If you go to halt a thread whose private state is running, and by the time > you get to halting it the private state has gone from running to stopped then > the code doing the halt will declare victory, since that's what it was trying > to do. If i

Re: [Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

2016-07-27 Thread Jim Ingham via lldb-commits
If you go to halt a thread whose private state is running, and by the time you get to halting it the private state has gone from running to stopped then the code doing the halt will declare victory, since that's what it was trying to do. If it was still running, then it will have to interrupt.

Re: [Lldb-commits] Buildbot numbers for the week of 7/10/2016 - 7/16/2016

2016-07-27 Thread Aaron Ballman via lldb-commits
On Tue, Jul 26, 2016 at 8:14 PM, Galina Kistanova via cfe-commits wrote: > Hello everyone, > > Below are some buildbot numbers for the week of 7/10/2016 - 7/16/2016. > > Please see the same data in attached csv files: > > The longest time each builder was red during the week; > "Status change rati

Re: [Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

2016-07-27 Thread Pavel Labath via lldb-commits
This fix is going to be flaky: Since the private state can flip back and forth between running and stopped and there's no sychronization between the private state thread and this code, you're going to get unpredictable behavior depending on the exact moment you call Destroy(). I assume the other t

[Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-07-27 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, bhushan, clayborg. nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits, sdardis. Herald added a subscriber: dsanders. To handle the immediate size greater than 2^16 - 1 , the clang compiler generate LUI, (D)