[Lldb-commits] [lldb] r276729 - Add support for an additional dictionary in the per-arch plists

2016-07-25 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jul 26 01:33:07 2016 New Revision: 276729 URL: http://llvm.org/viewvc/llvm-project?rev=276729&view=rev Log: Add support for an additional dictionary in the per-arch plists that may be embedded in the Contents/Resources subdir of a dSYM bundle. These allow for the specif

[Lldb-commits] [lldb] r276721 - DynamicLoaderDarwinKernel will look in four addresses for the kernel

2016-07-25 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jul 25 22:10:15 2016 New Revision: 276721 URL: http://llvm.org/viewvc/llvm-project?rev=276721&view=rev Log: DynamicLoaderDarwinKernel will look in four addresses for the kernel load address on 64-bit devices; it only needs to look in three. Modified: lldb/trunk/

[Lldb-commits] [lldb] r276709 - Print a warning if the directory passed to --test-subdir doesn't end up existing

2016-07-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Jul 25 18:26:24 2016 New Revision: 276709 URL: http://llvm.org/viewvc/llvm-project?rev=276709&view=rev Log: Print a warning if the directory passed to --test-subdir doesn't end up existing Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py Modified: lldb/t

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-25 Thread Justin Lebar via lldb-commits
jlebar added a comment. In https://reviews.llvm.org/D22463#495211, @vladisld wrote: > In https://reviews.llvm.org/D22463#494828, @jlebar wrote: > > > I think the general feeling is that most of us (myself included) would > > rather not learn a new tool if there's a simpler >alternative, such as

Re: [Lldb-commits] [PATCH] D21328: [lldb] Fixed incorrect endianness when evaluating certain expressions

2016-07-25 Thread Cameron via lldb-commits
cameron314 added a comment. Hmm, I don't think this is easily testable at all. We happened to see it on our (out-of-tree) big-endian architecture when debugging remotely on Windows, but only for variables backed by registers. I was thus able to trace the problem back to this code, fix it, and v

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-07-25 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D22132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-25 Thread Daniel Berlin via lldb-commits
On Mon, Jul 25, 2016 at 1:03 PM, Vlad Dovlekaev via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > vladisld added a comment. > > In https://reviews.llvm.org/D22463#494828, @jlebar wrote: > > > I think the general feeling is that most of us (myself included) would > rather not learn a new too

[Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

2016-07-25 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added reviewers: labath, Eugene.Zelenko. omjavaid added a subscriber: lldb-commits. Herald added a subscriber: aemerson. This patch allows correct selection of CMAKE_LIBRARY_ARCHITECTURE instead of previously hard-coded value. All cross builds for 64bit t

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-25 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few comments: - we need the DWARF opcode length in RegisterInfo, but not in the structured data (XML or JSON) - all macros that initialize RegisterInfo structs must be expended

Re: [Lldb-commits] [PATCH] D21328: [lldb] Fixed incorrect endianness when evaluating certain expressions

2016-07-25 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. This looks fine. How tricky would it be to make a test case for a reproduction scenario? https://reviews.llvm.org/D21328 ___ lldb-com

Re: [Lldb-commits] [PATCH] D22755: Fix DataExtractor::PeekData for zero length peeks

2016-07-25 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D22755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

2016-07-25 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D22756 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-25 Thread Chris Bieneman via lldb-commits
beanz added a subscriber: beanz. beanz added a comment. @rengolin, thank you for putting this all together. It is very well thought out, and I really like the shape it took. I have a few minor nitpick comments inline. Thanks, -Chris Comment at: docs/Proposals/GitHub.rst:58 @@

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-25 Thread Justin Lebar via lldb-commits
jlebar added a comment. In https://reviews.llvm.org/D22463#494568, @vladisld wrote: > Have the alternatives to sub-modules and monolithic repository been discussed > ? Hi, Vlad. Please see the ongoing thread in llvm-dev, entitled "[RFC] One or many git repositories?". Tools such as git-repo

Re: [Lldb-commits] [PATCH] D22628: Fixing layout of elf-core file related structures

2016-07-25 Thread Pavel Labath via lldb-commits
labath closed this revision. labath added a comment. Submitted in r276406. https://reviews.llvm.org/D22628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-25 Thread Ed Maste via lldb-commits
emaste added a comment. Is this ready to be committed? https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

2016-07-25 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. We were checking whether an attribute is in block form by getting the block data pointer, which was not correct as the pointer be null even if the attribute is in block form. Other places in

[Lldb-commits] [PATCH] D22755: Fix DataExtractor::PeekData for zero length peeks

2016-07-25 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. The function was returning the null pointer for peeks of size zero, which seems like a sensible thing to do, but is actually pretty easy to get bitten by that if you are extracting a variabl