Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-17 Thread Saleem Abdulrasool via lldb-commits
compnerd closed this revision. compnerd added a comment. SVN r269877 http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-17 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. Ah, I just ran git-clang-format, and that found a few additional things. Incorporated that; Ill commit this tonight and hopefully have the second pass done soon. http://reviews.llvm.org/D20278 ___ lldb-commits mailing li

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-17 Thread Zachary Turner via lldb-commits
zturner added a comment. This looks good, no probelms on Windows that I can see. I ran clang-format on your patch just to confirm, and it fixed up some trailing whitespace at the end of lines. I'm not sure if the problem was in the generation of the patch on your end, the application of the p

[Lldb-commits] [PATCH] D20344: [LLDB] Fix standalone LLDB build when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON

2016-05-17 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: labath, krytarowski, zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Patch also includes fix for CMake 2.8.12.2, see D18018. Repository: rL LLVM http:

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

2016-05-17 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Obsoleted by http://reviews.llvm.org/D20344. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [lldb] r269860 - xfail TestWatchLocation.py for arm-linux targets

2016-05-17 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Tue May 17 18:01:56 2016 New Revision: 269860 URL: http://llvm.org/viewvc/llvm-project?rev=269860&view=rev Log: xfail TestWatchLocation.py for arm-linux targets TestWatchLocation.py fails on arm-linux target due to unicode error in lldb testsuite. This is a known issue and

Re: [Lldb-commits] [PATCH] D20306: Allow custom formatting of session log file names

2016-05-17 Thread Zachary Turner via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269793: Allow custom formatting of session log file names. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D20306?vs=57409&id=57502#toc Repository: rL LLVM http://reviews.llv

[Lldb-commits] [lldb] r269793 - Allow custom formatting of session log file names.

2016-05-17 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue May 17 13:02:34 2016 New Revision: 269793 URL: http://llvm.org/viewvc/llvm-project?rev=269793&view=rev Log: Allow custom formatting of session log file names. Differential Revision: http://reviews.llvm.org/D20306 Modified: lldb/trunk/packages/Python/lldbsuite/test/c

Re: [Lldb-commits] [PATCH] D20306: Allow custom formatting of session log file names

2016-05-17 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. (Changing to Accept - although please have a look at the comments from Pavel and me). http://reviews.llvm.org/D20306 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

[Lldb-commits] [lldb] r269759 - xfail TestTopLevelExprs for Android API 21-22 (llvm.org/pr27787)

2016-05-17 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue May 17 07:42:25 2016 New Revision: 269759 URL: http://llvm.org/viewvc/llvm-project?rev=269759&view=rev Log: xfail TestTopLevelExprs for Android API 21-22 (llvm.org/pr27787) Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopL

Re: [Lldb-commits] [PATCH] D20306: Allow custom formatting of session log file names

2016-05-17 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I agree with Todd that we should have a long option for this, as short ones tend to be cryptic. If we don't anticipate using this often (I don't), we could even drop the short option altogethe