Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-15 Thread Zachary Turner via lldb-commits
Figured as much, just making sure. What platforms did you run the test suite on to confirm no breakages? On Sun, May 15, 2016 at 8:11 PM Saleem Abdulrasool wrote: > compnerd added a comment. > > I don't think I can write code without clang-format anymore (so, yes, it > is clang-formatted). > >

[Lldb-commits] [lldb] r269627 - test: add missing splat

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 22:13:08 2016 New Revision: 269627 URL: http://llvm.org/viewvc/llvm-project?rev=269627&view=rev Log: test: add missing splat The parameter here is a list, not a string. Ensure that the we splat the list into arguments prior to invoke os.path.join. This would pr

[Lldb-commits] [lldb] r269628 - test: remove use of undefined variables

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 22:13:12 2016 New Revision: 269628 URL: http://llvm.org/viewvc/llvm-project?rev=269628&view=rev Log: test: remove use of undefined variables The variables referenced in the print message are not defined. Simply state that the requisite script is not found. Corr

[Lldb-commits] [lldb] r269626 - test: add missing parameter

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 22:13:05 2016 New Revision: 269626 URL: http://llvm.org/viewvc/llvm-project?rev=269626&view=rev Log: test: add missing parameter Add the missing required parameter to the function. This permits tests to get a bit further before failing. Modified: lldb/trunk

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. I don't think I can write code without clang-format anymore (so, yes, it is clang-formatted). http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-15 Thread Zachary Turner via lldb-commits
Personally I'm strongly in favor of standardizing on builtin language constructs. We already use std mutex in some places, and llvm does too, so i see no issue with compiler support. I can't review the patch at the moment, but please do make sure it's clang formatted On Sun, May 15, 2016 at 6:10 P

[Lldb-commits] [lldb] r269599 - Symbol: fix -Wcovered-switch warning

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 13:18:16 2016 New Revision: 269599 URL: http://llvm.org/viewvc/llvm-project?rev=269599&view=rev Log: Symbol: fix -Wcovered-switch warning Add the Float128 type to the enumeration. Float128 is covered under IEEE754 as a quad precision floating point value. Modif

[Lldb-commits] [lldb] r269598 - Fix a few -Wformat-pedantic warnings

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 13:18:13 2016 New Revision: 269598 URL: http://llvm.org/viewvc/llvm-project?rev=269598&view=rev Log: Fix a few -Wformat-pedantic warnings Clean up some newly introduced -Wformat-pedantic warnings (%p expects a void *). Modified: lldb/trunk/source/Core/Listen