Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. I think we can limit the tests to skip unless clang of a certain version, which will probably take care of it. I'll see if I can get the right decorator incantation for this. (It's a bit complicated by the fact that official Apple clang releases show up as the much lar

[Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl created this revision. aprantl added reviewers: granata.enrico, tfiala. aprantl added a subscriber: lldb-commits. This is a work-in-progress patch for adding a "-gmodules" category to the testsuite. It adds clang module debugging as a configuration alongside .dSYM and DWO to ensure that

[Lldb-commits] [lldb] r268686 - Revert r268591

Author: enrico Date: Thu May 5 16:10:28 2016 New Revision: 268686 URL: http://llvm.org/viewvc/llvm-project?rev=268686&view=rev Log: Revert r268591 "Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery This is not meant to report that a value doesn't ha

[Lldb-commits] [PATCH] D19991: [LLDB] Fix standalone build on RHEL6

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: zturner, labath. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. There were unresolved symbols related to coverage. Repository: rL LLVM http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D19983: Fix TestEvents.py on OS X

tfiala closed this revision. tfiala added a comment. Closed by commit r268653 http://reviews.llvm.org/D19983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r268653 - Fix TestEvents.py on OS X

Author: tfiala Date: Thu May 5 12:48:14 2016 New Revision: 268653 URL: http://llvm.org/viewvc/llvm-project?rev=268653&view=rev Log: Fix TestEvents.py on OS X This change addresses a hang/segfault in TestEvents.py. The threads that run the listener loops now do an SBListener.Clear() before they w

Re: [Lldb-commits] [PATCH] D19983: Fix TestEvents.py on OS X

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I agree, doing something to get the test working is primary. Then we can go back and figure out why the less ordered shutdown doesn't work. http://reviews.llvm.org/D19983 __

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

tfiala added a comment. > In any case, the sample tool was helpful in tracking this down, so thanks for > that. :) Hey great! Glad you were able to track that down! http://reviews.llvm.org/D19214 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19983: Fix TestEvents.py on OS X

tfiala updated this revision to Diff 56303. tfiala added a comment. Added full diff context to diff. http://reviews.llvm.org/D19983 Files: packages/Python/lldbsuite/test/python_api/event/TestEvents.py Index: packages/Python/lldbsuite/test/python_api/event/TestEvents.py ==

[Lldb-commits] [PATCH] D19983: Fix TestEvents.py on OS X

tfiala created this revision. tfiala added a reviewer: jingham. tfiala added a subscriber: lldb-commits. This change addresses a hang/segfault in TestEvents.py. The threads that run the listener loops now do an SBListener.Clear() before they wrap up their work. This prevents the test from tryi

[Lldb-commits] [lldb] r268638 - fix argument usage for '-#' command line option

Author: tfiala Date: Thu May 5 11:01:15 2016 New Revision: 268638 URL: http://llvm.org/viewvc/llvm-project?rev=268638&view=rev Log: fix argument usage for '-#' command line option This was broken in the grand configuration change. Now using -# works again. Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r268626 - Guard AddCXXSynthetic with LLDB_DISABLE_PYTHON

Author: tberghammer Date: Thu May 5 07:46:45 2016 New Revision: 268626 URL: http://llvm.org/viewvc/llvm-project?rev=268626&view=rev Log: Guard AddCXXSynthetic with LLDB_DISABLE_PYTHON The function only avaibleble when python is enabled. Guard the new call in the Java plugin with LLDB_DISABLE_PYT

[Lldb-commits] [lldb] r268623 - Bump up timeout in AdbClient

Author: labath Date: Thu May 5 06:25:57 2016 New Revision: 268623 URL: http://llvm.org/viewvc/llvm-project?rev=268623&view=rev Log: Bump up timeout in AdbClient now that the timeout actually means something, we see that sometimes adb is just really slow in replying to the DONE packet during fil

Re: [Lldb-commits] [PATCH] D19540: Add support for displaying Java array types on Andorid

This revision was automatically updated to reflect the committed changes. Closed by commit rL268622: Add support for displaying Java array types on Andorid (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D19540?vs=55031&id=56263#toc Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r268622 - Add support for displaying Java array types on Andorid

Author: tberghammer Date: Thu May 5 06:18:21 2016 New Revision: 268622 URL: http://llvm.org/viewvc/llvm-project?rev=268622&view=rev Log: Add support for displaying Java array types on Andorid Differential revision: http://reviews.llvm.org/D19540 Modified: lldb/trunk/include/lldb/Symbol/Java

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

labath added a comment. In http://reviews.llvm.org/D19214#405310, @tfiala wrote: > If you're in a position where you can grab a sample (using the OS X sample > tool) on the bot when they're "hanging", we can try to find out where they > are at. > > The reason I *think* they're not in a method i

Re: [Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

labath added a comment. Ok, I've put it into AdbClient for now. We can revisit it if we see a second user somewhere... Repository: rL LLVM http://reviews.llvm.org/D19533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath added a reviewer: clayborg. labath added a comment. This has been sitting in the queue for a long time. Greg, could you take a look? http://reviews.llvm.org/D17856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath updated this revision to Diff 56252. labath added a comment. Rebase on ToT. http://reviews.llvm.org/D17856 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py packages/Python/lldbsuite/test/lang/cpp/global

[Lldb-commits] [lldb] r268619 - Downgrade skip to xfail in TestBitfields on linux

Author: labath Date: Thu May 5 04:03:22 2016 New Revision: 268619 URL: http://llvm.org/viewvc/llvm-project?rev=268619&view=rev Log: Downgrade skip to xfail in TestBitfields on linux the test should no longer crash, but we need to investigate why ToT clang still generates debug info we don't und

Re: [Lldb-commits] [PATCH] D19916: Fix EOF handling in AdbClient (take 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268617: Fix EOF handling in AdbClient (take 2) (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19916?vs=56134&id=56246#toc Repository: rL LLVM http://reviews.llvm.org/D19916

[Lldb-commits] [lldb] r268617 - Fix EOF handling in AdbClient (take 2)

Author: labath Date: Thu May 5 03:42:17 2016 New Revision: 268617 URL: http://llvm.org/viewvc/llvm-project?rev=268617&view=rev Log: Fix EOF handling in AdbClient (take 2) Summary: AdbClient would spin in a loop in ReadAllBytes in case the remote end was closed before reading the requested numbe

[Lldb-commits] [lldb] r268616 - Fix syntax errors in TestEnumTypes

Author: labath Date: Thu May 5 03:33:56 2016 New Revision: 268616 URL: http://llvm.org/viewvc/llvm-project?rev=268616&view=rev Log: Fix syntax errors in TestEnumTypes Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTypes.py Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r268615 - Fix DW_AT_specification handling in DWO files

Author: labath Date: Thu May 5 03:21:44 2016 New Revision: 268615 URL: http://llvm.org/viewvc/llvm-project?rev=268615&view=rev Log: Fix DW_AT_specification handling in DWO files Summary: We were trying to get a DWARFDIE from a CompileUnit belonging to a DWO file. However, this function does not

Re: [Lldb-commits] [PATCH] D19927: Fix DW_AT_specification handling in DWO files

This revision was automatically updated to reflect the committed changes. Closed by commit rL268615: Fix DW_AT_specification handling in DWO files (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19927?vs=56168&id=56245#toc Repository: rL LLVM http://reviews.llvm.org/