Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-02 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. The few lines above are for the x86, x86_64 targets, which traditionally use the pc vendor as a legacy label. http://reviews.llvm.org/D19604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [lldb] r268338 - Another little example use of scripted thread plans.

2016-05-02 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon May 2 19:14:52 2016 New Revision: 268338 URL: http://llvm.org/viewvc/llvm-project?rev=268338&view=rev Log: Another little example use of scripted thread plans. Modified: lldb/trunk/examples/python/scripted_step.py Modified: lldb/trunk/examples/python/scripted_step.

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-02 Thread Stephane Sezer via lldb-commits
sas added a comment. @compnerd: - We don't use thumb-* triples in lldb as far as I can see. Thumb is handled just fine regardless of the triple. - `pc` vs `unknown` doesn't seem to matter either, and other code in this file uses `pc` (see a few lines above). - `msvc` vs `itanium` is also handle

[Lldb-commits] [lldb] r268325 - debugserver should fflush its log stream in FileLogCallback, now it does.

2016-05-02 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Mon May 2 17:53:08 2016 New Revision: 268325 URL: http://llvm.org/viewvc/llvm-project?rev=268325&view=rev Log: debugserver should fflush its log stream in FileLogCallback, now it does. Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp Modified: lldb/tru

[Lldb-commits] [lldb] r268309 - Fix an issue where the apropos command would not print fully qualified command names for nested command objects

2016-05-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon May 2 16:28:40 2016 New Revision: 268309 URL: http://llvm.org/viewvc/llvm-project?rev=268309&view=rev Log: Fix an issue where the apropos command would not print fully qualified command names for nested command objects rdar://problem/26020072 Added: lldb/trunk/pac

[Lldb-commits] [lldb] r268307 - Import block pointers from DWARF as Clang block pointers, not as structs.

2016-05-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon May 2 16:15:31 2016 New Revision: 268307 URL: http://llvm.org/viewvc/llvm-project?rev=268307&view=rev Log: Import block pointers from DWARF as Clang block pointers, not as structs. Also added a data formatter that presents them as structs if you use frame variable to loo

[Lldb-commits] [lldb] r268303 - Add more debug logging to g_get_shared_cache_class_info_body

2016-05-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon May 2 15:58:15 2016 New Revision: 268303 URL: http://llvm.org/viewvc/llvm-project?rev=268303&view=rev Log: Add more debug logging to g_get_shared_cache_class_info_body Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [lldb] r268274 - Add an argument to ValueObject::GetSyntheticBase that allows for name customization on the generated value

2016-05-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon May 2 13:13:18 2016 New Revision: 268274 URL: http://llvm.org/viewvc/llvm-project?rev=268274&view=rev Log: Add an argument to ValueObject::GetSyntheticBase that allows for name customization on the generated value Modified: lldb/trunk/include/lldb/Core/ValueObject.h

[Lldb-commits] [lldb] r268263 - I forgot to check in the test case for the changes I made to synthetic children yesterday. Do so now

2016-05-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon May 2 12:57:14 2016 New Revision: 268263 URL: http://llvm.org/viewvc/llvm-project?rev=268263&view=rev Log: I forgot to check in the test case for the changes I made to synthetic children yesterday. Do so now Added: lldb/trunk/packages/Python/lldbsuite/test/function

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-05-02 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. Looks good http://reviews.llvm.org/D19086 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-02 Thread Muhammad Omair Javaid via lldb-commits
omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. Please see inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149 @@ +148,3 @@ +{ +spec.SetTr