Re: [Lldb-commits] [PATCH] D19545: Use ClangASTContext for compilation units with DW_LANG_RUST

2016-04-26 Thread Jason Molenda via lldb-commits
jasonmolenda closed this revision. jasonmolenda added a comment. Committed in r267667. Repository: rL LLVM http://reviews.llvm.org/D19545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] r267667 - Committing patch from

2016-04-26 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Apr 26 23:50:51 2016 New Revision: 267667 URL: http://llvm.org/viewvc/llvm-project?rev=267667&view=rev Log: Committing patch from to use the default clang C/C++ expression parser when debugging Rust programs. Ideally there would be a rust language plugin to support the

Re: [Lldb-commits] [PATCH] D19545: Use ClangASTContext for compilation units with DW_LANG_RUST

2016-04-26 Thread Michael Woerister via lldb-commits
michaelwoerister added a comment. If you could commit that for me, that'd be great! I might be interested in getting commit access when work on a Rust plugin has begun, but for now I'm good without. Thanks again for your help throughout the process. Repository: rL LLVM http://reviews.llvm.o

Re: [Lldb-commits] [PATCH] D19548: Fix TestRegisterVariables.py on Windows

2016-04-26 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267616: Fix TestRegisterVariables.py on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19548?vs=55050&id=55112#toc Repository: rL LLVM http://reviews.llvm.org/D195

[Lldb-commits] [lldb] r267616 - Fix TestRegisterVariables.py on Windows

2016-04-26 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Apr 26 17:25:40 2016 New Revision: 267616 URL: http://llvm.org/viewvc/llvm-project?rev=267616&view=rev Log: Fix TestRegisterVariables.py on Windows Use __attribute__((regparm(x))) to ensure the compiler enregisters at least some arguments when calling functions. Diffe

Re: [Lldb-commits] [PATCH] D19545: Use ClangASTContext for compilation units with DW_LANG_RUST

2016-04-26 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. Should I commit this for you, or do you have/want to set up commit access? Repository: rL LLVM http://reviews.llvm.org/D19545

Re: [Lldb-commits] [PATCH] D19548: Fix TestRegisterVariables.py on Windows

2016-04-26 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Seems reasonable. We can revert and fix if this breaks something. http://reviews.llvm.org/D19548 ___ lldb-commits mailing list lldb-commits@list

Re: [Lldb-commits] [PATCH] D19557: Use absolute module path when possible if sent in svr4 packets

2016-04-26 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. LGTM http://reviews.llvm.org/D19557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D19557: Use absolute module path when possible if sent in svr4 packets

2016-04-26 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: ovyalov, ADodds, jasonmolenda, clayborg. fjricci added subscribers: sas, lldb-commits. If the remote uses svr4 packets to communicate library info, the LoadUnload tests will fail, as lldb only used the basename for modules, causing problems w

[Lldb-commits] [lldb] r267594 - UtilityFunction::MakeFunctionCaller uses the Error to report failure,

2016-04-26 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Apr 26 14:46:39 2016 New Revision: 267594 URL: http://llvm.org/viewvc/llvm-project?rev=267594&view=rev Log: UtilityFunction::MakeFunctionCaller uses the Error to report failure, but when there's was no process it was just returning an null pointer and not setting the erro

[Lldb-commits] [PATCH] D19548: Fix TestRegisterVariables.py on Windows

2016-04-26 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: tfiala. amccarth added a subscriber: lldb-commits. Herald added a subscriber: aemerson. 32-bit Windows calling conventions, by default, don't pass arguments in registers, but this test expects at least one of them to be. By adding __attr

[Lldb-commits] [PATCH] D19545: Use ClangASTContext for compilation units with DW_LANG_RUST

2016-04-26 Thread Michael Woerister via lldb-commits
michaelwoerister created this revision. michaelwoerister added a reviewer: jasonmolenda. michaelwoerister added a subscriber: lldb-commits. michaelwoerister set the repository for this revision to rL LLVM. Up until recently, LLDB would always use a ClangASTContext, regardless which language was s

[Lldb-commits] [PATCH] D19540: Add support for displaying Java array types on Andorid

2016-04-26 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: ovyalov. tberghammer added a subscriber: lldb-commits. Add support for displaying Java array types on Andorid http://reviews.llvm.org/D19540 Files: include/lldb/Symbol/JavaASTContext.h source/Plugins/Language/Java/JavaFormatter

Re: [Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

2016-04-26 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The "timeout_usec" parameter to Connection::ReadAll() doesn't seem like it is doing what is intended. It uses this timeout for every read call which means the Connection::ReadAll

Re: [Lldb-commits] [PATCH] D19535: Fix 2 LLVM assertion caoused by an API missues in Scalar

2016-04-26 Thread Pavel Labath via lldb-commits
labath added a comment. Could you please add one or two unit tests for this in ScalarTest? http://reviews.llvm.org/D19535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D19535: Fix 2 LLVM assertion caoused by an API missues in Scalar

2016-04-26 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Fix 2 LLVM assertion caused by an API miss-ues in Scalar APInt::trunc only works if the destination size is strictly smaller then the source size while APInt::sext and A

Re: [Lldb-commits] [PATCH] D19510: Fix send and receive of ACK byte in test infrastructure for Python 3.5

2016-04-26 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267562: Fix send and receive of ACK byte in test infrastructure for Python 3.5 (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19510?vs=54938&id=55005#toc Repository: rL LLV

[Lldb-commits] [lldb] r267562 - Fix send and receive of ACK byte in test infrastructure for Python 3.5

2016-04-26 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Apr 26 10:15:29 2016 New Revision: 267562 URL: http://llvm.org/viewvc/llvm-project?rev=267562&view=rev Log: Fix send and receive of ACK byte in test infrastructure for Python 3.5 Python 3.5 is pickier about the distinction between chars and bytes (and strings and bytea

Re: [Lldb-commits] [PATCH] D19510: Fix send and receive of ACK byte in test infrastructure for Python 3.5

2016-04-26 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D19510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] r267554 - Bump up timeout in TestCallWithTimeout

2016-04-26 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Apr 26 08:37:24 2016 New Revision: 267554 URL: http://llvm.org/viewvc/llvm-project?rev=267554&view=rev Log: Bump up timeout in TestCallWithTimeout Expression very rarely (linux buildbot, build 13907) completed before we managed to interrupt it. Modified: lldb/trunk

[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

2016-04-26 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. AdbClient was attempting to handle the case where the socket input arrived in pieces, but it was failing to handle the case where the

[Lldb-commits] [lldb] r267550 - rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

2016-04-26 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Tue Apr 26 06:26:00 2016 New Revision: 267550 URL: http://llvm.org/viewvc/llvm-project?rev=267550&view=rev Log: rL267291: Architecture change to thumb on parsing arm.attributes causes regression. Remove case handling elf arm attribute Tag_THUMB_ISA_use and setting archite

Re: [Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

2016-04-26 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267550: rL267291: Architecture change to thumb on parsing arm.attributes causes… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D19520?vs=54961&id=54993#toc Repository: rL L

Re: [Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

2016-04-26 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. The change looks good with the explanation but there is a few thing we should do for longer terms: - Read the value of both Tag_ARM_ISA_use and Tag_THUMB_ISA_use and set the archite

Re: [Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

2016-04-26 Thread Pavel Labath via lldb-commits
labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. I'll let Tamas review this. http://reviews.llvm.org/D19520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman