jasonmolenda added a comment.
This looks good to me. Do you think the ReadRegister decl in
GDBRemoteCommunicationClient.h should have a comment noting that the reg_num is
a number in the remote register numbering scheme (eRegisterKindProcessPlugin)?
When lldb passes around register numbers in
jasonmolenda accepted this revision.
jasonmolenda added a comment.
Hi Ulrich, sorry for the delayed reply, I wanted to look at this function again.
This function has gone through some modifications over its lifetime. As you
correctly point out, we're doing this back-up-by-one thing in two place
fjricci created this revision.
fjricci added reviewers: jasonmolenda, clayborg.
fjricci added subscribers: sas, lldb-commits.
eRegisterKindProcessPlugin is used to store the register
indices used by the remote, and eRegisterKindLLDB is used
to store the internal lldb register indices. However, we'
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D19303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
fjricci created this revision.
fjricci added reviewers: jingham, clayborg, jasonmolenda.
fjricci added subscribers: sas, lldb-commits.
If the remote uses include features when communicating
xml register info back to lldb, the existing code would reset the
lldb register index at the beginning of e
This is going to break the windows build, as getpwuid doesnt exist. Can you
wrap this?
As an aside, why not submit a patch to the llvm function instead, it makes
more sense there
On Tue, Apr 19, 2016 at 4:10 PM Greg Clayton via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: gclayton
Author: gclayton
Date: Tue Apr 19 18:04:35 2016
New Revision: 266832
URL: http://llvm.org/viewvc/llvm-project?rev=266832&view=rev
Log:
llvm::sys::path::home_directory() relies on having "HOME" set in the
environment and that might not always be set. Our FileSpec class uses this
function to resol
Author: kate
Date: Tue Apr 19 15:45:47 2016
New Revision: 266815
URL: http://llvm.org/viewvc/llvm-project?rev=266815&view=rev
Log:
Eliminate circular dependency introduced between lldbtest.py and decorators.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
Modified: lldb/
clayborg accepted this revision.
clayborg added a comment.
These all look fine.
http://reviews.llvm.org/D19086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
apelete added a comment.
Ping :).
Requested changes are done, could someone have a look have this one ?
http://reviews.llvm.org/D19086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
Author: kate
Date: Tue Apr 19 13:20:11 2016
New Revision: 266791
URL: http://llvm.org/viewvc/llvm-project?rev=266791&view=rev
Log:
Adds a test to detect when clang omits specialized generic types from debug
information when using precompiled headers and -gmodules.
Added:
lldb/trunk/packages
ribrdb created this revision.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D19273
Files:
source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
Index: source/Plugins/OperatingSystem/Go/Operating
tfiala added a comment.
If you're in a position where you can grab a sample (using the OS X sample
tool) on the bot when they're "hanging", we can try to find out where they are
at.
The reason I *think* they're not in a method is because they don't have test
method information associated with
labath added a comment.
In http://reviews.llvm.org/D19214#405204, @tfiala wrote:
> Okay I just looked at those, Pavel.
>
> They fall into a category that I know is not yet handled. This is the
> category:
>
> - No test method is "open" (i.e. the dotest.py inferior is not in between a
> start_t
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
As long as PLT entries can't possibly be 4 bytes, then this is OK. Another way
to fix this would be to make a "CheckPLTSize()" function that checks the
architecture of the file, or just th
tfiala added a comment.
I filed this bug to track it:
https://llvm.org/bugs/show_bug.cgi?id=27423
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Okay I just looked at those, Pavel.
They fall into a category that I know is not yet handled. This is the category:
- No test method is "open" (i.e. the dotest.py inferior is not in between a
start_test/end_test) when the timeout occurs. Thus, we cannot "charge" the
t
tfiala added a comment.
Interesting, thanks Pavel!
I'll look at those as I start looking to test the test infrastructure.
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
cameron314 added a comment.
Hmm, that's not good.
No, I don't have a Linux machine set up. I can set up a VM but if you already
have the dumps/logs it would be faster to start with those.
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D19122
_
Author: labath
Date: Tue Apr 19 09:03:43 2016
New Revision: 266736
URL: http://llvm.org/viewvc/llvm-project?rev=266736&view=rev
Log:
Revert "LLDB: Fixed two race conditions when stopping private state thread"
This reverts commit r266733 as it causes a number of failures on linux
buildbots.
Modi
labath added a subscriber: labath.
labath added a comment.
Hi,
I have reverted this as it was causing a number of failures on the linux build
bot
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13585.
I think we'll need to investigate them before putting this in. Do you
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266733: LLDB: Fixed two race conditions when stopping
private state thread (authored by mamai).
Changed prior to commit:
http://reviews.llvm.org/D19122?vs=54098&id=54185#toc
Repository:
rL LLVM
http
Author: mamai
Date: Tue Apr 19 08:21:46 2016
New Revision: 266733
URL: http://llvm.org/viewvc/llvm-project?rev=266733&view=rev
Log:
LLDB: Fixed two race conditions when stopping private state thread
When stopping the private state thread, there was a race condition between the
time the thread ex
ADodds accepted this revision.
ADodds added a comment.
Looks fine to me.
http://reviews.llvm.org/D19230
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Apr 19 04:31:14 2016
New Revision: 266725
URL: http://llvm.org/viewvc/llvm-project?rev=266725&view=rev
Log:
Fix typo in TestSourceManager.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py
Modified:
lldb/trunk/packages/Python
labath added a comment.
BTW, we are still seeing these fake timeouts on our buildbot
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/9770, so I am
not sure if this actually fixed the problem. It could be that this is
actually a different problem, but it does fit your descript
26 matches
Mail list logo
