Author: jmolenda
Date: Tue Apr 12 23:32:49 2016
New Revision: 266165
URL: http://llvm.org/viewvc/llvm-project?rev=266165&view=rev
Log:
Update Symtab::InitAddressIndexes so that computed symbol sizes
will not exceed the bounds of their Section. This is addressing a
problem where a file had a large
jasonmolenda updated this revision to Diff 53517.
jasonmolenda added a comment.
Updated the patch to address Greg's feedback.
Repository:
rL LLVM
http://reviews.llvm.org/D19004
Files:
include/lldb/Core/RangeMap.h
source/Symbol/Symtab.cpp
Index: source/Symbol/Symtab.cpp
=
Author: ovyalov
Date: Tue Apr 12 23:21:05 2016
New Revision: 266164
URL: http://llvm.org/viewvc/llvm-project?rev=266164&view=rev
Log:
Attempt to fix TestCPPBreakpointLocations on Linux/Android.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/TestCPPBreakpo
jasonmolenda added a comment.
Just to be clear, my concern is we get an register location which is
"undefined" (I've never seen it, I don't know what it means) and now
SavedLocationForRegister() will say "this register is volatile, not looking any
further" when it used to say "register not foun
jasonmolenda added a comment.
Thanks for doing this work Ulrich, the assumption that SP==CFA was mine, I
should have put this in the ABI from the start.
I worry a little about the change to
RegisterContextLLDB::SavedLocationForRegister() where you've moved the ABI
is-volatile check into ABI::G
uweigand added a comment.
OK, here's an implementation of the new approach. In addition to the changes
discussed, I had to add handling of undefined register locations -- this might
now theoretically also trigger when CFI contains an explicit DW_CFA_undefined,
but it should actually do the ri
uweigand retitled this revision from "Add new ABI callback to return CFA
offset" to "Add new ABI callback to provide fallback unwind register locations".
uweigand updated the summary for this revision.
uweigand updated this revision to Diff 53502.
http://reviews.llvm.org/D18977
Files:
include/
uweigand added a comment.
In http://reviews.llvm.org/D18985#397674, @clayborg wrote:
> So many tests above are going to accept either a little endian or big endian
> value. This will make most of these tests useless since if a little endian
> machine fails with a big endian number we won't catc
uweigand updated the summary for this revision.
uweigand updated this revision to Diff 53501.
http://reviews.llvm.org/D18985
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py
packages/Python/lldbsuite/test/functi
uweigand added a comment.
In http://reviews.llvm.org/D18984#398486, @tberghammer wrote:
> Generally looks good with 2 minor comment inline. I also run the test suite
> on Android ARM (little endian) and everything looked fine
Thanks for the review and test!
Comment at: sourc
uweigand updated this revision to Diff 53500.
http://reviews.llvm.org/D18984
Files:
source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
source/Plugins/Instruction/ARM/EmulationStateARM.cpp
source/Plugins/Instruction/ARM/EmulationStateARM.h
Index: source/Plugins/Instruction/ARM/Emulati
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL266145: Fix breakpoint_set_restart test for Windows
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19035?vs=53472&id=53482#toc
Repo
Author: amccarth
Date: Tue Apr 12 17:45:03 2016
New Revision: 266145
URL: http://llvm.org/viewvc/llvm-project?rev=266145&view=rev
Log:
Fix breakpoint_set_restart test for Windows
When run with the multiprocess test runner, the getchar() trick doesn't work,
so ninja check-lldb would fail on this
amccarth marked an inline comment as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11
@@ -10,2 +10,3 @@
+#include
#include
#include
ovyalov wrote:
> You may remove iostream since getchar is no lon
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11
@@ -10,2 +10,3 @@
+#include
#include
#include
You may remove iostream si
amccarth created this revision.
amccarth added reviewers: ovyalov, labath.
amccarth added a subscriber: lldb-commits.
When run with the multiprocess test runner, the getchar() trick doesn't work,
so `ninja check-lldb` would fail on this test, but running the test directly
worked fine.
This repl
Author: gclayton
Date: Tue Apr 12 17:02:37 2016
New Revision: 266139
URL: http://llvm.org/viewvc/llvm-project?rev=266139&view=rev
Log:
Fixed being able to set breakpoints on destructors when we don't fully specify
the demangled name. So all of the following now work:
(lldb) b ~Foo
(lldb) b Foo::
Author: enrico
Date: Tue Apr 12 16:57:11 2016
New Revision: 266138
URL: http://llvm.org/viewvc/llvm-project?rev=266138&view=rev
Log:
Use the FormatEntity work for great good - parse summary strings before
accepting them, and fail to add any strings that fail parsing
Modified:
lldb/trunk/sou
Author: enrico
Date: Tue Apr 12 16:26:48 2016
New Revision: 266129
URL: http://llvm.org/viewvc/llvm-project?rev=266129&view=rev
Log:
Cleanup the arguments for 'memory find' such that the help system reflects the
real way to invoke it
Modified:
lldb/trunk/source/Commands/CommandObjectMemory.c
Author: gclayton
Date: Tue Apr 12 15:26:41 2016
New Revision: 266118
URL: http://llvm.org/viewvc/llvm-project?rev=266118&view=rev
Log:
Revert to using libdispatch to reap threads on MacOSX. Code was accidentally
checked in that is now reverted.
Modified:
lldb/trunk/source/Host/macosx/Host
uweigand added a comment.
In http://reviews.llvm.org/D18978#398180, @labath wrote:
> Could you also add a core file test to `TestLinuxCore`? It should be a matter
> of running `make_core.sh`, saving the files and creating a new test function
> in the file (I've tried to make it simple, if you s
Author: enrico
Date: Tue Apr 12 13:23:18 2016
New Revision: 266103
URL: http://llvm.org/viewvc/llvm-project?rev=266103&view=rev
Log:
Initialize the Python script interpreter lazily (i.e. not at debugger startup)
This time it should also pass the gtests
Modified:
lldb/trunk/source/Plugins/S
Yeah. I ended up tracking it down by hand. I am running one final run of tests
and should have a commit going in very soon.
Sent from my iPhone
> On Apr 12, 2016, at 11:20 AM, Zachary Turner wrote:
>
> I think todd did some work to get the gtests working in Xcode. Is that not
> working?
>> O
clayborg added a comment.
Yes, that plan sounds great.
http://reviews.llvm.org/D18977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I think todd did some work to get the gtests working in Xcode. Is that not
working?
On Tue, Apr 12, 2016 at 11:12 AM Enrico Granata wrote:
> Is there any failure logs I can look at?
> I am gonna guess the issue is simply that the unit test is assuming Python
> to be initialized. Which is a bad as
Is there any failure logs I can look at?
I am gonna guess the issue is simply that the unit test is assuming Python to
be initialized. Which is a bad assumption after my change.
Sent from my iPhone
> On Apr 12, 2016, at 2:16 AM, Pavel Labath wrote:
>
> This breaks the python unit tests. Doesn
uweigand added a comment.
In http://reviews.llvm.org/D18977#398557, @clayborg wrote:
> In http://reviews.llvm.org/D18977#398157, @uweigand wrote:
>
> > In http://reviews.llvm.org/D18977#397626, @clayborg wrote:
> >
> > > I am not sure why this offset of 160 isn't represented in the unwind
> > >
Author: jingham
Date: Tue Apr 12 12:17:35 2016
New Revision: 266093
URL: http://llvm.org/viewvc/llvm-project?rev=266093&view=rev
Log:
Breakpoint conditions were making result variables, which they should not do.
The result variables aren't useful, and if you have a breakpoint on a
common functi
clayborg added a comment.
We can create a new SectionType enumeration in lldb-enumerations.h. Then in
ObjectFileELF::CreateSections() we would classify the ".plt" section as
eSectionTypeProcedureLinkageTable:
static ConstString g_sect_name_plt (".plt");
if (name == g_sect_name_plt)
se
Author: jingham
Date: Tue Apr 12 12:04:12 2016
New Revision: 266092
URL: http://llvm.org/viewvc/llvm-project?rev=266092&view=rev
Log:
'int' is reported as an exception on OS X not as a signal. I don't think
this test ever succeeded on OS X.
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
clayborg added a comment.
In http://reviews.llvm.org/D18977#398157, @uweigand wrote:
> In http://reviews.llvm.org/D18977#397626, @clayborg wrote:
>
> > I am not sure why this offset of 160 isn't represented in the unwind info.
> > I guess the OS unwinder that uses the EH frame info just knows th
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Only add sections that don't have children in AddSectionsToRangeMap() and this
will be good to go.
Comment at: source/Symbol/Symtab.cpp:952-975
@@ +951,26 @@
+/
tberghammer added a comment.
Generally looks good with 2 minor comment inline. I also run the test suite on
Android ARM (little endian) and everything looked fine
Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:127
@@ -119,3 +126,3 @@
else
-
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
http://reviews.llvm.org/D18980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer accepted this revision.
tberghammer added a comment.
Looks good as I am not aware of any system where the plt sections has different
section name
http://reviews.llvm.org/D18973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
Author: labath
Date: Tue Apr 12 08:55:54 2016
New Revision: 266072
URL: http://llvm.org/viewvc/llvm-project?rev=266072&view=rev
Log:
Fixup TestFdLeak
this test was unintentionally XFAILed due to a change in the behavior of the
expectedFailure
decorator. Fix that. Also, mark the test as debug-inf
uweigand added a comment.
In http://reviews.llvm.org/D18985#398171, @labath wrote:
> Just because the tests test the console interface, it doesn't mean you can't
> use the python interface to do auxiliary tasks, like computing the
> expectations. It sounds like you should be able to to a
> `se
omjavaid added a comment.
Seems legit but One cosmetic comment inline.
Also have you tested this patch by running LLDB testsuite on arm in both little
and big endian modes?
Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:157
@@ -149,12 +156,3 @@
{
-if (s
Author: labath
Date: Tue Apr 12 06:59:41 2016
New Revision: 266058
URL: http://llvm.org/viewvc/llvm-project?rev=266058&view=rev
Log:
Bump up timeout in TestGdbRemoteProcessInfo
the process info packet is slow, and sometimes it does not arrive on time when
run on the android
emulator.
Modified:
labath added a comment.
It would be great if you could add a some unit tests for your modifications to
the Scalar class. You don't have to be too exhaustive, but a couple of tests
would go a long way.
http://reviews.llvm.org/D18981
___
lldb-commit
labath added a subscriber: labath.
labath added a comment.
It would be worthwhile to add a unit test for the DataExtractor fix (we don't
have many of those, but we're trying to build them up).
http://reviews.llvm.org/D18982
___
lldb-commits mailing
labath added a comment.
Could you also add a core file test to `TestLinuxCore`? It should be a matter
of running `make_core.sh`, saving the files and creating a new test function in
the file (I've tried to make it simple, if you see room for improvement, then
let me know).
I think this is espe
Author: labath
Date: Tue Apr 12 05:06:37 2016
New Revision: 266054
URL: http://llvm.org/viewvc/llvm-project?rev=266054&view=rev
Log:
Skip a test in TestNamespaceLookup on linux to avoid a crash
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py
Mod
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D18985#398169, @uweigand wrote:
> In http://reviews.llvm.org/D18985#397674, @clayborg wrote:
>
> > So many tests above are going to accept either a little endian or big
> > endian value. This will make most of
uweigand added a comment.
In http://reviews.llvm.org/D18985#397674, @clayborg wrote:
> So many tests above are going to accept either a little endian or big endian
> value. This will make most of these tests useless since if a little endian
> machine fails with a big endian number we won't catc
uweigand added a comment.
In http://reviews.llvm.org/D18977#397626, @clayborg wrote:
> I am not sure why this offset of 160 isn't represented in the unwind info. I
> guess the OS unwinder that uses the EH frame info just knows that it must
> adjust the CFA? That seems like a hack. It seems like
This breaks the python unit tests. Doesn't seem hard to fix, it seems we
just need some way to "really" initialize python before we run the tests.
However, I have reverted this change until that happens to keep to bots
green.
pl
On 12 April 2016 at 02:41, Enrico Granata via lldb-commits <
lldb-co
Author: labath
Date: Tue Apr 12 04:06:08 2016
New Revision: 266050
URL: http://llvm.org/viewvc/llvm-project?rev=266050&view=rev
Log:
Revert "Restore the lazy initialization of ScriptInterpreterPython, which was
lost as part of the SystemLifetimeManager work"
This change breaks python unit tests.
labath added a comment.
A random thought: will `getchar()` block the inferior on windows (because of
missing stdio forwarding, et al.). If it wont then this could be the cause of
the flakyness. If that's the case, then we can replace that call with something
that will surely halt progress, like
labath added a comment.
In http://reviews.llvm.org/D18886#397843, @amccarth wrote:
> It's weird in that, if you run the test independently, it passes. But if you
> run it with the multiprocess test runner (ninja check-lldb), then it fails on
> this line:
>
> self.fail("Setting a breakpoint gen
50 matches
Mail list logo
