[Lldb-commits] [lldb] r265644 - Symbol: fix build

2016-04-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Apr 7 01:51:10 2016 New Revision: 265644 URL: http://llvm.org/viewvc/llvm-project?rev=265644&view=rev Log: Symbol: fix build TargetOptions is ambiguous due to a definition in LLVM and in clang. This was exposed by SVN r265640. Update to fix the build against the newe

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-04-06 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 52886. nitesh.jain added a comment. The diff is updated as per suggestion Repository: rL LLVM http://reviews.llvm.org/D18638 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp source/Plugins/ExpressionParser/Clang/ClangExpress

[Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-06 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. zturner added a subscriber: lldb-commits. This code is still untested aside from that it compiles. I mostly want to put an early work-in-progress up here to make sure I'm on the right path and am not doing anything fundamentally

[Lldb-commits] Updated documentation for SBAddress

2016-04-06 Thread John Lindal via lldb-commits
The patch is based off the latest code in the github mirror. It includes some documentation changes for other classes, but the primary change is for SBAddress. I intend to fill out the other classes in separate patches. I do not have committer access. Can somebody please merge this in? Thanks,

[Lldb-commits] Buildbot numbers for the week of 3/20/2016 - 3/26/2016

2016-04-06 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the week of 3/20/2016 - 3/26/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

[Lldb-commits] Buildbot numbers for the week of 3/27/2016 - 4/02/2016

2016-04-06 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 3/27/2016 - 4/02/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

Re: [Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Ying Chen via lldb-commits
chying added a subscriber: chying. chying added a comment. TestRegisters.py and TestDebugBreak.py are broken after this change. Could you take a look? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13090 Repository: rL LLVM http://reviews.llvm.org/D18819 _

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-06 Thread Zachary Turner via lldb-commits
I think we actually came up with a better idea. the command script import code is generating a temporary python file which actually does the import, so we can generate the code so that it uses the imp module to do an import by full pathname. An example of code that already does this is in lldb/te

Re: [Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265560: Reduce code duplication in ProcessGDBRemote (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18819?vs=52773&id=52817#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r265560 - Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 6 11:49:13 2016 New Revision: 265560 URL: http://llvm.org/viewvc/llvm-project?rev=265560&view=rev Log: Reduce code duplication in ProcessGDBRemote Summary: SetThreadStopInfo was checking for a breakpoint at the current PC several times. This merges the identical cod

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-06 Thread Pavel Labath via lldb-commits
BTW, the same test fails on our windows->android buildbot (which still uses python 2). I haven't investigated the issue yet, I'm writing it just as an additional data point... cheers, pl On 6 April 2016 at 16:19, Zachary Turner via lldb-commits wrote: > Well, it would belong anywhere that does a

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-06 Thread Zachary Turner via lldb-commits
Well, it would belong anywhere that does an import, so in theory it belongs in every script. In the general case, for example if you are like this: foo |-- bar | baz |-- biz.py And you are in foo and you want to import biz.py, you could do "from bar.baz import biz". So you just get the

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-06 Thread Adrian McCarthy via lldb-commits
It will still be a bit of a trick to change the `command script import` handling to do `from foo import blah` in the general case, since foo can't really be an absolute file path. And does the `from __future__ import absolute_import` really belong in the script your importing? Or does it belong i

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Todd Fiala via lldb-commits
tfiala added a comment. (And sorry for the breakage! I didn't see any nag mails). Users: tfiala (Author) http://reviews.llvm.org/rL265498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Todd Fiala via lldb-commits
(And sorry for the breakage! I didn't see any nag mails). On Wed, Apr 6, 2016 at 7:34 AM, Todd Fiala wrote: > CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the > majority of our tests, Makefile.rules correctly assumes optimizations are > turned off for maximal debug info).

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Todd Fiala via lldb-commits
tfiala added a comment. CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the majority of our tests, Makefile.rules correctly assumes optimizations are turned off for maximal debug info). If that was the fix, that is circumventing the check this test is doing. What we really ne

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Todd Fiala via lldb-commits
CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the majority of our tests, Makefile.rules correctly assumes optimizations are turned off for maximal debug info). If that was the fix, that is circumventing the check this test is doing. What we really need (and I'll go back and

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. My guess is the root cause of the problem is that we are setting CFLAGS instead of appending to CLAFGS_EXTRA (I changed it in my followup CL) Users: tfiala (Author) http://reviews.llvm.org/rL265498 ___ lldb-commits m

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Todd Fiala via lldb-commits
tfiala added a subscriber: tfiala. tfiala added a comment. I think it's the -O1 that is screwing it up. The test relies on setting the optimization level, and then screws up the compiler's ability to find the framework headers with more recent clangs on OS X (both in-tree built and Xcode-delivere

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Todd Fiala via lldb-commits
I think it's the -O1 that is screwing it up. The test relies on setting the optimization level, and then screws up the compiler's ability to find the framework headers with more recent clangs on OS X (both in-tree built and Xcode-delivered). Ultimately OS X has been shifting where the /usr/includ

[Lldb-commits] [lldb] r265529 - Fixup TestLinuxCore on windows

2016-04-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 6 06:05:30 2016 New Revision: 265529 URL: http://llvm.org/viewvc/llvm-project?rev=265529&view=rev Log: Fixup TestLinuxCore on windows test_same_pid_running couldn't delete the temporary files, while we had them open. Deleting the target should make things work. Mod

Re: [Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

2016-04-06 Thread Tamas Berghammer via lldb-commits
tberghammer added subscribers: lldb-commits, tberghammer. tberghammer added a comment. This CL caused a lot of breakage across various Linux/Android builders. I created a fix at http://reviews.llvm.org/rL265527 but please verify it is still working with OSX after that /lldb/trunk/packages/Pyth

[Lldb-commits] [lldb] r265527 - Fix and xfail TestRegisterVariables after rL265498

2016-04-06 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Apr 6 05:34:29 2016 New Revision: 265527 URL: http://llvm.org/viewvc/llvm-project?rev=265527&view=rev Log: Fix and xfail TestRegisterVariables after rL265498 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile lldb/trunk/p

[Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. SetThreadStopInfo was checking for a breakpoint at the current PC several times. This merges the identical code into a separate function. I've left one breakpoint check alone, as it was doin

[Lldb-commits] [lldb] r265525 - Fix a cornercase in breakpoint reporting

2016-04-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 6 04:10:29 2016 New Revision: 265525 URL: http://llvm.org/viewvc/llvm-project?rev=265525&view=rev Log: Fix a cornercase in breakpoint reporting Summary: This resolves a similar problem as D16720 (which handled the case when we single-step onto a breakpoint), but thi

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-06 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265525: Fix a cornercase in breakpoint reporting (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18692?vs=52357&id=52771#toc Repository: rL LLVM http://reviews.llvm.org/D1869

[Lldb-commits] [lldb] r265524 - Fixup r265398

2016-04-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 6 03:55:31 2016 New Revision: 265524 URL: http://llvm.org/viewvc/llvm-project?rev=265524&view=rev Log: Fixup r265398 Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py URL: http://llvm