Author: sivachandra
Date: Mon Mar 21 19:35:31 2016
New Revision: 264012
URL: http://llvm.org/viewvc/llvm-project?rev=264012&view=rev
Log:
[JITLoaderGDB] Pack the jit entry struct according to the target arch.
Reviewers: clayborg
Subscribers: tberghammer, dsrbecky, lldb-commits
Differential Revi
sivachandra added a comment.
Thanks for the quick review.
I will put this in for now. Will revisit if a need for an elaborate solution
arises.
http://reviews.llvm.org/D18334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
sivachandra updated this revision to Diff 51246.
sivachandra added a comment.
Explicitly set the alignment of the size field in the unpacked struct
to 8 bytes. This should take care of the case where in the host is i386
and the target is arm (for example).
http://reviews.llvm.org/D18334
Files:
ted added a comment.
Without the patch I'm seeing the original prompt printed after the command, in
a line like this:
(lldb) Process 1 stopped
and no prompt after the async output from the stop.
With the patch I see the above prompt, and a prompt after the async output. I
think with the patch
clayborg added a comment.
Seems like it would be nice to get the prompt clearing working...
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a comment.
Here's a snippet of output with this fix patched in on Windows. Note the extra
(lldb) prompts on the lines beginning with "Process 10672..."
(lldb) br set -l 22
Breakpoint 1: where = a.exe`main + 20 at fizzbuzz.cpp:22, address = 0x0040e074
(lldb) run
Process 10672 laun
Author: spyffe
Date: Mon Mar 21 17:23:38 2016
New Revision: 263995
URL: http://llvm.org/viewvc/llvm-project?rev=263995&view=rev
Log:
Collect IRExecutionUnits as part of persistent expression state.
IRExecutionUnits contain code and data that persistent declarations can
depend on. In order to kee
clayborg added a comment.
this could still be the same bug. So if this doesn't fix things for you on
windows, then this bug isn't quite fixed. Ted, are you seeing the same thing?
amccarth, can you attach some output to see what you are seeing?
http://reviews.llvm.org/D18335
clayborg added a comment.
It would be nice to clear the line though. What _should_ happen is the "(lldb)
" prompt is cleared by clearing text to the start of where the prompt was
printed, then display the async text and refresh the prompt. So this fix is a
bit hacky in that it isn't trying to s
amccarth added a comment.
I patched this change in, and now I'm getting extra prompts on Windows rather
than getting the too-late prompt sooner. So is that a separate bug?
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-commits@l
clayborg added a comment.
No, this fixed the problem of printing the "(lldb) " prompt first, then being
asked to print async text, then not refreshing the prompt. Not to say there
won't still be a race, but this particular problem is what we are fixing.
http://reviews.llvm.org/D18335
__
amccarth added a subscriber: amccarth.
amccarth added a comment.
This just seems to insert an extra prompt rather than solving the problem with
the prompt being printed too late.
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-com
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. One other alternative is to get the type from the program if it
exists in the debug info and explore the struct using ValueObject. This would
get you out of the fixed alignment
cameron314 updated this revision to Diff 51231.
cameron314 added a comment.
Here's the latest patch, now with 100% more autoformatting and a centralized
`FileSystem::Stat` function.
I didn't rebase, but it should still apply cleanly.
http://reviews.llvm.org/D17107
Files:
cmake/modules/LLDBCo
sivachandra added a comment.
This fixes an issue we are seeing with i386 JIT entry handling.
I have chosen a least disruptive change. However, since alignment is actually
determined by the ABI, one could add some API to the ABI interface to determine
the packing. However, it seemed like an over
ted created this revision.
ted added reviewers: clayborg, zturner.
ted added a subscriber: lldb-commits.
On Windows (and possibly other hosts with LLDB_DISABLE_LIBEDIT defined), the
(lldb) prompt won't print after async output, like from a breakpoint hit or a
step. This patch forces the prompt t
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added subscribers: lldb-commits, dsrbecky, tberghammer.
http://reviews.llvm.org/D18334
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins
Author: jingham
Date: Mon Mar 21 14:21:13 2016
New Revision: 263972
URL: http://llvm.org/viewvc/llvm-project?rev=263972&view=rev
Log:
Compilation can end up calling functions (e.g. to resolve indirect functions)
so I added
a way for compilation to take a "thread to use for compilation". If it is
cameron314 added a comment.
I'll run clang-format and submit a new patch. Thanks for fixing that duplicate
symbol with the signal stuff!
Comment at: source/Host/common/FileSpec.cpp:94-115
@@ -93,2 +93,24 @@
+{
+#ifdef _WIN32
+std::wstring wresolved_path;
+if
clayborg added a comment.
I need to speak with you about this and I do have objections. I made a ton of
comments inline and as I started to understand what you were trying to do many
objections changed, but I still have them. There is a ton of stuff in there and
I would like to speak with you o
zturner added a comment.
ping, any objections here Greg?
http://reviews.llvm.org/D18194
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
And btw, the multiply defined symbol error is gone now that the custom `signal`
function is removed
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
zturner added a comment.
Patch doesn't appear to be clang-formatted. All patches need to be run through
clang-format before submitting.
I think this is my last set of comments. If there's any you disagree with let
me know. If you agree with everything, I can probably just make the changes on
EwanCrawford updated this revision to Diff 51182.
EwanCrawford added a comment.
Rebased on tip
Repository:
rL LLVM
http://reviews.llvm.org/D17957
Files:
packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile
packages/Python/lldbsuite/test/expression_comman
26 matches
Mail list logo
