Author: enrico
Date: Mon Mar 7 23:59:47 2016
New Revision: 262914
URL: http://llvm.org/viewvc/llvm-project?rev=262914&view=rev
Log:
This is actually a FileSpec, so use .GetCString() instead
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interprete
Author: enrico
Date: Mon Mar 7 23:57:52 2016
New Revision: 262913
URL: http://llvm.org/viewvc/llvm-project?rev=262913&view=rev
Log:
Use .c_str() here to unbreak the Linux build
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interpreter/CommandInt
Author: enrico
Date: Mon Mar 7 23:37:15 2016
New Revision: 262912
URL: http://llvm.org/viewvc/llvm-project?rev=262912&view=rev
Log:
A few more improvements on the way to the command alias refactoring
- move alias help generation to CommandAlias, out of CommandInterpreter
- make alias creation us
Author: enrico
Date: Mon Mar 7 21:56:12 2016
New Revision: 262909
URL: http://llvm.org/viewvc/llvm-project?rev=262909&view=rev
Log:
Turn GetAliasOptions() into GetAlias()
Eventually, there will be more things that CommandAlias contains, and I don't
want accessors for each of them on the Command
Author: enrico
Date: Mon Mar 7 21:48:41 2016
New Revision: 262905
URL: http://llvm.org/viewvc/llvm-project?rev=262905&view=rev
Log:
Attempt to fix the Ubuntu buildbot by making FindLongestCommandWord a free
template function in lldb_private
Modified:
lldb/trunk/include/lldb/Interpreter/Com
Author: jmolenda
Date: Mon Mar 7 21:24:13 2016
New Revision: 262904
URL: http://llvm.org/viewvc/llvm-project?rev=262904&view=rev
Log:
Unbreak linux build broken by r262901
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interpreter/CommandInterpret
Author: enrico
Date: Mon Mar 7 21:00:27 2016
New Revision: 262901
URL: http://llvm.org/viewvc/llvm-project?rev=262901&view=rev
Log:
Move ProcessAliasOptionsArgs to be a static on CommandAlias; it wasn't using
any instance data on the CommandInterpreter anyway
This small step removes one piece o
Author: enrico
Date: Mon Mar 7 20:49:15 2016
New Revision: 262900
URL: http://llvm.org/viewvc/llvm-project?rev=262900&view=rev
Log:
Change the way command aliases are stored. Go from a model where a map holds
the alias -> underlying command binding and another map holds the alias ->
options, to
cameron314 updated this revision to Diff 49986.
cameron314 added a comment.
Sorry for the delay, I wanted to make sure LLDB compiled without warnings after
I rebased the patch. It applies cleanly on the tip as of this writing, and is
based on http://reviews.llvm.org/rL262819.
http://reviews.ll
cameron314 added inline comments.
Comment at: lldb/trunk/source/Host/common/File.cpp:330
@@ +329,3 @@
+}
+::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYWR, mode);
+#else
zturner wrote:
> cameron314 wrote:
> > zturner wrote:
> > > Any par
zturner added inline comments.
Comment at: lldb/trunk/source/Host/common/File.cpp:330
@@ +329,3 @@
+}
+::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYWR, mode);
+#else
cameron314 wrote:
> zturner wrote:
> > Any particular reason you're us
cameron314 added a comment.
Absolutely, I'm rebasing now. This is unfortunately the type of patch that rots
really quickly ;-)
I did run `check-lldb` locally at one point, with no major differences before
and after the patch. But I recently discovered the version of Python I'd
compiled had acc
zturner added a comment.
Can you rebase against tip of trunk? I want to apply and run the test suite
with the patch applied, but I'm getting a lot of errors. After uploading a new
rebased patch, can you also respond with the revision you rebased against so I
can make sure I'm at the same plac
ldrumm added a comment.
Hi all
If there are no objections, I'd like to commit this. Is this in an acceptable
state?
Best
Luke
http://reviews.llvm.org/D17719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
cameron314 added a comment.
No worries, thanks for taking a look!
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a subscriber: zturner.
zturner added a comment.
Sorry slipped under my radar, I'll look again today
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Sorry slipped under my radar, I'll look again today
On Mon, Mar 7, 2016 at 7:50 AM Cameron wrote:
> cameron314 added a comment.
>
> I don't want to be pushy, but is there a chance of this patch being
> accepted soon?
> It does depend on http://reviews.llvm.org/D17549 in LLVM which is also
> still
cameron314 added a comment.
I don't want to be pushy, but is there a chance of this patch being accepted
soon?
It does depend on http://reviews.llvm.org/D17549 in LLVM which is also still
pending, but that one's at least very a simple patch adding the support
functions that this one uses.
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint (authored
by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D17597?vs=49021&id=49936#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: mohit.bhakkad
Date: Mon Mar 7 03:12:49 2016
New Revision: 262819
URL: http://llvm.org/viewvc/llvm-project?rev=262819&view=rev
Log:
[LLDB][MIPS] Fix TestDisassembleBreakpoint
Patch by Nitesh Jain
Reviewers: clayborg, jaydeep.
Subscribers: bhushan, mohit.bhakkad, sagar, lldb-commits.
Diff
Author: jmolenda
Date: Mon Mar 7 02:04:49 2016
New Revision: 262816
URL: http://llvm.org/viewvc/llvm-project?rev=262816&view=rev
Log:
Move SBLanguageRuntime.cpp from the lldb-core group to the LLDB
group to fix a build time issue.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modifi
21 matches
Mail list logo
