zturner added a comment.
Yes looks fine
Repository:
rL LLVM
http://reviews.llvm.org/D17022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Yes looks fine
On Wed, Feb 17, 2016 at 8:45 PM Bhushan Attarde
wrote:
> bhushan added a comment.
>
> Hi Zachary,
>
> Can you please find some time to review this?
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D17022
>
>
>
>
___
lldb-commits
bhushan added a comment.
Hi Zachary,
Can you please find some time to review this?
Repository:
rL LLVM
http://reviews.llvm.org/D17022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
zturner added a comment.
Added a few notes to clarify things that might not be obvious upon a first look
at the patch.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:81
@@ +80,3 @@
+std::string exePath = m_obj_file->GetFileSpec().GetPath();
+auto er
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
This is a first attempt at getting `SymbolFilePDB` working with line table
support. A few notes:
* This won't compile until a corresponding patch goes in on the LLVM side. The
patch is
Author: jingham
Date: Wed Feb 17 19:28:22 2016
New Revision: 261183
URL: http://llvm.org/viewvc/llvm-project?rev=261183&view=rev
Log:
Add usage instructions for TypeSystemMap::AddToMap.
Modified:
lldb/trunk/include/lldb/Symbol/TypeSystem.h
Modified: lldb/trunk/include/lldb/Symbol/TypeSystem.
Author: eugenezelenko
Date: Wed Feb 17 18:10:17 2016
New Revision: 261179
URL: http://llvm.org/viewvc/llvm-project?rev=261179&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.
Modified:
lldb/trunk/include/lldb/Target/Platform.h
lldb/trunk/source/Target/ABI.cp
Author: enrico
Date: Wed Feb 17 16:14:41 2016
New Revision: 261165
URL: http://llvm.org/viewvc/llvm-project?rev=261165&view=rev
Log:
Apple simulator platforms don't have a shared cache to load Objective-C class
information from
This code was doing the right thing for the iOS simulator, but not ot
