Re: [Lldb-commits] [PATCH] D17295: Stack unwinding emulation: handle adjustment of FP

2016-02-16 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D17295: Stack unwinding emulation: handle adjustment of FP

2016-02-16 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: ovyalov, jasonmolenda, clayborg. tberghammer added a subscriber: lldb-commits. Stack unwinding emulation: handle adjustment of FP This change is improving the instruction emulation based unwinding to handle when the frame pointer is

[Lldb-commits] [lldb] r260969 - Revert "Use BKPT instead of UDF for arm/thumb breakpoints"

2016-02-16 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Feb 16 09:14:36 2016 New Revision: 260969 URL: http://llvm.org/viewvc/llvm-project?rev=260969&view=rev Log: Revert "Use BKPT instead of UDF for arm/thumb breakpoints" This reverts commit 293c18e067d663e0fe93e6f3d800c2a4bfada2b0. The BKPT instruction generates SIGBUS

Re: [Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

2016-02-16 Thread Luke Drummond via lldb-commits
ldrumm added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560 @@ -558,5 +558,4 @@ -static bool FindFunctionInModule (ConstString &mangled_name, - llvm::Module *module, -

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. Hi Ewan, Can you give me some instruction about how can I reproduce the issue on a Nexus 6? (If you can't gave the information out then the disassembly of the offending function and the fault address might gave me some hint

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Tamas Berghammer via lldb-commits
Hi Ewan, Can you give me some instruction about how can I reproduce the issue on a Nexus 6? (If you can't gave the information out then the disassembly of the offending function and the fault address might gave me some hint as well) A SIGBUS error looks a bit strange for me but my best guess is t

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Ewan Crawford via lldb-commits
EwanCrawford added a subscriber: EwanCrawford. EwanCrawford added a comment. Hi Tamas, This commit causes a SIGBUS for me on Nexus 6 ARMv7 devices, specifically the g_thumb_breakpoint_opcode change. I can revert this locally but any advice on tracking the issue down further? Repository: rL L

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-16 Thread Bhushan Attarde via lldb-commits
bhushan added a comment. @zturner, Ok to commit? Repository: rL LLVM http://reviews.llvm.org/D17022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r260950 - Mark TestLldbGdbServer.test_written_M_content_reads_back_correctly as flaky on linux

2016-02-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 16 03:58:47 2016 New Revision: 260950 URL: http://llvm.org/viewvc/llvm-project?rev=260950&view=rev Log: Mark TestLldbGdbServer.test_written_M_content_reads_back_correctly as flaky on linux I believe the root cause is the asynchronous arrival of inferior stdio (pr256

[Lldb-commits] [lldb] r260951 - Bump up timeout in TestChangeProcessGroup

2016-02-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 16 03:58:50 2016 New Revision: 260951 URL: http://llvm.org/viewvc/llvm-project?rev=260951&view=rev Log: Bump up timeout in TestChangeProcessGroup The test fails very rarely. I suspect this is simply because the inferior does not have enough time to create the file un