zturner added a comment.
In http://reviews.llvm.org/D17107#349463, @cameron314 wrote:
> Thanks for all the feedback! I'll look into it in detail tomorrow.
>
> Perhaps it would make more sense if I clarified where I'm coming from with
> this patch -- we use LLDB on Windows (with a custom backend)
cameron314 added a comment.
Thanks for all the feedback! I'll look into it in detail tomorrow.
Perhaps it would make more sense if I clarified where I'm coming from with this
patch -- we use LLDB on Windows (with a custom backend) where I work, and
wanted to be able to run a program with a non-
jingham added a comment.
My bad, that sees to be what it does.
Jim
Repository:
rL LLVM
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
My bad, that sees to be what it does.
Jim
> On Feb 10, 2016, at 4:59 PM, Zachary Turner wrote:
>
> zturner added a comment.
>
> In http://reviews.llvm.org/D17107#349421, @jingham wrote:
>
>> Unless something has changed since last I looked, the llvm path utilities
>> are host specific. I di
zturner added a comment.
In http://reviews.llvm.org/D17107#349421, @jingham wrote:
> Unless something has changed since last I looked, the llvm path utilities are
> host specific. I didn't inspect the code where this is being used, but it is
> in Host/common, so unless there's an ifdef WINDOWS
Unless something has changed since last I looked, the llvm path utilities are
host specific. I didn't inspect the code where this is being used, but it is
in Host/common, so unless there's an ifdef WINDOWS around it, I don't think you
should use the llvm path utilities.
Jim
> On Feb 10, 2016,
jingham added a subscriber: jingham.
jingham added a comment.
Unless something has changed since last I looked, the llvm path utilities are
host specific. I didn't inspect the code where this is being used, but it is
in Host/common, so unless there's an ifdef WINDOWS around it, I don't think yo
zturner requested changes to this revision.
zturner added a comment.
This revision now requires changes to proceed.
Overall I like the idea and I'm happy to get Unicode paths and strings working
properly. I'll look at the rest in more detail later, but I have some starting
comments for now.
On
amccarth added a subscriber: amccarth.
amccarth added a comment.
I like that you're doing this, but ...
There's a ton of duplication here. I'd really like to see the conversions
centralized with consistent error handling. Cluttering up already-too-long
functions with more #ifdefs and a half d
cameron314 created this revision.
cameron314 added a reviewer: zturner.
cameron314 added a subscriber: lldb-commits.
cameron314 set the repository for this revision to rL LLVM.
Various fixes for Win32 interop, particularly with regard to paths; paths
containing non-ASCII characters now work prope
zturner created this revision.
zturner added a reviewer: vharron.
zturner added a subscriber: lldb-commits.
Hi Vince,
I'm not sure why the #if _WIN32 check is even in there to begin with, but I
tested on Windows 7 and Windows 10 and in both cases the output is that of the
non _WIN32 path. Were
zturner added a comment.
(The problem is that surrounding code was not clang-formatted)
http://reviews.llvm.org/D17099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
In http://reviews.llvm.org/D17099#349136, @fjricci wrote:
> Perhaps I ran clang-format in the wrong configuration, but it looks like it
> made the function declaration style in include/lldb/Target/Platform.h a bit
> inconsistent. Is this the desired behavior?
The way
(The problem is that surrounding code was not clang-formatted)
On Wed, Feb 10, 2016 at 2:53 PM Zachary Turner wrote:
> zturner added a comment.
>
> In http://reviews.llvm.org/D17099#349136, @fjricci wrote:
>
> > Perhaps I ran clang-format in the wrong configuration, but it looks like
> it made t
fjricci added a comment.
Perhaps I ran clang-format in the wrong configuration, but it looks like it
made the function declaration style in include/lldb/Target/Platform.h a bit
inconsistent. Is this the desired behavior?
http://reviews.llvm.org/D17099
___
fjricci updated this revision to Diff 47534.
fjricci added a comment.
Herald added a subscriber: srhines.
Apply clang-format
http://reviews.llvm.org/D17099
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
source/Commands/CommandObjectProcess.cpp
source/Interpreter/Com
Author: jingham
Date: Wed Feb 10 16:30:20 2016
New Revision: 260452
URL: http://llvm.org/viewvc/llvm-project?rev=260452&view=rev
Log:
Revert 260436. I pretty consistently upper-case the letter I use for the
short option as an aid to memory. Like it's w because of the W in throW.
That helps me r
zturner added a subscriber: zturner.
zturner added a comment.
Looks like there's a few inconsistencies with our coding style. Can you please
run clang-format on this patch?
http://reviews.llvm.org/D17099
___
lldb-commits mailing list
lldb-commits@
fjricci updated this revision to Diff 47524.
fjricci added a comment.
Herald added subscribers: danalbert, tberghammer, emaste.
Accidentally uploaded the wrong commit. Sorry about that
http://reviews.llvm.org/D17099
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
sourc
fjricci created this revision.
fjricci added reviewers: tberghammer, clayborg, jasonmolenda.
fjricci added subscribers: lldb-commits, sas.
Add an optional "reverse" option to the gdb-remote command,
which causes lldb to listen on the specified [host:]port,
waiting for the remote server to reverse-
Author: spyffe
Date: Wed Feb 10 16:00:32 2016
New Revision: 260445
URL: http://llvm.org/viewvc/llvm-project?rev=260445&view=rev
Log:
When importing Objective-C protocols, mark them as having external decls.
We already do this for Objective-C interfaces, but we never handled protocols
because the
Author: zturner
Date: Wed Feb 10 15:47:36 2016
New Revision: 260440
URL: http://llvm.org/viewvc/llvm-project?rev=260440&view=rev
Log:
Fix copy/paste error in TestCModules.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py
Modified:
lldb/trunk/packages/Python
Author: enrico
Date: Wed Feb 10 15:30:20 2016
New Revision: 260436
URL: http://llvm.org/viewvc/llvm-project?rev=260436&view=rev
Log:
No reason for these two letters to be uppercase
Modified:
lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
Modified: lldb/trunk/source/Commands/CommandOb
Author: gclayton
Date: Wed Feb 10 15:28:13 2016
New Revision: 260434
URL: http://llvm.org/viewvc/llvm-project?rev=260434&view=rev
Log:
Now that SymbolFileDWARF supports having types in completely separate .pcm file
with "-fmodules -gmodules", each SymbolFileDWARF can reference module DWARF
info
Sorry, that was a copy paste error. I will fix it.
On Wed, Feb 10, 2016 at 12:56 PM Siva Chandra
wrote:
> > Modified:
> lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py
> > URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/module
> Modified:
> lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py?rev=260422&r1=260421&r2=260422&view=diff
> =
Author: zturner
Date: Wed Feb 10 13:53:36 2016
New Revision: 260422
URL: http://llvm.org/viewvc/llvm-project?rev=260422&view=rev
Log:
Remove expectedFailureLinux decorator.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
lldb/trunk/packages/Pyth
Author: zturner
Date: Wed Feb 10 13:53:45 2016
New Revision: 260423
URL: http://llvm.org/viewvc/llvm-project?rev=260423&view=rev
Log:
Remove skipUnlessListedRemote.
This was supposed to have been removed but made it back in
accidentally.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/de
zturner created this revision.
zturner added reviewers: tfiala, labath, tberghammer.
zturner added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
The original motivation for this came when I tried to combine two decorators:
```
@expectedFailureDarwin
@expec
clayborg requested changes to this revision.
clayborg added a comment.
As Zach said, you could add a function to ArchSpec like:
std::string
ArchSpec::GetClangTargetCPU();
and move your code from the large switch statement into there. It can return an
empty string for any architecture that d
> On Feb 9, 2016, at 7:40 PM, Zachary Turner wrote:
>
> Seems like kind of an obscure command. Why not just set a one-shot
> breakpoint on foo by name, then continue, so that the first time the
> breakpoint hits it gets removed.
>
Maybe obscure, but not that hard to type, so it isn't onerou
> On Feb 10, 2016, at 3:45 AM, Luke Drummond wrote:
>
> ldrumm added a comment.
>
>
>
> In http://reviews.llvm.org/D17027#347487, @jingham wrote:
>
>> This seems fine as a generic instrumentation point. Obviously, the onus in
>> on the passes, since they could totally ruin the expression e
ldrumm added a subscriber: ldrumm.
ldrumm added a comment.
Hi
This patch is on an out of date ClangExpressionParser.cpp. The feature added in
http://reviews.llvm.org/rL259644 allows a more generic way of implementing what
I believe you're trying to achieve with this patch. It's probably worth a
Author: tberghammer
Date: Wed Feb 10 06:10:58 2016
New Revision: 260377
URL: http://llvm.org/viewvc/llvm-project?rev=260377&view=rev
Log:
Revert "Improve the handling of missing elf symtab and missing symbol sizes"
This reverts commit 252dda67782f2cbf838e375bce21ed4191f6d9ce.
The commit caused s
ldrumm added a comment.
In http://reviews.llvm.org/D17027#347487, @jingham wrote:
> This seems fine as a generic instrumentation point. Obviously, the onus in
> on the passes, since they could totally ruin the expression evaluation if
> they don't do their job right... But I'm not sure ther
Author: ewancrawford
Date: Wed Feb 10 05:23:27 2016
New Revision: 260372
URL: http://llvm.org/viewvc/llvm-project?rev=260372&view=rev
Log:
[RenderScript] Refactor allocation expressions
Patch refractors RS plugin code specifying how format strings are used to JIT
the runtime.
Author: Dean De L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260369: Improve the handling of missing elf symtab and
missing symbol sizes (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16996?vs=47314&id=47433#toc
Repository:
rL LLV
Author: tberghammer
Date: Wed Feb 10 04:43:34 2016
New Revision: 260369
URL: http://llvm.org/viewvc/llvm-project?rev=260369&view=rev
Log:
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260368: Fix handling of the arm IT instruction in the
unwinder (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16814?vs=46764&id=47432#toc
Repository:
rL LLVM
http://rev
Author: tberghammer
Date: Wed Feb 10 04:42:00 2016
New Revision: 260367
URL: http://llvm.org/viewvc/llvm-project?rev=260367&view=rev
Log:
Use BKPT instead of UDF for arm/thumb breakpoints
The UDF instruction is deprecated in armv7 and in case of thumb2
instructions set it don't work well together
Author: tberghammer
Date: Wed Feb 10 04:42:13 2016
New Revision: 260368
URL: http://llvm.org/viewvc/llvm-project?rev=260368&view=rev
Log:
Fix handling of the arm IT instruction in the unwinder
The IT instruction can specify condition code for up to 4 consecutive
instruction and it is used quite o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260367: Use BKPT instead of UDF for arm/thumb breakpoints
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16853?vs=46899&id=47431#toc
Repository:
rL LLVM
http://reviews.
tberghammer closed this revision.
tberghammer added a comment.
Comitted as http://reviews.llvm.org/rL260366
http://reviews.llvm.org/D17030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
Author: tberghammer
Date: Wed Feb 10 04:35:48 2016
New Revision: 260366
URL: http://llvm.org/viewvc/llvm-project?rev=260366&view=rev
Log:
Add new option to lldb-server to display its version
Modified:
lldb/trunk/tools/lldb-server/lldb-server.cpp
Modified: lldb/trunk/tools/lldb-server/lldb-se
44 matches
Mail list logo
